Skip to content

feat(directory)!: add mixed service and collection discovery - #37

Merged
nkavian merged 1 commit into
offering-protocol:mainfrom
nkavian:feat/mixed-directory-search
Sep 20, 2026
Merged

nkavian merged 1 commit into
offering-protocol:mainfrom
nkavian:feat/mixed-directory-search

Conversation

@nkavian

@nkavian nkavian commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add mixed Service and Collection search, continuation support, and filtered name suggestions.
  • Send mixed suggestions through POST with search filters; retain the separate Service-only GET suggestions API.
  • Represent Collection identity, indexing timestamps, Service attribution, and unknown future result types.
  • Update public documentation, examples, and coverage while keeping Agent federation Service-only.

Compatibility

Breaking Directory API change: Search and ContinueSearch return mixed results; SearchServices and ContinueSearchServices retain Service-only discovery. SearchSequence exposes Items and Responses instead of the previous page-oriented methods.

The mixed methods require the Directory server's new search and suggestions endpoints. Deploy the server before switching consumers. CLI integration and publication are separate work.

@codecov-commenter

codecov-commenter commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.93048% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
directory/client.go 95.55% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@nkavian
nkavian force-pushed the feat/mixed-directory-search branch from a160157 to 8d4e891 Compare September 20, 2026 20:46
@nkavian
nkavian merged commit 66a7e7a into offering-protocol:main Sep 20, 2026
2 checks passed
@nkavian
nkavian deleted the feat/mixed-directory-search branch September 20, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants