Skip to content

fix: strengthen protocol parsing and test coverage - #35

Merged
nkavian merged 1 commit into
offering-protocol:mainfrom
nkavian:test/core-protocol-coverage
Sep 14, 2026
Merged

nkavian merged 1 commit into
offering-protocol:mainfrom
nkavian:test/core-protocol-coverage

Conversation

@nkavian

@nkavian nkavian commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Expand tests for JSON round trips, additive members, response normalization, pagination, resource identities, URL boundaries, and validation errors. Exercise OpenAPI path extensions and malformed transport addresses through the existing implementations.

The tests exposed three parsing defects, corrected here:

  • Omit the whole branding object when either image has an unknown type, as required by the draft, so an otherwise usable Service Document remains valid.
  • Handle IPv6 addresses without passing their colons through domain-name conversion.
  • Reject underscore locale strings where ODP requires RFC 5646 language tags.

Validation: make verify (including race detection), make consumer-smoke, make conformance, and git diff --check passed. Coverage exclusions and thresholds are unchanged.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@nkavian
nkavian merged commit f67db5a into offering-protocol:main Sep 14, 2026
2 checks passed
@nkavian
nkavian deleted the test/core-protocol-coverage branch September 14, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants