Skip to content

Allow explicit ffmpeg path to be provided when running test suite. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom-seddon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow explicit ffmpeg path to be provided when running test suite. #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion imgui_test_suite/imgui_test_suite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ struct TestSuiteApp
Str128 OptExportFilename;
ImGuiTestEngineExportFormat OptExportFormat = ImGuiTestEngineExportFormat_JUnitXml;
ImVector<char*> TestsToRun;
Str128 OptExplicitFfmpegPath; // will try to auto detect if not provided
};

static void TestSuite_ShowUI(TestSuiteApp* app)
Expand Down Expand Up @@ -176,6 +177,7 @@ static void TestSuite_PrintCommandLineHelp()
printf(" -export-file <file> : save test run results in specified file.\n");
printf(" -export-format <format> : save test run results in specified format. (default: junit)\n");
printf(" -list : list queued tests (one per line) and exit.\n");
printf(" -ffmpeg <file> : provide explicit path to ffmpeg (will try to auto-detect if not specified).\n");
printf("Tests:\n");
printf(" all/tests/perf : queue by groups: all, only tests, only performance benchmarks.\n");
printf(" [pattern] : queue all tests containing the word [pattern].\n");
Expand Down Expand Up @@ -255,6 +257,10 @@ static bool TestSuite_ParseCommandLineOptions(TestSuiteApp* app, int argc, char*
app->OptListTests = true;
app->OptGui = false;
}
else if (strcmp(argv[n], "-ffmpeg") == 0 && n + 1 < argc)
{
app->OptExplicitFfmpegPath = argv[n + 1];
}
else
{
printf("Syntax: %s <options> [tests...]\n", argv[0]);
Expand Down Expand Up @@ -487,7 +493,10 @@ int main(int argc, char** argv)
test_io.ConfigNoThrottle = app->OptNoThrottle;
test_io.PerfStressAmount = app->OptStressAmount;
test_io.ConfigCaptureEnabled = app->OptCaptureEnabled;
FindVideoEncoder(test_io.VideoCaptureEncoderPath, IM_COUNTOF(test_io.VideoCaptureEncoderPath));
if (app->OptExplicitFfmpegPath.empty())
FindVideoEncoder(test_io.VideoCaptureEncoderPath, IM_COUNTOF(test_io.VideoCaptureEncoderPath));
else
ImStrncpy(test_io.VideoCaptureEncoderPath, app->OptExplicitFfmpegPath.c_str(), IM_COUNTOF(test_io.VideoCaptureEncoderPath));
ImStrncpy(test_io.VideoCaptureEncoderParams, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG, IM_COUNTOF(test_io.VideoCaptureEncoderParams));
ImStrncpy(test_io.GifCaptureEncoderParams, IMGUI_CAPTURE_DEFAULT_GIF_PARAMS_FOR_FFMPEG, IM_COUNTOF(test_io.GifCaptureEncoderParams));
test_io.CheckDrawDataIntegrity = true;
Expand Down