Skip to content

Remove noisy “Successfully generated … embeddings” logs from document embedding flows#226

Merged
hnwyllmm merged 5 commits into
developfrom
copilot/remove-log-successfully-generated-1-embeddings
Jun 5, 2026
Merged

Remove noisy “Successfully generated … embeddings” logs from document embedding flows#226
hnwyllmm merged 5 commits into
developfrom
copilot/remove-log-successfully-generated-1-embeddings

Conversation

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This change removes the "Successfully generated 1 embeddings"-style success log emitted during document-to-embedding generation. The goal is to eliminate noisy per-call embedding success output while preserving existing embedding behavior and error handling.

  • Scope

    • Removed success log lines from BaseClient embedding generation paths:
      • _collection_add
      • _collection_update
      • _collection_upsert
  • Behavioral impact

    • No change to embedding generation logic, input validation, or exception paths.
    • Only the explicit success message emission was removed.
# before
embeddings = embedding_function(documents)
logger.info(f"✅ Successfully generated {len(embeddings)} embeddings")

# after
embeddings = embedding_function(documents)

Copilot AI changed the title [WIP] Remove log message about generated embeddings Remove noisy “Successfully generated … embeddings” logs from document embedding flows Jun 4, 2026
Copilot AI requested a review from hnwyllmm June 4, 2026 11:59
@@ -0,0 +1,45 @@
from unittest.mock import patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot no need to add a test case.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ec95b49: reverted the added test-case expansion in tests/unit_tests/test_embedding_generation_logging.py.

Copilot AI requested a review from hnwyllmm June 4, 2026 12:10
@hnwyllmm

hnwyllmm commented Jun 4, 2026

Copy link
Copy Markdown
Member

@copilot Please delete the test case file: tests/unit_tests/test_embedding_generation_logging.py‎

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please delete the test case file: tests/unit_tests/test_embedding_generation_logging.py‎

Done in ef9a744.

@hnwyllmm hnwyllmm marked this pull request as ready for review June 5, 2026 01:47
@hnwyllmm hnwyllmm merged commit 4b5b229 into develop Jun 5, 2026
16 of 18 checks passed
@hnwyllmm hnwyllmm deleted the copilot/remove-log-successfully-generated-1-embeddings branch June 5, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: remove log: Successfully generated 1 embeddings

2 participants