Remove noisy “Successfully generated … embeddings” logs from document embedding flows#226
Merged
hnwyllmm merged 5 commits intoJun 5, 2026
Conversation
Copilot
AI
changed the title
[WIP] Remove log message about generated embeddings
Remove noisy “Successfully generated … embeddings” logs from document embedding flows
Jun 4, 2026
hnwyllmm
reviewed
Jun 4, 2026
| @@ -0,0 +1,45 @@ | |||
| from unittest.mock import patch | |||
Member
|
@copilot Please delete the test case file: tests/unit_tests/test_embedding_generation_logging.py |
Contributor
Author
hnwyllmm
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the
"Successfully generated 1 embeddings"-style success log emitted during document-to-embedding generation. The goal is to eliminate noisy per-call embedding success output while preserving existing embedding behavior and error handling.Scope
BaseClientembedding generation paths:_collection_add_collection_update_collection_upsertBehavioral impact