Remove ignore use and some unnecessary open - #6481
Merged
Merged
Conversation
rjbou
changed the title
ignore use and some opemignore use and some open
kit-ty-kate
approved these changes
Apr 22, 2025
kit-ty-kate
left a comment
kit-ty-kate
left a comment
Member
There was a problem hiding this comment.
Apart from a couple of optional suggestions and a personal opinion that the title/label doesn't quite fit (for me, API means we're changing the interface, not just doing a cleanup of the internal implementation), LGTM.
rjbou
commented
Oct 14, 2025
kit-ty-kate
marked this pull request as ready for review
July 13, 2026 14:40
kit-ty-kate
changed the title
ignore use and some openignore use and some unnecessary open
kit-ty-kate
approved these changes
Jul 14, 2026
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use instead
let _ : <typ> =to ensure that no argument is missing.