Reset the "jobs" config variable when upgrading from opam 2.0 - #5284
Merged
Conversation
kit-ty-kate
marked this pull request as ready for review
September 14, 2022 19:31
rjbou
reviewed
Sep 15, 2022
Collaborator
|
Agree on the idea, but what if user set its jobs variable to that value? Should we add a warning to inform that we are removing that value? |
rjbou
reviewed
Sep 15, 2022
Member
Author
Indeed that's a good idea. I've done that and fixed the rest of the issues. It should be good to be reviewed once again. |
rjbou
reviewed
Sep 15, 2022
rjbou
reviewed
Sep 20, 2022
kit-ty-kate
commented
Sep 20, 2022
AltGr
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ocurrent/ocaml-dockerfile#92