No ppx expect#1445
Open
jonludlam wants to merge 5 commits into
Open
Conversation
A small library used by parser and semantics expect-style tests: - Expect_test_helper.print frames input/output for snapshot comparison - Expect_test_helper.run dispatches argv[1] to a named test group, or emits the matching set of dune (diff) rules when invoked with --gen-rules so the boilerplate per test case stays in sync with the OCaml-side groups list.
Adds with_group/dump_block to the test helpers so that, when EXPECTED_DUMP_DIR is set, each let%expect_test block writes the input and expected output to a file. The existing ppx_expect assertions still run unchanged and are the source of truth for this commit; the .expected files committed here are a verifiable snapshot of what they assert.
Drop the ppx_expect dependency. The parser and semantics tests now print via Expect_test_helper.print and are dispatched as named groups via Expect_test_helper.run, with the matching set of dune (diff) rules emitted on demand into a checked-in dune.inc. Test cases are still inside modules, which looks a little odd but the means the diff doesn't change the structure.
Brief operator's guide to the snapshot-testing layout: where each file lives, how to add or remove a case or group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ppx_expect, but keep the tests!