fix(rpc): report connection failures without a backtrace - #15700
Draft
Alizter wants to merge 1 commit into
Draft
Conversation
A client connecting to a watch server that was killed without cleaning up its RPC socket gets ECONNREFUSED. This was reported as a user error with a backtrace. Format Unix errors from the connect call as a reason instead, keeping the backtrace for unexpected exceptions. Fixes ocaml#15676 Signed-off-by: Ali Caglayan <alizter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Format Unix errors returned while connecting an RPC client as user-facing
reasons instead of embedding their captured backtraces. Unexpected non-Unix
exceptions continue to include their backtraces.
A connection to a stale socket now reports:
Related Issue and Motivation
A watch server killed with
SIGKILLcannot remove_build/.rpc/dune.Connecting to the abandoned socket returns
ECONNREFUSED, which is an expecteduser-facing failure but was previously printed with an internal backtrace.
Fixes #15676.
Testing
./dune.exe runtest test/blackbox-tests/test-cases/watching/rpc-connect-after-server-killed.t./dune.exe runtest test/expect-tests/dune_rpc./dune.exe build @check @fmtdune rpc pinganddune monitor, and verified that restarting the watch server still works.No changelog or documentation update is needed for this routine error-message
improvement.