fix dune version bound for dune-project's (warnings (duplicate_deps ..)) - #15696
Open
v-gb wants to merge 1 commit into
Open
fix dune version bound for dune-project's (warnings (duplicate_deps ..))#15696v-gb wants to merge 1 commit into
v-gb wants to merge 1 commit into
Conversation
This warning requires a dune >= 3.18, but it was introduced in 17e0490, which landed in 3.22: $ jj log -r 'roots(17e0490:: & tags())' -T 'tags ++ "\n"' -G 3.22.0_alpha0 3.22.0_alpha1 This results in dune generating overly permissive opam version bounds, which then fail in opam ci. No idea if it's ok to just bump the version like this (I assume existing dune-project files that make use of this will cause failure until their dune-lang version is bumped, at which point the generated opam files will change as well). Signed-off-by: Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning requires a dune >= 3.18, but it was introduced in 17e0490, which landed in 3.22:
This results in dune generating overly permissive opam version bounds, which then fail in opam ci.
No idea if it's ok to just bump the version like this (I assume existing dune-project files that make use of this will cause failure until their dune-lang version is bumped, at which point the generated opam files will change as well).
Checklist