perf(memo): flatten parallel dependencies into arrays - #15684
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
Collaborator
|
The bench seems to indicate minor words and collections actually increased rather than decreased. |
rgrinberg
force-pushed
the
push-mxrzyuozqqlz
branch
from
August 8, 2026 07:54
bf201e0 to
6e6afba
Compare
Flattening parallel dependency sections previously converted nested arrays to lists, repeatedly appended those lists, and then copied the result back into an array. Evaluate each thread section once, count its flattened elements, and copy them directly into one final array. This reduced minor allocation by about 2.0M words (15 MiB) in both cold and no-op self-builds. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-mxrzyuozqqlz
branch
from
August 9, 2026 07:25
6e6afba to
96b27dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flattening parallel dependency sections previously converted nested arrays to
lists, repeatedly appended those lists, and then copied the result back into an
array.
Evaluate each thread section once, count its flattened elements, and copy them
directly into one final array. This reduced minor allocation by about 2.0M
words (15 MiB) in both cold and no-op Dune self-builds.