perf(memo): flatten sequential dependencies into arrays - #15683
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-smnpvpyrnpmu
branch
from
August 8, 2026 07:53
742bd58 to
19fcd53
Compare
Dynamic dependency sections are stored in reverse chronological order. Turning them into a static sequence previously reversed the outer list, converted nested arrays to lists, concatenated those lists, and finally copied the result into an array. Count the flattened elements, allocate the final array once, and fill it from the end while blitting nested sequences. This reduced minor allocation by about 6.98M words (53 MiB) in both cold and no-op self-builds. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-smnpvpyrnpmu
branch
from
August 9, 2026 07:25
19fcd53 to
03482c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic dependency sections are stored in reverse chronological order. Turning
them into a static sequence previously reversed the outer list, converted
nested arrays to lists, concatenated those lists, and finally copied the result
into an array.
Count the flattened elements, allocate the final array once, and fill it from
the end while blitting nested sequences. This reduced minor allocation by about
6.98M words (53 MiB) in both cold and no-op Dune self-builds.