Skip to content

Update action versions - #225

Merged
Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:update-actions
Mar 13, 2026
Merged

Update action versions#225
Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:update-actions

Conversation

@Leonidas-from-XIV

@Leonidas-from-XIV Leonidas-from-XIV commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

The actions currently succeed but a run shows a deprecation warning of the Node 20 runtime. For now this is ok but at some point it will break so now is a good time to update and give us some headroom for the future:

  • The download-artifact action uses the deprecated Node 20 runtime, this bumps it to the most recent version.
  • The upload-artifact action uses the deprecated Node 20 runtime, this bumps it to the most recent version.
  • The attestation action uses the Node 20 runtime and has been deprecated itself, this updates it to its successor.

@Leonidas-from-XIV
Leonidas-from-XIV force-pushed the update-actions branch 2 times, most recently from 406a14e to 2f2e337 Compare March 12, 2026 15:39
The download-artifact action uses the deprecated Node 20 runtime, this
bumps it to the most recent version.

The attestation action uses the Node 20 runtime and has been deprecated
itself, this updates it to its successor.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV
Leonidas-from-XIV marked this pull request as ready for review March 12, 2026 15:58
@Leonidas-from-XIV

Copy link
Copy Markdown
Contributor Author

Successful run (until the deployment) here: https://github.com/Leonidas-from-XIV/dune-binary-distribution/actions/runs/23010378643

mv ${{ matrix.name }}/$ARCHIVE_TARGZ .
tar -xvf $ARCHIVE_TARGZ
mkdir -p ~/.local/bin
tar xvf $ARCHIVE_TARGZ

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem to be accounted for in your PR description. What motevates the need to change logic here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is that due to only downloading the relevant artifact (e.g. download just the musl artifact on Linux) the download artifact action does no longer put the artifact in a subdirectory keyed by name but directly in the worktree, thus the code would fail.

@Leonidas-from-XIV
Leonidas-from-XIV merged commit 1f80567 into ocaml-dune:main Mar 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants