Update action versions - #225
Merged
Leonidas-from-XIV merged 1 commit intoMar 13, 2026
Merged
Conversation
Leonidas-from-XIV
force-pushed
the
update-actions
branch
2 times, most recently
from
March 12, 2026 15:39
406a14e to
2f2e337
Compare
The download-artifact action uses the deprecated Node 20 runtime, this bumps it to the most recent version. The attestation action uses the Node 20 runtime and has been deprecated itself, this updates it to its successor. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
update-actions
branch
from
March 12, 2026 15:58
2f2e337 to
ca39c10
Compare
Leonidas-from-XIV
marked this pull request as ready for review
March 12, 2026 15:58
Contributor
Author
|
Successful run (until the deployment) here: https://github.com/Leonidas-from-XIV/dune-binary-distribution/actions/runs/23010378643 |
shonfeder
approved these changes
Mar 13, 2026
| mv ${{ matrix.name }}/$ARCHIVE_TARGZ . | ||
| tar -xvf $ARCHIVE_TARGZ | ||
| mkdir -p ~/.local/bin | ||
| tar xvf $ARCHIVE_TARGZ |
Member
There was a problem hiding this comment.
This change doesn't seem to be accounted for in your PR description. What motevates the need to change logic here?
Contributor
Author
There was a problem hiding this comment.
The change is that due to only downloading the relevant artifact (e.g. download just the musl artifact on Linux) the download artifact action does no longer put the artifact in a subdirectory keyed by name but directly in the worktree, thus the code would fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actions currently succeed but a run shows a deprecation warning of the Node 20 runtime. For now this is ok but at some point it will break so now is a good time to update and give us some headroom for the future: