plugins/compressor: Fix ducking trigger when sidechain source is muted#13448
Open
ShivaPlays wants to merge 2 commits into
Open
plugins/compressor: Fix ducking trigger when sidechain source is muted#13448ShivaPlays wants to merge 2 commits into
ShivaPlays wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where the compressor continues to duck audio based on its last known envelope state when the sidechain source is muted or becomes inactive. The implementation introduces a graceful release decay using the configured release time when the sidechain source is unavailable or muted, preventing sudden volume jumps and ensuring consistent gain behavior. It also preserves standard self-compression functionality when no sidechain is configured.
Motivation and Context
This change fixes #13170.
Currently, when a sidechain source is muted in the OBS audio mixer, the compressor retains its previous gain reduction level instead of releasing. This results in audio remaining "ducked" even when the sidechain is muted or inactive. This fix ensures that the compressor behaves predictably by treating an inactive/muted sidechain as a signal for a natural release curve.
How Has This Been Tested?
I have verified this fix on a local build of OBS Studio.
Types of changes
Checklist: