frontend: Handle stuck upload dialog for crash logs#13414
Open
rue08 wants to merge 1 commit into
Open
Conversation
rue08
changed the title
rue08
changed the title
Emit crashLogUploadFailed() when the crash log file is empty or unavailable for reading. Previously, uploadCrashLogToServer() returned early without emitting a failure signal that lead to upload dialog stuck in the loading state.
rue08
force-pushed
the
fix-stuck-crash-report-dialog
branch
from
2f35fd9 to
8f224ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a crash log file was empty or unavailable for reading, CrashHandler::uploadCrashLogToServer() returned early without emitting a failure signal.
As a result, LogUploadDialog remained stuck in the loading state because neither the success nor failure path was triggered.
Emit crashLogUploadFailed() before returning when the crash log content is empty so the dialog transitions to the existing error state correctly.
Previous Dialog
Current Dialog
Motivation and Context
Fixes issue #13401.
When no valid crash log file was available, the upload dialog remained indefinitely in the loading state instead of transitioning to an error state.
How Has This Been Tested?
Tested on macOS using a locally built OBS instance.
Temporarily forced crashLogFileContent.empty() to reproduce the failure path and verified that the dialog correctly transitions to the existing error state instead of remaining stuck in the loading state.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: