Skip to content

Set disable-gpu-process-crash-limit flag for CEF - #529

Open
notr1ch wants to merge 1 commit into
obsproject:masterfrom
notr1ch:gpu-crash
Open

Set disable-gpu-process-crash-limit flag for CEF#529
notr1ch wants to merge 1 commit into
obsproject:masterfrom
notr1ch:gpu-crash

Conversation

@notr1ch

@notr1ch notr1ch commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

One of our top OBS crashers is CEF crashing the entire process if its GPU process crashes too much. Until we can figure out why the GPU is crashing so much for some users, avoid crashing OBS entirely and just have broken browser sources instead.

Motivation and Context

Avoid CEF bringing down OBS on GPU errors.

How Has This Been Tested?

Hasn't - I am unable to reproduce the GPU issues.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

One of our top OBS crashers is CEF crashing the process if the GPU
process crashes too much. Until we can figure out why the GPU is
crashing so much for some users, avoid crashing OBS entirely and
just have broken browser sources instead.
@notr1ch

notr1ch commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Note that this setting disables GPU fallback modes too, so if HW acceleration repeatedly crashes, CEF won't fall back to software. There's no setting to disable the crashing while still enabling fallback unfortunately.

@Fenrirthviti Fenrirthviti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably to be a breaking change in ways we don't expect, but I'm in favor of giving it a try. At the very least, this is likely better than taking down all of OBS with it.

CEF will already be a significant testing focus, so hopefully we sort out the major things there.

@Warchamp7

Copy link
Copy Markdown
Member

As discussed off thread I still think this is an incredibly dangerous approach. The crash in question means the GPU process has failed a certain number of times and it could not fall back to software rendering.

Setting this flag will just mean Chromium can continue to try restarting the GPU process in an infinite loop which may never succeed and simply spin it's wheels forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants