Set disable-gpu-process-crash-limit flag for CEF - #529
Conversation
One of our top OBS crashers is CEF crashing the process if the GPU process crashes too much. Until we can figure out why the GPU is crashing so much for some users, avoid crashing OBS entirely and just have broken browser sources instead.
|
Note that this setting disables GPU fallback modes too, so if HW acceleration repeatedly crashes, CEF won't fall back to software. There's no setting to disable the crashing while still enabling fallback unfortunately. |
Fenrirthviti
left a comment
There was a problem hiding this comment.
This is probably to be a breaking change in ways we don't expect, but I'm in favor of giving it a try. At the very least, this is likely better than taking down all of OBS with it.
CEF will already be a significant testing focus, so hopefully we sort out the major things there.
|
As discussed off thread I still think this is an incredibly dangerous approach. The crash in question means the GPU process has failed a certain number of times and it could not fall back to software rendering. Setting this flag will just mean Chromium can continue to try restarting the GPU process in an infinite loop which may never succeed and simply spin it's wheels forever. |
Description
One of our top OBS crashers is CEF crashing the entire process if its GPU process crashes too much. Until we can figure out why the GPU is crashing so much for some users, avoid crashing OBS entirely and just have broken browser sources instead.
Motivation and Context
Avoid CEF bringing down OBS on GPU errors.
How Has This Been Tested?
Hasn't - I am unable to reproduce the GPU issues.
Types of changes
Checklist: