Skip to content

chore(tests): poll okta generator tests instead of sleeping (PIPE-986) #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dylan-M merged 1 commit into from
Jul 31, 2026
Merged

chore(tests): poll okta generator tests instead of sleeping (PIPE-986) #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions generator/okta/okta_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@ func TestOktaGenerator_Start(t *testing.T) {
err = generator.Start(context.Background())
assert.NoError(t, err)

// Wait for some logs to be generated
time.Sleep(200 * time.Millisecond)
// Poll until logs have been generated, then stop.
require.Eventually(t, func() bool {
return len(writer.getWrites()) > 0
}, 5*time.Second, 10*time.Millisecond)

// Stop the generator
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Expand Down Expand Up @@ -159,7 +161,11 @@ func TestOktaGenerator_Stop_GracefulShutdown(t *testing.T) {
err = generator.Start(context.Background())
require.NoError(t, err)

time.Sleep(50 * time.Millisecond)
// Poll until at least one record has landed so Stop is exercised against
// actively-running workers, then stop.
require.Eventually(t, func() bool {
return len(writer.getWrites()) > 0
}, 5*time.Second, 10*time.Millisecond)

ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
Expand All @@ -185,7 +191,10 @@ func TestOktaGenerator_WriteErrors_Backoff(t *testing.T) {
err = generator.Start(context.Background())
require.NoError(t, err)

time.Sleep(200 * time.Millisecond)
// Poll until write errors have been recorded, then stop.
require.Eventually(t, func() bool {
return len(writer.getErrors()) > 0
}, 5*time.Second, 10*time.Millisecond)

ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
Expand All @@ -205,7 +214,10 @@ func TestOktaGenerator_ConcurrentWorkers(t *testing.T) {
err = generator.Start(context.Background())
require.NoError(t, err)

time.Sleep(200 * time.Millisecond)
// Poll until the combined worker output exceeds 10 records, then stop.
require.Eventually(t, func() bool {
return len(writer.getWrites()) > 10
}, 5*time.Second, 10*time.Millisecond)

ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
defer cancel()
Expand All @@ -225,7 +237,10 @@ func TestOktaGenerator_EventTypeVariety(t *testing.T) {
err = generator.Start(context.Background())
require.NoError(t, err)

time.Sleep(200 * time.Millisecond)
// Poll until many logs have been generated, then stop.
require.Eventually(t, func() bool {
return len(writer.getWrites()) > 10
}, 5*time.Second, 10*time.Millisecond)

ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
Expand Down Expand Up @@ -295,7 +310,11 @@ func TestOktaGenerator_MultipleStartStop(t *testing.T) {
err = generator.Start(context.Background())
assert.NoError(t, err)

time.Sleep(50 * time.Millisecond)
// Poll until this cycle has written at least one more log, then stop.
before := len(writer.getWrites())
require.Eventually(t, func() bool {
return len(writer.getWrites()) > before
}, 5*time.Second, 10*time.Millisecond)

ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
err = generator.Stop(ctx)
Expand Down Expand Up @@ -377,7 +396,11 @@ func TestGenerator_CountLimited(t *testing.T) {
t.Fatal("tracker should have been exhausted")
}

time.Sleep(100 * time.Millisecond)
// After tracker exhaustion, no additional records should be produced.
// Assert the bound holds across a short window instead of sleeping.
require.Never(t, func() bool {
return len(writer.getWrites()) > 5
}, 100*time.Millisecond, 10*time.Millisecond, "tracker should have halted further writes")

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
Expand Down
Loading