chore(tests): poll json generator tests instead of sleeping (PIPE-986) - #253
Merged
Conversation
Assisted-by: Claude Opus 4.8
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eKuG
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Replaces the fixed
time.Sleepwaits in the json generator tests withrequire.Eventually. Each test polls the mock writer's write and error counts. It returns as soon as the expected output appears, not after a fixed duration. Behavior-neutral.Checklist