fix(backup): exclude non-directory bind mounts from volume backups (#728) - #729
Open
chbndrhnns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #728
Problem
When backing up a service via
VolumeCopyProducer(or automatic backup mode on non-database services),DockerBackupExecutor.listSources()enumerates all mounts of typevolumeandbind.DockerBackupExecutor.streamPath()starts analpine:3helper container that mounts each source to/mnt:ro(HostConfig.Binds: ["${source.source}:/mnt:ro"]).Inside Alpine rootfs,
/mntis a directory. If a container has single-file bind mounts (e.g.nginx.conf, secrets/keys, config files) or Unix domain sockets (e.g./var/run/docker.sock), runc attempts to bind-mount the host file/socket onto the container directory/mnt, failing with:OCI runtime create failed ... mount src=..., dst=/mnt ... not a directoryThis fatal 400 error crashes the entire backup run for that service.
Solution
listSources: AddisBackupableSource()inpackages/adapters/src/backup/executors/docker.tsto inspect host paths withexistsSync()+statSync().isDirectory(). Sockets, FIFOs, and regular single files are excluded from volume backup candidates, while named volumes and directory bind mounts are retained.data.Mounts) and DB fallback parsing (service.volumes).packages/adapters/src/backup/executors/docker-list-sources.test.tsasserting that single-file bind mounts and socket mounts are excluded from live container inspection and DB fallback, while directory mounts and named volumes remain intact.