Skip to content

fix(deployments): surface partial failure decision (#664) - #707

Open
Rish-it wants to merge 1 commit into
oblien:mainfrom
Rish-it:fix/664-decision-pending-sse
Open

fix(deployments): surface partial failure decision (#664)#707
Rish-it wants to merge 1 commit into
oblien:mainfrom
Rish-it:fix/664-decision-pending-sse

Conversation

@Rish-it

@Rish-it Rish-it commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • deliver the partial-failure decision on the first terminal SSE event, before the stream closes
  • persist and replay the decision across reconnects and finished-deployment hydration
  • clear cached decision state after keep/reject while keeping warning-only deploys from opening the modal

Verification

  • full API Vitest suite passed
  • full dashboard Vitest suite passed: 96 files, 1,084 tests
  • API and dashboard TypeScript checks passed
  • focused decision lifecycle regressions passed: 25 tests

Closes #664

Copilot AI lite review requested due to automatic review settings August 24, 2026 08:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants