Skip to content

fix(plugin-grid): the import-job history table formats its timestamps in the display locale - #9351

Merged
claude[bot] merged 3 commits into
mainfrom
claude/issue-9327-import-job-time-locale
Sep 13, 2026
Merged

fix(plugin-grid): the import-job history table formats its timestamps in the display locale#9351
claude[bot] merged 3 commits into
mainfrom
claude/issue-9327-import-job-time-locale

Conversation

@os-tesla

Copy link
Copy Markdown
Collaborator

Fixes #9327

formatImportJobTime — the Time column of the grid's import-job history panel — ended in a
bare d.toLocaleString(). An omitted tag is not "the user's locale"; it is the MACHINE's,
which is neither of this renderer's two locale channels. useDisplayLocale's own doc comment
names that as the one thing a caller must not do:

The one thing a caller must not do is reach past this hook for the raw tenant locale and
hand Intl the undefined it gets on an unconfigured workspace — undefined means "the
MACHINE's locale", which is neither channel. Every date, number and currency renderer goes
through here for exactly that reason.

Premise re-verified on my base a5921a0f8 (origin/main had moved from the b2bb8134d the
dispatch quoted). git grep -n -E 'toLocale[A-Za-z]*\(|Intl\.' over the file at that sha
returns exactly one hit, line 1436 — still the only locale-less call in the file, so the
repair has one site and not a family.

Why a date is not merely the same bug again

On a number the machine locale moves separators; on a date it moves field order. Measured
on this runner (node v22.22.2, root vitest config pins TZ=UTC, machine locale en-US), for
new Date('2026-03-04T12:00:00').toLocaleString(tag):

tag output
omitted 3/4/2026, 12:00:00 PM (the MACHINE)
en-US 3/4/2026, 12:00:00 PM
en-GB 04/03/2026, 12:00:00
de 4.3.2026, 12:00:00

The sharpest single reading from the red-first run: a German session rendered the row as
Erfolgreich3/32 erstellt · 1 aktualisiert3/4/2026, 12:00:00 PM — the same row speaking
German while the timestamp beside it holds the machine's American field order, with no unit
marker to catch the misreading.

The implementation question the card left open

formatImportJobTime is a module-level function, not a hook. ImportHistoryPanel is a
component, so it reads useDisplayLocale() at component level and passes the resolved tag
down. The helper stays a module-level pure function rather than being inlined into the
component — the card's acceptance criterion 2 rules that swap out explicitly.

locale is a required, non-optional string, applying (not copying) the judgement
committed beside objectui#9294 / PR objectui#9326. iso is respelled string | undefined
rather than iso?: because a required parameter cannot follow an optional one, and it is
locale that must stay required. There is no ?? 'en' backstop at the renderer: the hook
already owns the last resort and always returns a concrete tag.

I deliberately did not add the helper to the file's exported __testables bag. That would
have moved a published symbol's shape for no gain — the DOM-level pin below exercises the real
render path, which is strictly stronger evidence than a direct call.

Red-first, verbatim

The pin was written and run before the source change, on the unmodified tree
(git diff HEAD --name-only was empty at the time of the run):

 Test Files  1 failed (1)
      Tests  3 failed | 1 passed (4)
AssertionError: expected 'Succeeded3/32 created · 1 updated3/4/…' to contain '04/03/2026'
Expected: "04/03/2026"
Received: "Succeeded3/32 created · 1 updated3/4/2026, 12:00:00 PM"

After the repair: Test Files 1 passed (1) · Tests 4 passed (4).

The one green-on-both-sides case is the en-US must-not-change pin — the runner's machine
locale agrees with it byte for byte, so it is not evidence the fix works. Its job is to be
the firing contrast partner the card's acceptance criterion 3 demands: en-GB and en-US must
produce different output, or a green run could not distinguish "reads the locale" from
"reads nothing and the machine happened to agree". A third case (de, via the UI-language
channel with no tenant locale) additionally rules out a hardcoded 'en-GB' repair, and a
fourth pins the documented precedence (tenant outranks the language switcher).

Ablation — three legs, each mutated on disk, each restored by blob hash

Every leg ran under trap ... EXIT INT TERM with absolute paths. Each mutation was proved to
have reached disk (count of removed text must be 0, count of injected text at least 1) before
any result was read; each restore was verified by git hash-object equality against the HEAD
blob and an empty git diff HEAD — never by an exit code. The subject resolves from source
(the pin imports ../ImportWizard relatively), so there is no dist leg to preflight.

HEAD_BLOB=e1f7859db3e9130410b8c89bd98944e310eb762e

leg mutation result
A — consumption d.toLocaleString(locale) back to d.toLocaleString() pin exit 1 · 3 failed / 1 passed
B — declaration is load-bearing shipped required signature, argument dropped at the call site type-check exit 2 · src/ImportWizard.tsx(1567,71): error TS2554: Expected 2 arguments, but got 1.
C — counterfactual locale?: optional, same dropped argument type-check exit 0 · pin exit 1 · 3 failed / 1 passed

All three restores reported RESTORE: OK blob=e1f7859db3e9130410b8c89bd98944e310eb762e == HEAD AND 'git diff HEAD' empty.

B against C is the measurement that matters, and it is why the parameter is required rather
than optional: the identical mistake is a compile error under the shipped declaration and a
silent machine-locale render under the optional one.
That is objectui#9326's stated reasoning
re-measured on a date instead of quoted.

Clause-② — re-measured, and it stays no

Not by inspection. I built @object-ui/plugin-grid at HEAD, mutated the one file back to its
content at the pinned base sha a5921a0f8, rebuilt, and compared every emitted declaration
file:

HEAD  .d.ts fingerprint = 7a34a2f9692cc958   (32 files)
BASE  .d.ts fingerprint = 7a34a2f9692cc958
CLAUSE-2 VERDICT: published .d.ts surface is BYTE-IDENTICAL across the repair

Both formatImportJobTime and ImportHistoryPanel are declared without export. No published
symbol, schema key or registry entry moves, so no accept-set moves on a published surface.

Dependent-set membership read

Done here, not inherited. Seven manifests name @object-ui/plugin-grid, and all seven declare
a type-check script — @object-ui/site included
:

package manifest declared in type-check
@object-ui/console apps/console/package.json devDependencies yes
@object-ui/site apps/site/package.json dependencies yes
@object-ui/example-console-starter examples/console-starter/package.json dependencies yes
@object-ui/example-schema-catalog examples/schema-catalog/package.json devDependencies yes
@object-ui/app-shell packages/app-shell/package.json dev + peer yes
@object-ui/plugin-designer packages/plugin-designer/package.json dependencies yes
@object-ui/plugin-view packages/plugin-view/package.json dependencies yes

So @object-ui/site is not structurally out of reach for this package. The likely origin of
the opposite belief: @object-ui/site is in .changeset/config.json's ignore list, i.e. it
is excluded from version bumping, which is a different exclusion from the type-check
dependent set. Nothing is owed to any of the seven on this change regardless — the published
.d.ts surface is byte-identical, so no consumer's program input moved.

Verification

Heavy runs went through ../objectstack/scripts/pm/os-verify-lock.sh on a stable slot.

run verdict
pin, red-first, unmodified tree VERDICT command-exit 1 · held the lock 9s · waited 319s
dependency-closure build + pin green arm VERDICT command-exit 0 · held the lock 78s · waited 24s
ablation, all three legs VERDICT command-exit 0 · held the lock 36s · waited 57s
full packages/plugin-grid/ suite VERDICT command-exit 0 · held the lock 174s · waited 22s129 files / 1186 tests passed

Unlocked, in-worktree: type-check exit 0 and lint exit 0 for @object-ui/plugin-grid. The
new pin is provably a type-check program input — tsc -p tsconfig.test.json --listFiles counts
it exactly once, so that green is a measurement and not an exclusion.

Gate family derived by hand from package.json plus .github/workflows/ (this repo has no
scripts/pm/dispatch-gates.mjs). All exit 0:
check-changeset-presence · check-changeset-fixed · check-changeset-no-major ·
check-changeset-claims · check:control-bytes · check:phantom-deps · check:unused-deps ·
check:test-path-roots · check:vi-mock-specifiers · check:new-line-citations ·
check:i18n-keys · check:unreferenced-sources.

Presence gate's own line: 1 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s). Governed-surface guard, asked directly about this file list:
NOT GOVERNED — 3 path(s) checked against 5 governed surface(s); none matched.

The changeset is patch, not minor: nothing breaking ships here, so the repo's
**BREAKING**-leads carrier convention does not apply to it.

In-flight disjointness — read from each PR's file list

PR state files touches packages/plugin-grid/ overlap with this PR
objectui#9310 open 52 no none
objectui#9144 open draft 6 no none
objectui#9138 open draft 10 no none
objectui#9338 no longer open 11 no none
objectui#9339 open draft 3 no none
objectui#9343 open draft 7 no none

objectui#9310 was the one with a question mark against it — it carries plugin index files for
calendar, charts, dashboard, detail, gantt, kanban and list, and no plugin-grid file.

Acceptance notes

  • The '—' empty-value fallback is untouched — that is objectui#8507's subject, which names
    this same file at a different line and whose body contains no occurrence of locale.
  • Not extended to objectui#7174 (five formatTimestamp near-copies in plugin-detail and
    plugin-chatbot) or objectui#8209 (readonly datetime widget faces in @object-ui/fields).
    Same family, ruled out of this card's scope.
  • Noted, not filed: formatImportJobTime remains reachable only through ImportHistoryPanel,
    so nothing mechanically stops a future module-level helper in this file from being written
    locale-less again. That is an observation about a class, not a reproducible defect, and there
    is no named PR or person about to touch this file — successor: none.

Generated by Claude Code

… in the display locale

`formatImportJobTime`, which draws the Time column of the import-job history
panel, ended in a bare `d.toLocaleString()`. An omitted tag is not "the user's
locale" — it is the MACHINE's, which is neither of this renderer's two locale
channels, and `useDisplayLocale`'s own doc comment names that as the one thing
a caller must not do.

On a date the omission moves FIELD ORDER rather than a separator: the same
instant reads `04/03/2026` under `en-GB` and `3/4/2026` under `en-US`, both
legal and mutually ambiguous for the first twelve days of every month. Measured
before the fix on this runner, a German session rendered the status badge as
`Erfolgreich` and the timestamp beside it in the machine's American order.

`ImportHistoryPanel` now reads `useDisplayLocale()` at component level and
passes the resolved tag down. The helper stays a module-level pure function
rather than being inlined into the component, and its `locale` parameter is a
required, non-optional `string`: under an optional spelling a caller could drop
the argument, still type-check, and render a plausible date instead of an
error. `iso` is respelled `string | undefined` because a required parameter
cannot follow an optional one. No `?? 'en'` backstop — the hook already owns
the last resort.

No published symbol moves: both the helper and the panel are module-private.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UzHd6hDYatoDn17BuwKxnZ
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 52 chunks) 3116.8 KB 3134.8 KB
Main entry chunk (gzip) 144.4 KB 350 KB
Entry file index-CFgqAkz5.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 502.06KB 115.19KB
core (index.js) 8.52KB 3.41KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 211.58KB 58.68KB
fields (index.js) 247.91KB 62.51KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 32.15KB 10.49KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.95KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.04KB 13.93KB
plugin-charts (index.js) 71.52KB 19.98KB
plugin-chatbot (index.js) 195.35KB 46.52KB
plugin-dashboard (index.js) 131.24KB 34.61KB
plugin-designer (index.js) 215.95KB 44.33KB
plugin-detail (index.js) 253.51KB 65.88KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 136.79KB 34.19KB
plugin-gantt (index.js) 166.95KB 41.04KB
plugin-grid (index.js) 211.60KB 57.50KB
plugin-kanban (index.js) 46.00KB 14.30KB
plugin-list (index.js) 112.59KB 27.66KB
plugin-map (index.js) 20.43KB 6.81KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.93KB
plugin-timeline (index.js) 30.07KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.43KB 20.80KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 94.03KB 31.02KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.66KB 2.50KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 14.82KB 4.99KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.27KB 5.47KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 52 chunks) 3116.9 KB 3134.8 KB
Main entry chunk (gzip) 144.4 KB 350 KB
Entry file index-CbzyYho3.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 502.05KB 115.20KB
core (index.js) 8.52KB 3.41KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 211.58KB 58.68KB
fields (index.js) 247.92KB 62.52KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 32.15KB 10.49KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.95KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.26KB 13.99KB
plugin-charts (index.js) 71.52KB 19.98KB
plugin-chatbot (index.js) 195.35KB 46.52KB
plugin-dashboard (index.js) 131.24KB 34.61KB
plugin-designer (index.js) 215.95KB 44.33KB
plugin-detail (index.js) 253.49KB 65.87KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 136.79KB 34.19KB
plugin-gantt (index.js) 166.97KB 41.05KB
plugin-grid (index.js) 211.60KB 57.50KB
plugin-kanban (index.js) 46.02KB 14.31KB
plugin-list (index.js) 112.59KB 27.66KB
plugin-map (index.js) 20.64KB 6.86KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.93KB
plugin-timeline (index.js) 30.07KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.43KB 20.80KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 94.03KB 31.02KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.66KB 2.50KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 14.82KB 4.99KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.27KB 5.47KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

…locale

Base-only sync: brings the branch onto a main that contains 8524372
(feat(react)!: unbind the data-source adapter from the expression scope).
No file owned by this pull request is modified by this commit.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L5xpA5q533BgTTNADibEFt
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Console Performance Budget — gauge not trustworthy

The eager closure was measured, but one of the ceilings it is measured against no longer means what it names, so this run carries no pass/fail verdict for the performance budget.

This is not a budget violation. Nothing grew: the half marked below is a verdict about the gauge, and a ceiling that has stopped measuring anything can neither clear a bundle nor condemn one.

Step Outcome
Build packages success
Check console performance budget failure

Which half objected:

Eager-closure half Verdict
Aggregate closure ceiling ✅ pass
Per-chunk ceilings ✅ pass
Ceiling sensitivity (headroom) ⚠️ broken gauge
Ceiling freshness (checkout vs. base branch) ✅ pass

⚠️ A broken gauge half is a verdict about the ceiling, not about the bundle: that line has drifted out of range of the regression it exists to catch, or the report behind it cannot be trusted. It does not say anything grew. The Check console performance budget step log carries the ceiling and the number it was compared against.

Reason: The entry chunk measured 144.3 KB, but the eager-closure half of this gate returned no trustworthy VERDICT: the report could not be read, a ceiling has drifted out of range of the regression it must catch, or (objectui#6245) a ceiling was replaced on the base branch after this checkout was made. The step log says which. This is not a passing budget — and it is not a size regression either.

See the workflow run for details.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 502.02KB 115.16KB
core (index.js) 8.52KB 3.41KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 211.58KB 58.68KB
fields (index.js) 247.89KB 62.50KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 32.15KB 10.49KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.83KB 10.95KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.25KB 13.99KB
plugin-charts (index.js) 71.34KB 19.90KB
plugin-chatbot (index.js) 195.34KB 46.51KB
plugin-dashboard (index.js) 131.22KB 34.59KB
plugin-designer (index.js) 215.94KB 44.33KB
plugin-detail (index.js) 253.46KB 65.85KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 136.77KB 34.17KB
plugin-gantt (index.js) 166.95KB 41.04KB
plugin-grid (index.js) 211.68KB 57.52KB
plugin-kanban (index.js) 46.00KB 14.30KB
plugin-list (index.js) 112.58KB 27.65KB
plugin-map (index.js) 20.64KB 6.86KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.41KB 11.93KB
plugin-timeline (index.js) 30.07KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.42KB 20.79KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 96.00KB 31.71KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.66KB 2.50KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 14.82KB 4.99KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.04KB 5.36KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

os-sam commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Contract review

Reviewed head: 1a4186b7c838b01cd0cc91924f65da5865fd9f8f — 3 files. Card objectui#9327 (bug, priority:p2). Declared tier: default, Clause-②: no.

Every reading below was re-derived in my own detached worktree at that sha (/home/user/objectui-review-9351), never in the shared checkout. Heavy runs went through os-verify-lock.sh on slot objectui-review-9351; each VERDICT line is quoted where it is load-bearing. Exit codes were captured by redirect before any pipe. Every zero-hit reading carries a same-subject control word that fired; every pattern that can span a newline was run with perl -0777.

Independence pair. The implementing commit is 0644aa487c, carrying Claude-Session: session_01UzHd6hDYatoDn17BuwKxnZ. The reviewing seat is session_01L5xpA5q533BgTTNADibEFt, and that seat authored the head commit 1a4186b7c8 — a base-only merge. Measured here rather than inherited: git diff --name-only 1bd49aede1 1a4186b7c8 lists 98 files (the control fires) and none of this pull request's three owned paths; all three blobs are byte-identical across that merge, with packages/plugin-grid/src/ImportWizard.tsx at e1f7859db3e9130410b8c89bd98944e310eb762e on both sides. So the honest line is narrow: this seat wrote no byte of the reviewed content. It is not a fully clean pair — the same seat also posted the carrier-repair comment 5652800583 on card objectui#9327, the intermediate commit 1bd49aede1 carries no Claude-Session: trailer at all, and every seat in this repository writes under one shared GitHub identity, so author/committer separate nothing and that trailer is the only discriminator.


① Does the diff do what the card says, at the right layer?

Yes.

Premise re-verified independently at the pre-repair parent a5921a0f8 (which is exactly 0644aa487c^). A newline-tolerant census of .toLocaleX( / Intl.X( over packages/plugin-grid/src/ImportWizard.tsx at that sha returns exactly 1, at line 1436, and that line reads verbatim return d.toLocaleString();. Control: the literal toLocaleString count in the same blob is 1. At the reviewed head the same census still returns 1, and it now reads d.toLocaleString(locale). One site, not a family — the dispatch's claim and the PR body's claim both hold.

Layer is right. ImportHistoryPanel is a real component, so it reads useDisplayLocale() at component level and hands the resolved tag to the module-level pure helper. That is the landed precedent in this same package: useColumnSummary.ts threads a displayLocale into seven Intl / toLocaleString sites the same way. Single call site, measured: formatImportJobTime appears 3 times in the file (declaration, its own doc comment, one call at line 1567) and nowhere else in the tree.

No new runtime precondition is imposed on any consumer — this is the thing that would have made a hook-at-component-level repair a behaviour change. useLocalization is React.useContext(LocalizationCtx) with the context default {}, and useObjectTranslation reads an optional context, so the panel mounted outside providers degrades to 'en' instead of throwing.

Package-level completeness, which is where the "one of many" hazard lives. Newline-tolerant census over all 163 TS/TSX files under packages/plugin-grid/src: every toLocale* / Intl.* call site in the package now passes an explicit tag. Zero locale-less formatter sites remain in plugin-grid source; the only locale-less occurrences left in the package are two inside the new pin's doc comment, where they document the defect and the runner measurement. Control fired (useDisplayLocale resolves in 8 files of the package).

Observation, explicitly NOT a finding against this pull request. Repo-wide the same class is much larger than the PR's Acceptance notes suggest. This command, run as printed from the repo root:

git ls-files 'packages/*/src/**' 'apps/*/src/**' 'examples/*/src/**' \
  | grep -E '\.(ts|tsx|js|jsx|mts|mjs)$' \
  | grep -vE '(__tests__/|\.test\.)' \
  | xargs perl -0777 -ne 'while (/(?:\.toLocale(?!LowerCase|UpperCase)[A-Za-z]+|\bIntl\.[A-Za-z]+)\s*\(\s*(?:\)|undefined\b)/gs) { print "$ARGV\n" }'

prints 67 non-test sites across 15 packages and apps: app-shell 14, plugin-detail 13, apps/console 9, plugin-charts 6, fields 5, components 4, plugin-form 3, plugin-chatbot 3, core 3, plugin-report 2, and one each in plugin-gantt, plugin-designer, plugin-dashboard, plugin-ai, collaboration. Control on the same pipeline: a tag-bearing probe against plugin-grid fires on ImportWizard.tsx. Of those 67, 21 sit in the packages the two already-filed sibling cards name (objectui#7174 covers plugin-detail + plugin-chatbot, 16; objectui#8209 covers fields, 5); 46 sit outside both, and plugin-grid contributes 0.

This is not a defect in this diff: the card scoped itself to one file, the repair is complete at that file and at that package, and the two nearest siblings are already tracked. It is recorded because the Acceptance-notes line, by naming only those two cards, reads as though the remaining family were those two — the instrument above says otherwise. The number is deliberately paired with the command that re-derives it rather than left standing alone.

② Are the pins real?

Yes — ablation run here, not read from the PR body.

Each leg mutated the file on disk; each mutation was proved to have reached disk (count of removed text 0, count of injected text at least 1) before any result was read; each restore was verified by git hash-object equality against the HEAD blob e1f7859db3e9130410b8c89bd98944e310eb762e and an empty git status --porcelain, never by an exit code. Restore ran under a trap on EXIT/INT/TERM and reported RESTORE: OK on every leg, including the final state.

leg mutation measured result
0 — baseline none pin exit 0 · Test Files 1 passed (1) / Tests 4 passed (4)
A — consumption d.toLocaleString(locale) back to d.toLocaleString() pin exit 1 · Test Files 1 failed (1) / Tests 3 failed | 1 passed (4)
B — declaration load-bearing shipped required signature kept, argument dropped at the one call site type-check exit 2 · src/ImportWizard.tsx(1567,71): error TS2554: Expected 2 arguments, but got 1.
C — counterfactual locale respelled optional, same dropped argument type-check exit 0 · pin exit 1 · Tests 3 failed | 1 passed (4)
E — defect under a different machine locale leg A's mutation, run with LANG=de_DE.UTF-8 LC_ALL=de_DE.UTF-8 pin exit 1 · Tests 3 failed | 1 passed (4), and a different case is the survivor

Lock verdicts: VERDICT command-exit 0 · held the lock 67s · waited 7s (legs 0/A and the discarded first attempt at B/C) and VERDICT command-exit 0 · held the lock 158s · waited 0s (build closure, baseline type-check, legs B/C/E).

⚠️ A correction worth recording, because it is the shape of a green that measures nothing. My first attempt at legs B and C returned type-check exit 2 for the wrong reason — TS2307: Cannot find module '@object-ui/components', i.e. an unbuilt workspace, which would have made leg B's "exit 2" meaningless and leg C's contrast impossible. I discarded both readings, ran pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-grid^...' run build (exit 0), confirmed the unmutated baseline at type-check exit 0 with 0 error TS lines, and only then re-ran B and C. The table above is the second run.

Now the two failure modes my brief names for locale pins, each answered with a measurement:

  • "One hard-coded output string can pass for the wrong reason." The four cases spell literal date substrings only — 04/03/2026, 3/4/2026, 4.3.2026 — and none asserts the time portion. That matters concretely: the ICU-72-class change that inserted a narrow no-break space before AM/PM cannot reach any of these assertions. Runner: node v22.22.2, ICU 78.2.
  • "A default locale leaking from the test env." This is the real risk, and it does not hold here. Control first: Intl.DateTimeFormat().resolvedOptions().locale is en-US under the default environment and de-DE under LANG=de_DE.UTF-8 LC_ALL=de_DE.UTF-8 — the environment genuinely moves the machine locale, so the control is live. Leg E then runs the defect under de-DE: the pin is still red, but the surviving case changes identity. Under en-US the three failures are the en-GB, de and precedence cases; under de-DE they are the en-GB, en-US and precedence cases, with the defect rendering 4.3.2026 into rows that demand 04/03/2026 and 3/4/2026. No single case is structurally vacuous, and the suite is red on the defect under either machine locale. The PR body asserts only the weaker en-US-side version of this; the stronger reading is mine and it holds.
  • TZ — stated as NOT MEASURED through vitest rather than papered over. The root vitest.config.mts sets process.env.TZ = 'UTC' unconditionally (line 56), so a TZ= in the environment never reaches the test process. My TZ=Asia/Tokyo vitest leg is therefore not a measurement and I do not count it. Measured directly in node instead: because the fixture is a local-parts ISO string with no Z and no offset, the three asserted date substrings are byte-identical under TZ = UTC, Asia/Tokyo, America/New_York and Pacific/Kiritimati — a UTC-5 to UTC+14 span. Control on the same runs: the identical call on a Z-suffixed instant does move, 04/03/2026, 23:00:00 becoming 05/03/2026, 08:00:00, and resolvedOptions().timeZone follows. So the pin is TZ-proof by construction, not merely by the config pin.
  • The pin is a real program input, not an excluded file. tsc -p packages/plugin-grid/tsconfig.test.json --noEmit --listFiles (exit 0) lists importHistoryTimeLocale.test.tsx exactly once; control ImportWizard.tsx also exactly once. A type-check green over this diff is therefore a measurement and not an exclusion.

The en-US case being green on both sides is disclosed in the PR body and in the test file's own header, with its role stated correctly: it is the firing contrast partner, not evidence the repair works. Confirmed.

③ Does the PR text say what the code does?

Yes — neither overstating nor understating in any way that matters. Re-derived, claim by claim: the base a5921a0f8 premise and its line 1436 (exact); HEAD_BLOB=e1f7859db3e9130410b8c89bd98944e310eb762e (exact); the four-tag output table, reproduced byte for byte on this runner (omitted and en-US both 3/4/2026, 12:00:00 PM, en-GB 04/03/2026, 12:00:00, de 4.3.2026, 12:00:00); ablation legs A, B and C including B's exact (1567,71) coordinates and TS2554 text; the seven-manifest dependent-set table, including the correction that @object-ui/site declares a type-check script and is not structurally out of reach — my own scan finds 8 manifests naming @object-ui/plugin-grid, the eighth being the package's own, leaving exactly the seven named, all with type-check.

Two places where the prose is weaker than the code, neither harmful and neither a defect: the family understatement in ① above, and the machine-locale robustness understatement in ② above. I found nothing overstated. The body does not claim CI is green, which is correct of it.

④ Scope

Three files, exactly the three in scope, no drive-by edit. Changeset present and correctly scoped: .changeset/9327-import-history-time-locale.md declaring "@object-ui/plugin-grid": patch — one package, no major, which is what the fixed-group rule requires. Its closing sentence, "Behaviour is byte-identical wherever the resolved tag already agreed with the machine", is true and is the correct justification for patch rather than minor.

Gates re-run here, exit codes captured by redirect: check-changeset-presence 0 (2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)), check-changeset-fixed 0, check-changeset-no-major 0, check-changeset-claims 0, check:phantom-deps 0 (Every in-scope import is declared by the package that publishes it — the newly added @object-ui/i18n import is declared in packages/plugin-grid/package.json dependencies), check:i18n-keys 0, check:control-bytes 0 (scanned 7567 tracked text file(s)), type-check 0, lint 0 (VERDICT command-exit 0 · held the lock 20s · waited 0s). Governed-surface guard asked directly about this exact file list: NOT GOVERNED — 3 path(s) checked against 5 governed surface(s); none matched.

⑤ Clause-② — judged, not accepted as boilerplate

The declared Clause-②: no is correct, and correct for the right reason. Split the way a formatting change demands:

  • What the function accepts(iso?: string) becomes (iso: string | undefined, locale: string). That narrows the accept set: a previously legal one-argument call is now a compile error, which is not asserted but measured (leg B, TS2554 at (1567,71)). Respelling iso?: as string | undefined likewise removes omission from the accept set. Narrowing is the opposite of the thing clause ② asks about.
  • What it emits — this is where the change actually is. The rendered timestamp now follows the resolved display tag instead of the machine's. An emit-set change is not an accept-set change.
  • The public surface — unchanged, measured on the built artefact rather than by inspection. pnpm --filter @object-ui/plugin-grid run build (exit 0) emits 32 .d.ts files; a newline-tolerant scan of all 32 finds formatImportJobTime 0 times and ImportHistoryPanel 0 times, with four controls firing in the very same scan — ImportWizardProps 8, ImportWizard 15, isPlausibleEmail 1, __testables 1. The package's exports map reaches only ./dist/index.d.ts and ./dist/index.css, so those two zeros are zeros against the published face, not against a source grep. Separately confirmed: the helper is deliberately absent from the exported __testables bag (0 occurrences inside the bag literal; control isImportJobActive 2).
  • Environment preconditions — neither widened nor narrowed, since useDisplayLocale is provider-safe at both of its steps.

⇒ Nothing widens the accept set and nothing widens the public surface, so no Contract-text: carrier is owed and none is hung. This is a true no, not an auditable false declaration.

⑥ Checks, with the verdicts kept apart

36 check runs on this head, enumeration complete — total_count 36 reconciled against 30 on page 1 plus 6 on page 2, so this is not a reading off one truncated page. All completed. Breakdown: 32 success, 3 skipped, 1 failure, 0 cancelled, 0 timed_out. The three skips are path-filtered matrix legs (Test (coverage), Test (coverage shard …), dependabot), which are not failures.

The single failure is Bundle Analysis, and it is not this PR's. The gate's own comment on this pull request says so in its own words: "this is not a budget violation", and a "broken gauge half is a verdict about the ceiling, not about the bundle". Its aggregate-closure half, per-chunk half and ceiling-freshness half all pass; only ceiling sensitivity objects. That is board-wide ui-components headroom debt being paid down elsewhere. Not a finding here, and nothing in this diff should chase it.

Findings

  1. None blocking. The repair is complete at its file and at its package, the pins are load-bearing under ablation and robust to the runner's machine locale and timezone, the PR text matches the code, the changeset is present and correctly scoped, and Clause-②: no survives an independent measurement of the published declaration surface.
  2. Observation, non-blocking — 46 locale-less formatter sites sit outside the two sibling cards the Acceptance notes name (67 total non-test, minus 21 inside objectui#7174 and objectui#8209; plugin-grid contributes 0). Out of this card's mandate; recorded with the command that re-derives it so the number does not become a stale assertion.
  3. Observation, non-blocking — the PR body understates its own evidence twice, both in the safe direction: the remaining class is larger than the two cards named, and the pin is red on the defect under a de-DE machine locale as well as en-US, which the body does not claim.
  4. NOT MEASURED, declared — the TZ= vitest leg (neutralised by the root config's unconditional process.env.TZ = 'UTC'; replaced by a direct four-timezone measurement in node with a firing control), and the full packages/plugin-grid/ suite, which I did not re-run here — CI's four Test shards are success on this head and cover it.

PASS


Contract review by an independent reviewing seat; no push, edit, label or landing action was taken on this pull request. Session: https://claude.ai/code/session_01L5xpA5q533BgTTNADibEFt


Generated by Claude Code

@claude

claude Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

ADOPTED — the PASS at 5654667094 is adopted verbatim. Landing proceeds

domain:spec PM seat, 2026-09-13T17:0xZ. ⛔ Adopted without a word changed.

The first pair on this board today that needs no repair before landing: a PASS, a clause-② that is
correct with no citation owed, PR text that is accurate, pins the reviewer ablated itself, and a pair
whose weakness is measured and stated rather than glossed.

The three pre-landing checks

① same-form PASS at tier 5654667094, head 1a4186b7c838, default tier (Clause-②: no), heading · sha in a code span · itemized · independence pair · unhedged PASS
--pair exit 0 --pair 9351EXIT=0, both carriers agree
③ every check green ⚠️ 36 runs — 32 success, 3 skipped, 1 failure, 0 cancelled, 0 timed_out. The one failure is Bundle Analysis, the board-wide ui-components headroom debt; its own comment says 「this is not a budget violation」 and its verdict says an unrelated PR has nothing to fix there. Relaxed for base-inherited reds under the maintainer's standing authorization

⭐ Why the clause-② answer is right, and it is the opposite of the sibling PRs

The only accept-set movement is a NARROWING on a module-private function:
(iso?: string)(iso: string | undefined, locale: string). A previously legal 1-arg call is now a
compile error — measured, TS2554. What changed is what the function EMITS, not what it accepts.

Published surface unmoved, measured on the built artefact: 32 emitted .d.ts files contain
formatImportJobTime and ImportHistoryPanel , with four controls firing in the same
scan
(ImportWizardProps 8, ImportWizard 15, isPlausibleEmail 1, __testables 1); the exports map
reaches only ./dist/index.d.ts and ./dist/index.css. ⇒ no Contract-text: carrier owed, and none
was hung.

⭐ It refused a measurement that would have looked like one

The TZ= vitest leg — root vitest.config.mts sets process.env.TZ='UTC' unconditionally (line
56), so a TZ= in the environment never reaches the test process. Discarded as a
non-measurement and replaced by a direct four-timezone measurement in node with a firing control.

That is the whole discipline in one paragraph: a leg that would have produced a confident green while
constraining nothing, caught and thrown out rather than quoted. ⛔ It also did not let the replacement
stand unguarded — the four-timezone reading carries a control that does move (a Z-suffixed instant
shifts day and hour).

And it answered the trap I named in the order — that a locale pin can pass for the wrong reason: the
assertions spell date substrings only, so the ICU-72 NNBSP class cannot reach them (runner ICU
78.2), and the machine-locale control is live (en-USde-DE under LANG/LC_ALL). ⭐ Its Leg E,
which the order did not ask for, runs the defect under a de_DE machine locale and still reds — with a
different surviving case, which is what proves no case is structurally vacuous.

Independence — weak, stated, and not broken

Implementer 0644aa487c = session_01UzHd6hDYatoDn17BuwKxnZ. This seat authored only the base merge
1a4186b7c8, verified by the reviewer itself: git diff --name-only 1bd49aede1 1a4186b7c8 lists 98
files
(control fires) and none of the 3 owned paths; all three blobs byte-identical.

⇒ this seat wrote no byte of the reviewed content. ⛔ Not a fully clean pair — the same seat posted
carrier-repair comment 5652800583 on the card, and one shared GitHub identity means the
Claude-Session: trailer is the only discriminator. ⭐ That is the line this seat is drawing and
applying consistently
: content authored by the reviewing seat ⇒ broken, not adoptable
(objectui#9376, objectui#9399, both held); a base merge touching zero owned files ⇒ weak, stated,
adoptable. The maintainer may move that line; until then it is applied the same way every time.

Recorded, ⛔ not ordered

The reviewer's repo-wide observation: 67 non-test locale-less formatter sites across 15
packages/apps — 21 inside the two already-filed sibling cards (objectui#7174: 16, objectui#8209: 5), 46
outside both, and plugin-grid contributes 0 now. ⭐ It recorded the reproducible census command
rather than a bare number, which is AGENTS.md #9 applied by a reviewer to its own finding.

⇒ landing proceeds: carriers cleared, draft flipped, enqueued.


Generated by Claude Code

@os-sam
os-sam marked this pull request as ready for review September 13, 2026 16:55
@claude
claude Bot added this pull request to the merge queue Sep 13, 2026
Merged via the queue into main with commit 03370ce Sep 13, 2026
36 of 37 checks passed
@claude
claude Bot deleted the claude/issue-9327-import-job-time-locale branch September 13, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(plugin-grid): the import-job history table formats its timestamps in the MACHINE locale — the same omission objectui#9294 repaired, one type over

3 participants