Skip to content

fix(types,docs): refuse actions by name on the page node, teach the shape that draws (objectui#7926) - #8870

Merged
os-zhuang merged 2 commits into
mainfrom
claude/issue-7926-page-actions-refuse-and-docs
Sep 9, 2026
Merged

fix(types,docs): refuse actions by name on the page node, teach the shape that draws (objectui#7926)#8870
os-zhuang merged 2 commits into
mainfrom
claude/issue-7926-page-actions-refuse-and-docs

Conversation

@claude

@claude claude Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #7926

Maintainer ruling 5596252247 (director seat, summon #20, decision batch #107 item 2, verbatim
「其他同意」) → option A. Two steps, one card: the layout guide teaches the shape that
draws, and the page node refuses the undeclared actions key instead of letting
BaseSchema's .passthrough() carry it to a wrapper that draws nothing. B (declare +
render — a fourth actions shape) and C (docs only, schema keeps swallowing it) were
refused and are not reopened here.

What was wrong

PageNodeSchema never declared actions; PageRenderer never read it. git grep -ni action packages/components/src/renderers/layout/page.tsx returns only the PageVariableActionBridge
import and its render — with schema.title / schema.pageType (3 hits, same file) as the lit
control. Through the real SchemaRenderer, a page node carrying
actions: [{type:'button',label:'Add Product'}, …] drew 0 buttons and the label appeared
nowhere in the DOM; the SAME two buttons in body drew 2. Three passages of
content/docs/guide/layout.md taught exactly that document.

What changed

File Change
packages/types/src/zod/layout.zod.ts PageNodeSchema.actions is now an ADR-0049 retirementTombstone arm — refused by name, with the remedy in the message
packages/types/src/layout.ts the TS twin, actions?: never, so tsc refuses it at the authoring site
content/docs/guide/layout.md the three teaching passages rewritten onto body; the Schema API block's phantom actions?: SchemaNode[] row removed
packages/types/src/__tests__/page-actions-refusal-7926.test.ts the contract pin
packages/components/src/__tests__/guide-layout-page-buttons-7926.test.tsx the render pin — the load-bearing half
.changeset/7926-page-node-refuses-actions.md @object-ui/types: patch (accept-set change)

⭐ The census came first, as the ruling required

Measured on 8fda00905 BEFORE the refusal was written, over every git-tracked JSON file, every
```json fence in .md/.mdx, and every TS/TSX object literal (TypeScript AST, so keys are
read rather than grepped):

PAGE NODES READ: 91
BLIND SPOT (page-bearing sites the census could NOT read): 8
   content/docs/guide/layout.md:231 / :501 / :650 / :721   json fence did not parse (elision)
   content/docs/guide/record-edit-modes.md:26              json fence did not parse (elision)
   content/docs/utilities/runner.mdx:494                   json fence did not parse (elision)
   packages/app-shell/README.md:585                        json fence did not parse (elision)
   packages/app-shell/src/views/runtime-metadata-persistence.ts:61   literal carries a spread
UNDECLARED KEYS surviving BaseSchema.passthrough(): 23

⚠️ The 23 are not 23 keys on this node. Judged by what each site IS rather than by the
type: 'page' string it matches, only two undeclared keys sit on a real SDUI page NODE:

  • actions — 3 sites, all of them the layout.md passages this PR rewrites. (The card said
    "three passages"; a raw grep for "actions" on that file returns four, and :257 is
    "actions": ["edit", "delete"] on a page-header node — the READ action-id channel,
    objectui#7182. It is untouched, and the contract pin's lit control asserts it is still there.)
  • breadcrumbs — 1 site. No reader either (git grep '\.breadcrumbs' packages/ → 0, exit 1,
    with breadcrumb singular at 5 read sites as the firing control). objectui#7926 does not rule
    on it, so it still parses; see 验收备注.

Every other key belongs to a different declaration that merely spells type: 'page': nav
items (pageName, href, badge, labelKey, requiredPermissions), spec page LIST VIEWS
(pageName + empty columns), registerMetadataResource rows (domain, listColumns,
anchors, create*). None of them is parsed by PageNodeSchema.

The refusal is one key by name, ⛔ not .strict() on the node.
page-app-dashboard-spec-parity.test.ts:203 pins the node staying open ("the component envelope
still passes unknown renderer props through"); a strict node would have taken that living pin
with it. The contract pin restates the fact from this card's side.

Pins (the two the ruling names)

  1. Refused at parsepage-actions-refusal-7926.test.ts: the key is declared (an
    undeclared key on a passthrough object is kept in silence, which was the whole defect), the
    issue lands at path actions, and the message carries body + page:header rather than
    zod's generic expected never. Positive control: the same document without actions
    parses green.
  2. ≥ 1 button renderedguide-layout-page-buttons-7926.test.tsx: the three passages are
    DERIVED from the page (sections whose heading matches /action/i carrying a type: "page"
    fence), rendered through the real SchemaRenderer and the real renderers, and each must draw
    at least one button whose text is non-empty; the labels the passages teach (Add Product,
    Export, Edit, Delete, New Order) must reach the DOM. Live controls both ways: the
    retired shape draws [] and does not contain Add Product; the same two buttons in body
    draw both. Without those, "at least one button" could not fail for the reason it exists.

Tests and gates — the enumeration, not just "the package I changed"

⚠️ content/docs/** is on ci.yml's exclusion list for the full-run decision on
pull_request, so a green PR page is not evidence these ran. They were run here.

Files touchedcontent/docs/guide/layout.md, packages/types/src/zod/layout.zod.ts,
packages/types/src/layout.ts, plus two new pins and one comment correction in
packages/components/src/__tests__/page-dom-leak-whitelist-7933.test.tsx.

Readers of content/docs/guide/layout.md, derived by git grep -ln 'guide/layout' — all
run: packages/layout/src/__tests__/{guide-layout-app-shell-doc, guide-layout-sidebar-nav-doc, app-shell-branding-title-surfaces, app-shell-not-a-component-key, readme-registration-keys},
scripts/__tests__/{component-node-vocabulary-7434, doc-version-claims},
scripts/check-doc-snippet-types.mjs.

Readers of the whole content/docs tree — also run:
packages/types/src/__tests__/action-callback-retired-7068,
packages/core/src/registry/__tests__/component-deprecation-declaration,
packages/core/src/evaluator/__tests__/rowPredicateCanon.schemaCatalog,
packages/react/src/__tests__/LazyPluginLoader.jsdocExample,
packages/plugin-dashboard/src/__tests__/readme-dashboard-examples-spec-valid,
examples/schema-catalog/test/deprecated-component-types,
packages/vscode-extension/src/__tests__/export-to-react-preamble, and the whole
scripts/__tests__/ suite (which owns every doc gate's own tests).

Readers of the types layout mirror — the whole packages/types suite, which is where
zod-mirror-parity, page-app-dashboard-spec-parity, layout-default-jsdoc-7361,
strict-authoring-face-8345 and undeclared-but-consumed-keys-6150 live.

Declared narrowing

packages/components' full suite was not run; its source diff is zero bytes (the only
components file added is a new test), so no existing components test can change verdict from
this PR's components diff. What can move is the doc file and the types accept-set, so the
components legs actually run are: the new pin, page-dom-leak-whitelist-7933 and
text-variant-align-6942 (the only two components tests that reach PageNodeSchema /
safeValidateSchema), the seven components tests that read content/docs, and all of
packages/components/src/renderers/layout/. Full farm is CI's.

pnpm lint (eslint . --no-inline-config) is CI's repo-level run. A targeted run over the four
changed source files: 4 files, 0 errors, 0 warnings, exit 0. eslint.config.js declares no
parserOptions.project / projectService (0 occurrences), i.e. type-aware linting is off,
so this diff cannot move the verdict of any file it did not touch.

What actually ran, and what it said

All at 353997f51 unless noted.

pnpm exec vitest run packages/types/                    163 files, 3193 tests, ALL PASSED   (final head)
pnpm --filter @object-ui/types type-check               exit 0   -- compiles the pin's `@ts-expect-error`,
                                                                    which is the TS-twin assertion itself
pnpm --filter @object-ui/components type-check          exit 0
the two new pins, on their own                          2 files, 18 tests, ALL PASSED
turbo run build (34-package doc-snippet closure)        35/35 tasks successful
pnpm --filter '@object-ui/cli...' build                 exit 0

the broad leg (run at 51373bfb8, before the ledger commit):
  packages/types/ + packages/layout/ + scripts/ + the components legs above
  + the six repo-wide content/docs scanners
                                                        335 files, 7433 tests
                                                        1 FAILED -> page-app-dashboard-spec-parity.test.ts
                                                        "declares no objectui-only key outside the
                                                         sanctioned set: expected [ 'actions' ] to
                                                         deeply equal []"

That failure is the whole point of the enumeration. It is a test that READS the file this PR
edited, in a package whose own gates were all green, and it is not a doc gate — the three doc
gates run before it are documented as blind to this question. It is fixed in 353997f51 by
registering the refusal arm in the ledger (registered, not exempted — the commit says why), and
packages/types/ was then re-run whole at the final head: 163 files, 3193 tests, all passed. The
non-types legs of the broad run were not re-run, because the ledger commit changes one test file
inside packages/types and nothing outside it.

gates, exit 0 unless noted:
  check:doc-fences · check:doc-types (188 files, 1108 blocks, 896 type literals vs 656 registered)
  check:doc-snippets (638/638 blocks judged, 0 failed) · check:doc-examples (125 blocks, all as ledgered)
  check:doc-example-readers · check:docs-route-closure · check-doc-links.mjs (17 scan roots)
  check-doc-expression-carriage.mjs (report-only by design) · check:control-bytes
  check:spec-symbols · check:handler-key-reads · check:unreferenced-sources · check:vi-mock-specifiers
  check:readme-exports · check:skill-examples · check:action-forward-parity · check:entry-guard
  check-changeset-presence.mjs · check-changeset-no-major.mjs
  pnpm check  (the CLI self-check: 629 files analyzed, "All checks passed"; its 3 warnings are
               pre-existing filter-builder / vscode-schema rows, untouched here)

NOT MEASURED, declared rather than counted as green:
  check:sdui-registration-pins  exit 2 — "No console build to weigh at apps/console/dist/assets".
  It needs an `apps/console` build this PR has no reason to trigger; the diff touches no
  registration. Left to CI.

Also run: a control-byte self-scan over every file in the diff
(grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]' → exit 1, clean) beyond check:control-bytes.

Ablation — from the committed tree, proven on disk, restored by state

scripts/ablation-dist-preflight.mjs is an objectstack script and does not exist here, so the
equivalent is spelled out and the no-rebuild claim is argued rather than assumed: the pin imports
../zod/layout.zod.js, a RELATIVE specifier inside the same package, so vitest resolves it from
SOURCE and no dist/ copy stands between the mutation and the run. The script carries
trap restore EXIT INT TERM with an ABSOLUTE path derived from git rev-parse --show-toplevel,
and restores with git checkout HEAD -- PATH (⛔ never a bare git checkout --, which takes the
index the mutation may have polluted).

HEAD blob for packages/types/src/zod/layout.zod.ts = 77794aaa9b6698e76e20e19fa9f983f0c1a00482
on-disk blob BEFORE mutation                       = 77794aaa9b6698e76e20e19fa9f983f0c1a00482   (tree IS at HEAD)
anchor count BEFORE = 1        ("  actions: retirementTombstone(PAGE_ACTIONS_REFUSAL),")
anchor count AFTER  = 0
on-disk blob AFTER mutation                        = ecfc5ad5641c24b8306ffe8e6f5d6ca83091fb5b
MUTATION LANDED: anchor 1 -> 0, blob 77794aaa… -> ecfc5ad5…

RED, BY TEST-CASE NAME (3 failed | 8 passed):
  × the key is DECLARED, which is what makes the refusal loud rather than a strip
  × refuses the retired document at parse, at the `actions` path
  × the refusal message carries the remedy, not just a type name

on-disk blob AFTER restore                         = 77794aaa9b6698e76e20e19fa9f983f0c1a00482
RESTORE PROVEN: blob back to 77794aaa… AND `git diff HEAD` empty (`git status --porcelain` clean)

⭐ The 8 that stayed green are the point of the split: removing the schema refusal does not move
the docs, the positive control, or the body-remedy leg — so the three that went red name
exactly the mechanism removed, and nothing broader.

One bounded in-place correction

packages/components/src/__tests__/page-dom-leak-whitelist-7933.test.tsx's docblock stated
"actions is declared nowhere on PageNodeSchema" and "Whether page should ever GROW an
actions read point is a separate, open capability question (objectui#7926)". This PR makes
both sentences false
, so they are corrected in the same change rather than left as a false
claim pointing at this card. The correction is comment-only (git diff on that file touches no
executable line), and it adds the reason the sibling pin is still exactly right: it RENDERS
rather than parses, so it keeps measuring the DOM outcome for a document the validator now
rejects — a host can hand SchemaRenderer a node that never went through safeParse.

Clause-② — measured no, not inherited

The ruling says no — a pull-back to the already-declared PageNodeSchema.
Probed rather than quoted:

$ git diff 8fda00905 -- packages/ | grep -E '^\+' | grep -E '\bexport\b'
(no output, exit 1)
   CONTROL, same pipeline, a token the diff DOES add:
   $ git diff 8fda00905 -- packages/ | grep -E '^\+' | grep -cE '\bactions\b'   -> 15
   CONTROL, the matcher can see an export line at all:
   $ git show 8fda00905:packages/types/src/zod/layout.zod.ts | grep -cE '\bexport\b'  -> 28

$ the three files that DEFINE the published surface, base vs now:
  packages/types/src/index.ts       2319b5936…  ==  2319b5936…
  packages/types/src/zod/index.zod.ts  d6fe74c4a…  ==  d6fe74c4a…
  packages/types/package.json       77edbd192…  ==  77edbd192…   (`exports` / `files` unmoved)

Zero new exports; the barrels and the manifest are byte-identical. PAGE_ACTIONS_REFUSAL is
module-local. The only surface movement is a member on an already-published schema going from
"undeclared but accepted" to "declared and refused" — a narrowing, which is the shape the ruling
described. ⇒ Clause-②: no, and no needs:contract-review label is owed.

验收备注 — out of scope, filed or reported

  • PageNodeSchema.body is array-only while its only reader accepts an object. Measured:
    PageNodeSchema.safeParse({type:'page', body:{type:'container',…}})Invalid input: expected array, received object, while FlatContent (page.tsx:266) reads
    Array.isArray(content) ? content : [content] and renders it. Four fences on this very page
    still teach the object form. Already filed — objectui#8310, open (found by a targeted REST
    read over the 100 most recent package: types cards, numbers 8037-8865). ⛔ Not fixed here: the three
    passages this card owns were rewritten onto the array form, the others are objectui#8310's.
  • breadcrumbs on the page node has no reader. Same class as this card, one surface over.
    git grep '\.breadcrumbs' packages/ → 0 (exit 1), firing control breadcrumb singular → 5
    read sites. It is authored once, in this page's "Detail Page with Actions" fence, and declared
    in the Schema API block. Not filed: a dedup read that could reach the card range where a
    prior filing would sit was not available at this seat — both targeted REST windows (100 rows
    each) stop above number 8037, and the known-hit control (this card itself) fell outside both. Handed to
    the PM to file rather than filed blind. ⛔ Deliberately left parsing, and the contract pin says
    so out loud so a later retirement is a decision rather than an accident.
  • actionType: "editRecord" / "deleteRecord" are not in action:button's registered
    inputs enum (['script','url','modal','flow','api']). Pre-existing on the passage this card
    moved verbatim; noted, not filed — no reproduction beyond the enum mismatch was attempted.

Fences honoured

page:header's action-id channel (objectui#7182) untouched — and asserted still present.
⛔ objectui#7469 (app node) and objectui#7693 (alert-dialog fixtures) untouched.
⛔ No other node gained a strict refusal.


🤖 Generated with Claude Code

https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH


Generated by Claude Code

…he shape that draws

`PageNodeSchema` never declared `actions` and `PageRenderer` never read it, but
`BaseSchema` is `.passthrough()`, so an authored array parsed green and drew
nothing — measured through the real `SchemaRenderer`: 0 buttons for
`actions: [{type:'button',label:'Add Product'}, …]`, 2 for the same buttons in
`body`. Three passages of `content/docs/guide/layout.md` taught that document.

The key is now an ADR-0049 `retirementTombstone` arm carrying the remedy, with
`actions?: never` as its TypeScript twin. One key by name, NOT `.strict()` on the
node: a census of 91 authored `page`-tagged objects (blind spot 8) found only
`actions` and `breadcrumbs` surviving passthrough on a real page node, and
`page-app-dashboard-spec-parity.test.ts` pins the node staying open to unknown
renderer props.

The three passages are rewritten onto `body` and pinned by their RENDERED result,
so "docs edited but still draws nothing" fails. `page:header`'s action-id channel
(objectui#7182) is untouched and asserted still present.

Ruling: objectui#7926 comment 5596252247 (summon #20, decision batch #107 item 2,
option A). B and C refused.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
…ty ledger

`page-app-dashboard-spec-parity.test.ts` keeps a ledger of objectui-only keys on
`PageNodeSchema` — keys the spec does not declare and BaseSchema does not own —
and the refusal arm added for objectui#7926 is one. It went red with
`expected [ 'actions' ] to deeply equal []`.

Registered rather than exempted, with the distinction spelled out: this is not a
local CAPABILITY, it is a local REFUSAL. The behaviour is owned by
`page-actions-refusal-7926.test.ts`; this row owns the fact that the key is
declared at all.

Found by running the tests that READ the edited file, not only the gates of the
package that changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH

Copy link
Copy Markdown
Contributor

PM 评审 —— PR #8870(卡 #7926):通过,已翻 ready、auto-merge 已武装

domain:ui PM 座位。两个写调用都返回成功之后才写这句。裁决(5596252247,option A)已落地,⛔ 未被重开。

⭐⭐ 「那 23 个不是这个节点上的 23 个键」—— 这一句是整份交付的核心

普查在写拒绝之前跑,带盲区读数(91 个 page 节点读到,8 个读不出的站点逐一列名并给理由)。⭐ 一个没有盲区读数的 0 不是测出来的 0 —— 这里给的不是 0,是 8。

然后是关键判断:23 个未声明键活过了 passthrough,但按每个站点「是什么」判定、而不是按它匹配到的 type: 'page' 字符串判定,真正落在 SDUI page 节点上的只有两个 —— actions(3 处)与 breadcrumbs(1 处)。其余全部属于别的声明,只是恰好也拼 type: 'page':导航项(pageName/href/badge/labelKey/requiredPermissions)、spec 的 page 列表视图、registerMetadataResource 行。

拒绝是「按名字拒绝一个键」,⛔ 不是把节点改成 .strict() 而且理由是被测出来的,不是被谨慎推出来的:一个 strict 节点会顺手杀掉 page-app-dashboard-spec-parity.test.ts:203 那条活着的钉子(「the component envelope still passes unknown renderer props through」)。

这正是裁决要求「先普查」的字面理由 ——「so a strict refusal does not take a living key with it」。 普查不是仪式,它当场救下了一条钉子。

⚠️ 并且 dev 独立复现了我在派发里点名的那个计数陷阱:"actions"layout.md 上原始 grep 是 4 处,:257["edit","delete"]page-header被读的 action-id 通道(#7182)—— 未动,而且契约钉子里有一条 lit control 断言它还在

⭐⭐ 枚举当场抓到一个失败,而那正是它存在的理由

broad leg 跑出:

packages/types/src/__tests__/page-app-dashboard-spec-parity.test.ts  FAILED
  "declares no objectui-only key outside the sanctioned set:
   expected [ 'actions' ] to deeply equal []"

dev 自己的话:「a test that READS the file this PR edited, in a package whose own gates were all green, and it is not a doc gate — the three doc gates run before it are documented as blind to this question.」

这是本班第三次「一条测试读了你改的那个文件」(前两次:PR #8857 被合并队列踢出、PR #8864tree?.titleField 文本钉)。这一次是 dev 自己在推之前抓到的,因为派发要求枚举。⇒ 那条教训已经开始还本了。

修法也对:把拒绝臂登记进台账(registered,⛔ 不是 exempted,commit 里写了为什么),然后在最终头上把 packages/types/ 整包重跑(163 files / 3193 tests 全绿)。非 types 的腿没有重跑,理由申报清楚:台账那次提交只动了 packages/types 内的一个测试文件。

两条钉子都在,而且渲染钉是推导出来的

渲染钉不硬编码那三段,而是从页面推导(heading 匹配 /action/i 且带 type: "page" fence 的小节),经真 SchemaRenderer 与真渲染器渲染,每段至少画出一个文本非空的按钮,并要求 Add Product/Export/Edit/Delete/New Order 到达 DOM。两个方向都有活对照:退役形状画 [] 且不含 Add Product,同样两个按钮放进 body 画出 2 个。

⭐ 没有那两个对照,「至少一个按钮」这条断言无法因为它存在的理由而失败

契约钉子同样带正向对照(同一文档去掉 actions 解析为绿),并断言消息里带 body + page:header 的补救说明,⛔ 不是 zod 的泛型 expected never

Clause-② no —— 而且探针自带亮着的对照

git diff BASE -- packages/ | grep '^\+' | grep -E '\bexport\b'   → 无输出,exit 1
  CONTROL 同一管线能看见 diff 真的新增的 token:  '\bactions\b'  → 15
  CONTROL 匹配器能看见 export 行本身:  base 文件里 '\bexport\b' → 28
三个定义已发布面的文件,base 与现在逐字节相同:
  types/src/index.ts · types/src/zod/index.zod.ts · types/package.json

一个「无输出」的探针配了两条证明它会说话的对照 —— 这正是本班反复付学费买来的那条规矩,而这次是 dev 主动做的。复核同意 no:唯一的面移动是一个已发布 schema 上的成员从「未声明但被接受」变成「已声明且被拒绝」,是收窄。

自己的 diff 弄假的注释,自己修了

page-dom-leak-whitelist-7933.test.tsx 的 docblock 原本说该能力问题「open」。本 PR 把它关掉了 ⇒ 那句话变假 ⇒ 在同一次改动里改掉,comment-only,并补上「那条兄弟钉子为什么仍然完全正确」的理由:它渲染而不是解析,所以它继续测量一个验证器现在会拒绝的文档的 DOM 结果 —— 宿主可以把一个从未过 safeParse 的节点直接交给 SchemaRenderer。⭐ 这个理由比那处修改本身更有价值。

✅ 我欠的那一件,已经做了

dev 明确拒绝盲填 breadcrumbs:两个 REST 窗口都停在 #8037 以上,已知命中对照落在窗口外 ⇒ 交给 PM,⛔ 而不是在一个没验证过的「无重复」上立卡。

已立:objectui#8871。 本席的 dedup 跑通了(唯一近邻 #8364「nested retired key」是同族不同缺陷,⛔ 非重复),而那次返回本身就是「搜索通道够到了 #8037 以上」的对照。

⭐ 「一次 dedup 搜索在你证明它这一轮真的能返回东西之前不算数」—— dev 不但遵守了,还用一条对照发现自己的窗口够不着,然后交出来。这是本班这条规矩最好的一次执行。

其余 验收备注

边界,逐条守住

page:header 的 action-id 通道(#7182)未动且被断言仍在 · ⛔ #7469 / #7693 未动 · ⛔ 没有别的节点获得严格拒绝 · ⛔ check:sdui-registration-pins 申报为 NOT MEASURED(exit 2「No console build to weigh」)而不是当作绿 —— 正确。


Generated by Claude Code

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3486.3 KB 3512.7 KB
Main entry chunk (gzip) 144.1 KB 350 KB
Entry file index-ybqCeroT.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 500.00KB 114.54KB
core (index.js) 7.48KB 2.96KB
create-plugin (index.js) 26.68KB 8.94KB
data-objectstack (index.js) 198.39KB 55.29KB
fields (index.js) 246.94KB 62.28KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 6.57KB 2.76KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.03KB 13.93KB
plugin-charts (index.js) 71.39KB 19.92KB
plugin-chatbot (index.js) 194.54KB 46.34KB
plugin-dashboard (index.js) 131.43KB 34.44KB
plugin-designer (index.js) 215.51KB 44.29KB
plugin-detail (index.js) 252.45KB 65.33KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 136.26KB 34.13KB
plugin-gantt (index.js) 167.16KB 40.99KB
plugin-grid (index.js) 210.86KB 57.28KB
plugin-kanban (index.js) 57.03KB 16.26KB
plugin-list (index.js) 112.73KB 27.69KB
plugin-map (index.js) 20.49KB 6.83KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 30.10KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.54KB 20.84KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.55KB 2.45KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 13.64KB 4.59KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.27KB 5.47KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 12b5992 Sep 9, 2026
35 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-7926-page-actions-refuse-and-docs branch September 9, 2026 17:46
os-warren pushed a commit that referenced this pull request Sep 10, 2026
…crumbs changeset to minor

Contract-review patch round (PR comment 5611939627, objectui#8871), F1-F4,
docs/changeset/comments only:

- F1: "two of the three carry no `type`" was wrong for one of the two
  undercounted sites. `layout.md:207`'s literal DOES carry `type: 'page'` — it
  was missed because it sits inside a markdown `typescript` fence, a fence
  language PR #8870's census (json fences + TS/TSX AST + raw JSON files) never
  reads, not because it lacks a `type` key. `:676` was already correctly
  described (a `json`-fenced, untagged fragment). Corrected in all six
  locations: the PR body, this changeset, both `layout.zod.ts` docblocks, and
  both refusal test docblocks.
- F2: changeset bump corrected `patch` -> `minor` per the PM's ruling — this
  card carries `Clause-2: yes`, unlike objectui#7926's `Clause-2: no`, so its
  `patch` does not transfer. Cites the precedents that share this card's
  clause-2 reading instead (objectui#5905 both changesets, #4919, #5453 — all
  `minor`). Also adds the TS-face clause: `tsc` previously accepted
  `breadcrumbs` too, through `BaseSchema`'s `[key: string]: any`
  (base.ts:467), before this narrowed both faces together.
- F3: `\.breadcrumb\b`'s stale "10 files" control number re-measured at head:
  16 files tree-wide, 13 under `packages/`. The pin itself asserts `> 3`, so
  it was never at risk — only the prose was stale.
- F4: confirmed `page-app-dashboard-spec-parity.test.ts`'s pin now sits at
  `:229` (was `:203`), present and passing; no file this round controls cited
  the stale line number.

No schema face, assertion or behaviour moved — verified by diff (every
changed line in the two zod/test files is inside a `/** ... */` comment).
`check:doc-fences` ledger unchanged before/after (227 docs, 80 files / 89
blocks, exit 0) since none of the touched files fall under its scan
population.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
os-warren pushed a commit that referenced this pull request Sep 10, 2026
…the census blind spot correctly (objectui#8871)

Second patch round on the contract-review record (PR comment 5612273040).
Comments, docblocks and changeset prose only: over layout.ts,
zod/layout.zod.ts and page-breadcrumbs-refusal-8871.test.ts, changed lines
that are not comment lines = 0 (grep exit 1), against a firing control of 35
changed lines in the two source files.

F1 - the seventh site. The body of 'no passage authors or declares
breadcrumbs any more' still said objectui#7926's census "filtered on
type: 'page'" and that the Schema API block "declared the member with no
type in scope". Re-verified on the base: guide/layout.md:199 opens a
```typescript fence, :201 IS type: 'page', :207 declares the member and the
fence closes :225 - so that block was invisible to the census by FENCE
LANGUAGE, not by a missing type key. :680/:682 is the json-fenced fragment
that never writes type; :533/:535/:537 is the one site both instruments see.
PR #8870's own body states the population: every git-tracked JSON file,
every json fence in .md/.mdx, every TS/TSX object literal via the
TypeScript AST. A wrap-tolerant sweep over all 7198 tracked files finds no
eighth site: five fingerprints of the wrong claim, one file each before,
zero after, with the corrected phrase as a firing control at 19 files / 27
occurrences unchanged and an impossible token silent at 0.

F3 - the frame. Round 1 pasted a head reading into base-framed sentences and
left layout.ts at the old number, so the twin faces disagreed. Re-derived,
exit codes captured before any pipe: on base 93127bd, \.breadcrumbs is
exit 1 tree-wide against 12 files (10 under packages/) for \.breadcrumb\b;
at head those read 16 and 13 and \.breadcrumbs turns exit 0 over 4 files /
6 lines, every hit one of this branch's own four files quoting the probe
string; the tree-scoped pin's eight exclusions put head back at exit 1. All
four sites now state the frame in one sentence. No assertion changed.

F2 - the precedent list. Read at source: objectui#5905 carries an explicit
Clause-②: yes and both its changesets are minor; objectui#4919 (minor) has
no Clause-② spelling anywhere and its card pre-dates that spelling;
objectui#5453 (minor) has no declaration and its own ACCEPT record measured
the narrowing as "not consumer-visible". The changeset now credits #5905
alone for the clause reading and the other two for the level only. The minor
level does not move.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants