fix(types): drop stale source-line citations from 6 published describe() strings (complex.zod.ts) - #8835
Merged
Merged
Conversation
…ribe() strings Remove the `NAME.ext:NNN` address from all 6 published .describe() strings in packages/types/src/zod/complex.zod.ts (#8478) -- the final file of this card's remainder. Per-address editorial disposition, not a uniform treatment: - FilterBuilderSchema.wrapperClass, CarouselSchema.itemClassName, and ChatMessageSchema.avatar / avatarFallback: the cited renderer expression only restated what the prose already says in English, so it moves into a maintainer-facing `//` comment beside the schema (matching this file's own convention of file:line references in maintainer JSDoc) and the published description keeps the author-relevant sentence without the address. - CarouselSchema.opts and CarouselSchema.orientation: the cited expression reveals a real default/policy an author needs (orientation falls back to 'horizontal'; opts is deliberately left open, unnarrowed), so the prose stands on its own with the address dropped and the rest kept. Text only: no accept-set, key, or shape change (Clause-2: no). All 6 addresses were spot-checked against the files they cite and are byte-accurate today -- no drift found, unlike the two prior slices on this card. Refs #8478 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
Refs #8478 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8478
What
Removes the stale
NAME.ext:NNNsource-line address from all 6 published.describe()strings inpackages/types/src/zod/complex.zod.ts— the last file of this card's remainder. Per the triage ruling on #8478, address removal itself is certain; the remaining prose is decided per-address, not forced to one disposition.Disposition split for this slice (not forced to one bucket)
Address dropped, prose kept as-is (2) — the cited expression reveals a real default/policy an author needs, so it stays inline:
CarouselSchema.opts— "left OPEN on purpose" / forwarded verbatim, still the file's own reasoning, just without the file:lineCarouselSchema.orientation— keeps the'horizontal'fallback, an author-relevant defaultAddress + literal expression relocated to a maintainer
//comment beside the schema (4) — the cited renderer expression only restated what the author-facing sentence already says, so it moves out of the published surface and into a maintainer-facing comment (matching this file's own convention of exactfile:linereferences in maintainer JSDoc elsewhere in this file, e.g.custom/filter-builder.tsx:1060a few hundred lines up):FilterBuilderSchema.wrapperClassCarouselSchema.itemClassNameChatMessageSchema.avatarChatMessageSchema.avatarFallbackZero needed a full sentence deletion (disposition (b)) — none of the six were "meaningless without the address"; all six describe real behavior beyond the citation.
Text only: no accept-set, key, or shape change. Clause-②: no.
Re-derived count (call-scoped matcher, on my own head)
Matcher: for every
.describe(call inpackages/types/src, extract its argument text up to the matching close-paren (so a continuation-line address is not missed), and count the call if that argument contains aNAME.ext:NNNtoken.On my branch base (
b226d1b20, before this slice's edit):complex.zod.ts= 6 — matches the card's own figure, triage's independent recount, and slice 1's dev's count exactly (all three call-scoped). The PM's own single-line-scoped re-measurement read 3, which the claim comment itself flagged as an undercount for continuation-line addresses — confirmed here: this file's addresses sit on continuation lines the single-line matcher misses.Firing controls, both measured:
.describe()calls) in all ofpackages/types/src, at branch base: 162 — large non-zero, confirms the matcher isn't broken.form.zod.ts(out of scope for this diff, untouched by my commit): 9 before my edit, 9 after — unchanged and non-zero, confirming thecomplex.zod.ts6→0 is a removal, not a dead grep.FixesvsRefs— decided from measurement, not transcribedThis slice's claim comment predicted
Fixes, "because this slice takes the last file" — but PR #8822 (the sibling slice coveringform.zod.ts/layout.zod.ts) was still in the merge queue, not yet merged, when I branched. Re-deriving on my own head at that point still showed 11 addresses live inpackages/types/src/zod/**outside this PR's file, which would have forcedRefs.PR #8822 merged mid-round (
ecfb69322, at 2026-09-09T12:52:14Z) while this slice was in flight. I re-fetchedorigin/main, merged it into this branch (clean, no conflicts), and re-ran the full sweep on the merged head:Zero population left anywhere in the card's file surface ⇒
Fixesis correct now, confirmed on this branch's own head, not transcribed from the claim comment's prediction. Firing control on the merged head: the same matcher over every string literal inpackages/types/srcstill returns 147 (non-zero) — the zero is a real census result, not an all-zero tree with no control left to check against.Spot-check — all 6 addresses in this file are accurate, unlike the prior two slices
Checked all 6 against the files they cite (a full census of this file's population, not a 3–5 sample):
FilterBuilderSchema.wrapperClassfilter-builder.tsx:37:37—<div className={schema.wrapperClass || ''}>CarouselSchema.optscarousel.tsx:23:23—opts={schema.opts}CarouselSchema.orientationcarousel.tsx:24:24—orientation={schema.orientation || 'horizontal'}CarouselSchema.itemClassNamecarousel.tsx:30:30—className={schema.itemClassName}onCarouselItemChatMessageSchema.avatarplugin-chatbot/src/index.tsx:173–174:172-174—message.avatar || userAvatarUrl/|| assistantAvatarUrlChatMessageSchema.avatarFallbackplugin-chatbot/src/index.tsx:177–178:176-178—message.avatarFallback || userAvatarFallback/|| assistantAvatarFallbackNo drift found in this file — all 6 addresses were byte-accurate at measurement time, in contrast to the two prior slices on this card, which together found 3 confirmed drifts (
ObjectKanban.tsx:264→:365,checkbox.tsx:45/:49→:48/:52,text.tsx:162,167→:165/:170) plus one borderline near-miss. Reporting this reading per the triage seat's ask; not grading it — the p3→p2 re-grade trigger has already fired three times on this card (5601493165) and this reading doesn't add a fourth instance, it's a clean result.UNGATED_EXAMPLES/ line-shift ledger hazard — checked, does not applycomplex.zod.tshas no@exampleblock at all (grep -c "@example"= 0), so the ledger keyed bypath:line symbolinscripts/check-doc-example-types.mjshas no row that could key off this file — confirmed by grepping the script'sUNGATED_EXAMPLEStable forcomplex.zod.ts: no hits.git diff --numstatis 10 insertions / 10 deletions — exactly equal, zero net line shift — so even a hypothetical row elsewhere in the file would not have been affected.pnpm check:doc-examplesitself: it requires a fullturbo buildacross ~26 packages first (theirdist/*.d.tsaren't on disk in a fresh worktree) — that full-farm build belongs to CI, not this package-scoped local gate pass; the two checks above cover the hazard this specific edit could trigger.apps/consolesweepIncluded per the standing constraint.
apps/consolehas zero.describe()-with-address hits (it isn't a Zod schema file), and agrepfor the four edited schema names (FilterBuilderSchema,CarouselSchema,ChatMessageSchema,KanbanSchema) inapps/console/srcfound no direct references — nothing there consumes the edited description text.Changeset
.changeset/8478-zod-pins-complex.md—@object-ui/typespatch, matching both prior slices' precedent for this card.Gates (all green, on the final merged head)
pnpm exec vitest run packages/types/— 160 files / 3145 tests passedpnpm --filter @object-ui/types build— dist completeness OKpnpm --filter @object-ui/types type-check—tsc --noEmit+ examples + test configs, 0 errorspnpm --filter @object-ui/types lint— 0 errors (271 pre-existingno-explicit-anywarnings, unrelated to this diff — identical count to the prior slice)node scripts/check-changeset-presence.mjs— declares the changesetnode scripts/check-changeset-no-major.mjsnode scripts/check-changeset-fixed.mjsnode scripts/check-control-bytes.mjs— 7030 tracked text files scannednode scripts/check-spec-symbol-derivation.mjsnode scripts/check-designer-field-key-parity.mjsnode scripts/check-handler-key-read-sites.mjsnode scripts/check-governed-queue-guard.mjs --test packages/types/src/zod/complex.zod.ts .changeset/8478-zod-pins-complex.md— NOT GOVERNEDNot enqueued, not merged — draft, per this dispatch's explicit instruction.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
Generated by Claude Code