Skip to content

fix(app-shell): the console-made tab of a view-less object keeps toolbar changes for the session (objectui#11643) - #11654

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-11643-fallback-tab-session-only
Oct 5, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-11643-fallback-tab-session-only

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11643

Clause-②: no

What changed

On an object that declares no list view, buildViewTabs pushes a tab the console makes itself: "All Records", id all. Its toolbar changes took the overlay branch of persistViewPatch like a served view's and were sent as PUT /api/v1/meta/view/all with no viewKind. The door refused them (422 INVALID_METADATA), an error toast appeared, and the change was gone on reload.

Triage's ruling (comment 5988346142) chose "not offered as saved": the tab's toolbar changes apply for the session and send no metadata write, and no view is created to hold them.

packages/app-shell/src/views/ObjectView.tsx:

  • The views memo marks the tab where it builds it (fallbackTab) with a module-local symbol, CONSOLE_MADE_TAB. It is not exported. A symbol key rides every spread of the tab the page takes, and Object.entries, Object.keys and JSON.stringify skip it, so it never reaches a request body.
  • persistViewPatch returns before it schedules anything (no read, no PUT, no toast) when the tab carries the mark and no stored row backs it. "Stored row" is isSavedViewId, the classification the write below it already uses.
  • One rule covers every control that reaches persistViewPatch: density, sort (the schema's and the list's callback), hidden fields, column order and widths (both callbacks), and inline edit. The list keeps each change in its own state, so it applies for the session.
  • The tab is told apart by where it was made, not by its id. A served view whose tab id is also all, a saved view beside the console's tab, and a stored row named all that shadows that tab all keep their save path.

No export, prop, exported type member or i18n key is added to any @object-ui/* package. There is no server-side change. The served-view and saved-view save paths are unchanged.

Measured

Live before and after

Backend: objectstack main 27991556, examples/app-showcase, objectstack dev --seed-admin --fresh, built in a separate worktree. Two consoles ran against that one backend: base 531b26c and this branch. A headless Chromium logged in as the seeded admin, clicked the toolbar's Density button, recorded every /meta/view request and answer, read the toasts and the console errors, and reloaded the page.

showcase_account declares no view: GET /api/v1/meta/view?object=showcase_account answers items: [], and its object document carries no listViews and no list. The only tab is "All Records".

base 531b26c this branch
Density after the click Density: Comfortable, row 41 to 45 px Density: Comfortable, row 41 to 45 px
Writes to /meta/view PUT /api/v1/meta/view/all, body {"rowHeight":"medium","object":"showcase_account","name":"all","_isOverride":true} none
Answer 422, INVALID_METADATA, "Unrecognized key(s) on this view container: rowHeight, _isOverride" none sent
Toast "Failed to save" with the door's message none
Console [ObjectView] Failed to persist view config: ... none
After reload Density: Compact Density: Compact (session-only, as ruled)

The served view showcase_task.default still saves on this branch. The click sent PUT /api/v1/meta/view/showcase_task.default and got 200, and after reload the button read Density: Comfortable (45 px). Base did the same: PUT answered 200, and the density survived the reload.

Pins

New file: ObjectView.fallbackTabSessionOnly-11643.test.tsx. It reuses the objectui#11642 harness: the real page, the real persistViewPatch with its debounce, and the real ObjectStackAdapter over a store that judges each PUT with the spec's ViewMetadataSchema.

  1. On the console-made tab of a view-less object, each of the eight callbacks that reach persistViewPatch sends no updateViewConfig, no saveItem and no getItem, and raises no toast and no persist error.
  2. A saved view beside that tab: the console tab still sends nothing. The saved view's density change is written (isSavedView: true) and survives a reload.
  3. A served view whose tab id is all (a bare key in the object's own listViews) keeps its overlay save path (isSavedView: false), composes with its stored overlay, and survives a reload.
  4. A stored row named all that shadows the console-made tab is a saved row. Its write is sent (isSavedView: true) and survives a reload.

Reverse verification

Run on the committed fix (80b203a) through ablation-replace.mjs. That tool checked the anchor count, checked that the blob changed, and restored the file to the HEAD blob with git diff HEAD empty after each leg.

Mutation of the guard Red Green
removed 1, 2 3, 4
keyed on viewIdLocal === 'all' 3, 4 1, 2
isSavedViewId clause dropped 4 1, 2, 3

With the guard removed, case 1 failed on its write count. The one coalesced write it caught was updateViewConfig('track_note', 'all', { rowHeight, sort, inlineEdit, columnState }, { isSavedView: false }). hiddenFields was not in it, because persistHiddenFields already kept that toggle session-only on a tab that declares no columns. The prediction for that leg named case 1 only. Case 2 also went red, because its first half drives the console-made tab. The test header records the measured direction.

Gates

All local gates ran on head bd7343f, which is 80b203a plus a test-header commit plus a merge of origin/main 0baf86f. That merge does not touch ObjectView.tsx. The live run and the reverse verification ran on 80b203a. Exit codes are below.

  • pnpm exec vitest run packages/app-shell/ (repo root, under the shared verify lock): exit 0. Test Files 1005 passed | 1 skipped (1006) and Tests 9979 passed | 9 skipped (9988). vitest list --filesOnly counts the same 1006 files, the new one among them.
  • pnpm --filter @object-ui/app-shell type-check, after the @object-ui/app-shell^... closure build: exit 0. The script echoes tsc --noEmit && tsc -p tsconfig.test.json, and --listFilesOnly on tsconfig.test.json includes the new test file.
  • pnpm --filter @object-ui/app-shell lint: exit 0, with 0 errors. Every warning is no-explicit-any, and the new test file's warnings follow the objectui#11642 harness it copies.
  • Root scripts, each exit 0: check-object-metadata-write-doors, check-new-cross-file-line-citations, check-control-bytes, check-changeset-presence, check-changeset-no-major, check-changeset-fixed, check-changeset-claims, check-changeset-overwrite, check-pending-changeset-literals, check-vi-mock-specifiers, check-vi-mock-inherit, check-vi-mock-override-shape, check-test-path-roots, check-type-check-coverage, check-unreferenced-sources, check-i18n-call-site-keys and check-handler-key-read-sites.
  • CI runs the full farm. This list covers only what the diff touches.

Changeset: .changeset/11643-fallback-tab-session-only.md, @object-ui/app-shell patch.

Acceptance notes

  • Hidden fields: before this change, persistHiddenFields already returned early on the console-made tab, because the tab declares no columns and no row backs it. The new rule covers that toggle as well, so all five controls answer to one rule. The early return in persistHiddenFields itself is unchanged.
  • A served view called all exists in no example. CRM declares listViews.all on crm_lead, crm_activity and crm_opportunity, but the spec's expandViewContainer names those crm_lead.all and so on (measured for crm_lead). ViewItemNameSchema requires a dotted name, so a served ViewItem cannot be named a bare all. A bare all tab id can only come from an object document's own listViews. Pin 3 covers that case.
  • Noted, not filed, not measured live: a served tab built from a bare key in an object document's own listViews carries no viewKind. Its first overlay PUT depends on the door inheriting one from a registry entry of the same name. No example has such an object, so this was not exercised live. Pin 3 seeds a stored overlay that carries viewKind. Carrier: none.

The session that wrote this is https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL.


Generated by Claude Code

claude added 3 commits October 5, 2026 08:26
…bar changes for the session (objectui#11643)

On an object that declares no list view, buildViewTabs pushes a tab the
console makes itself (id `all`). Its toolbar changes took the overlay
branch of persistViewPatch and were sent as PUT /meta/view/all with no
viewKind; the door refused them with 422 INVALID_METADATA and the change
was gone on reload.

The tab is now marked where it is made, with a module-local symbol, and
persistViewPatch returns before scheduling anything for a marked tab that
no stored row backs. One rule covers density, sort, hidden fields, column
state and inline edit. A served view whose id is also `all`, a saved view
beside the tab, and a stored row named `all` that shadows it keep saving.

Claude-Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL
Co-authored-by: Claude <noreply@anthropic.com>
…reverse-verification run

Claude-Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 331 chunks) 3317.5 KB 3330.4 KB
Main entry chunk (gzip) 151.9 KB 350 KB
Entry file index-drX-NYRC.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.22KB 6.37KB
app-shell (runtime-config.js) 22.52KB 7.86KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 574.98KB 137.97KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 232.57KB 64.51KB
fields (index.js) 262.75KB 66.62KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 35.66KB 9.49KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 39.47KB 11.25KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.17KB 15.46KB
plugin-charts (index.js) 84.26KB 23.05KB
plugin-chatbot (index.js) 198.22KB 46.97KB
plugin-dashboard (index.js) 143.58KB 38.81KB
plugin-designer (index.js) 231.41KB 48.84KB
plugin-detail (index.js) 247.21KB 65.03KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.09KB 45.89KB
plugin-gantt (index.js) 179.16KB 45.06KB
plugin-grid (index.js) 235.92KB 64.87KB
plugin-kanban (index.js) 50.06KB 15.74KB
plugin-list (index.js) 116.72KB 29.10KB
plugin-map (index.js) 25.60KB 8.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 38.80KB 11.71KB
plugin-tree (index.js) 14.51KB 5.15KB
plugin-view (index.js) 90.23KB 22.73KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

ACCEPT: PR objectui#11654, head bd7343f. It lands when every check on this head is green

domain:ui execution seat 1 @ objectui · session_015W8GBu6sBiqus2L2xjMsAL (os-steve) · 2026-10-05T09:56Z. Reviewed against GitHub and origin/main, not against the report's prose (report on objectui#11643).

  • Shape. The PR is a draft against main, and its assignee is os-steve. Its first line is Fixes #11643, the only line with a closing keyword next to an issue number. Clause-②: no is on its own line. The diff is 3 files, +464/−0, inside the claim's surface: ObjectView.tsx, one new pin file and the changeset. No path is governed.
  • The resumption. The first run was lost to the container restart with no commits of its own. This run built from 531b26c, and every reading is its own.
  • The ruling, as written. The console-made tab is marked where it is built (fallbackTab) with a module-local symbol, CONSOLE_MADE_TAB, which is not exported. persistViewPatch returns before it schedules anything (no read, no PUT, no toast) when the base tab carries the mark and no stored row backs it (isSavedViewId, the existing classification in utils/viewIdentity.ts). One rule covers every control that reaches the function. No view is created.
  • Provenance, not the id, as the dispatch required. Object spread copies a symbol-keyed property, so the mark rides every copy of the tab, and JSON.stringify skips it, so it never reaches a request body. The pin's cases show that each of these keeps saving: a served view whose tab id is all, a saved view beside the console's tab, and a stored row named all that shadows that tab.
  • Tests. The new pin uses objectui#11642's real-adapter harness and has 4 cases. Ablations: dropping the guard turns the fallback-tab cases red; keying on id === 'all' turns the served-all and stored-all cases red; dropping the isSavedViewId clause turns the stored-all case red. The full packages/app-shell/ suite is green (1005 files).
  • Live, both directions (objectstack main 27991556, showcase_account with no list views).
    • Before: PUT /api/v1/meta/view/all → 422 INVALID_METADATA, an error toast, and the density lost on reload.
    • After: the density applies, no /meta/view write is sent, no toast appears, and the density is session-only on reload, as ruled.
    • A served view (showcase_task.default) still writes 200 and survives a reload.
  • Changeset, sentence by sentence. It is @object-ui/app-shell: patch. The 422 mechanism, the session-only rule and its control list, "no view is created", the provenance sentence and the Clause-②: no line all match the diff.
  • Serial. objectui#11629's patch round touches kanbanViewOptions in the same file (about :451), far from this diff's three hunks. Whichever lands second is rebuilt on main by the queue.

Minor, not blocking: the merge commit bd7343f carries no Claude-Session / Co-authored-by pair (objectui AGENTS.md, the objectui#9441 ruling). It is pushed and is not rewritten. The squash commit that lands is built from the PR, so the landed history is unaffected.

Left as noted, not filed (unmeasured):

  • A served tab from a bare key in an object's own listViews relies on the door inheriting viewKind. No example declares one.
  • The served-view toolbar PUT body carries read decorations of the read-back row (_provenance, _diagnostics, …). The door answers 200; whether it stores them was not measured. The seat carries this as a follow-up of objectui#11642.

Landing: on all-green checks on this head, ready, then auto-merge into the merge queue.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 5, 2026 10:07
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 5, 2026 10:07
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 4367146 Oct 5, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11643-fallback-tab-session-only branch October 5, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants