Repository navigation
fix(app-shell): a Studio list view's date sort reads Oldest → Newest - #28433
Merged
Merged
Conversation
The list-view panel hands SortBuilder each field's type, as the console list does, so a date or datetime sort row names its direction as time. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6bhgWQeuFyKF7Jtpi9YZs
Contributor
Author
|
domain:ui#4 · os-sales · session_01L6bhgWqjXeTcS3jtug46Dv 维护者速读
席位意见:ACCEPT。沿用 #28423 已发布的 席位核对 — ACCEPT · domain:ui#4 · Head-sha
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Part of #27520 (row 7, the Studio half of the date-sort label; the console half landed in #28423)
Clause-②: no
Metadata-protocol: none
Skills-docs: none
维护者速读
type一并传给排序构建器,日期/日期时间字段的排序行显示「最早 → 最新」/「最新 → 最早」,不再是「A → Z」。SortBuilder按字段类型显示时间方向,console 列表已传type;Studio 面板只传了{ value, label },同一个日期排序在 Studio 里仍写着 A → Z。ui/packages/app-shell/src/views/studio-design/ObjectListViewInspector.tsx中<SortBuilder fields=…>;新测试ObjectListViewInspector.dateSortLabel-27520.test.tsx。pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/ObjectListViewInspector.dateSortLabel-27520.test.tsx→ 2 个用例全绿。What changes
On
main5da3a8ce, the Studio list-view panel handedSortBuilderits fields as{ value: f.name, label: f.label }.SortBuilderpicks the time wording only from a field'stype, so a sort on adatefield read "A → Z" in Studio while the console list read "Oldest → Newest". The panel now passestype: f.type(the typeuseObjectFieldsalready returns). What is written to the view'ssortis unchanged.Tests
ObjectListViewInspector.dateSortLabel-27520.test.tsxmounts the realuseObjectListViewDraft, the real panel, the realuseObjectFieldsover a realMetadataClientand the realSortBuilder. Adaterow reads "Oldest → Newest", adatetimerow "Newest → Oldest"; CONTROL: a text row still reads "A → Z".main's source: the date case failed withReceived: A → Z; the control passed.scripts/ablation-replace.mjs(type: f.type→type: undefined): 1 failed / 1 passed, then restored, blob == HEAD andgit diff HEADempty.vitest run packages/app-shell/src/views/studio-design/: 281 files, 1993 tests passed.Verification
Local readings at head
b7745efc(merge oforigin/main4bc077d2).dispatch-gates --commands: 34 derived, each run with its exit code captured; all 34 exit 0.--ran: "34 derived, 34 run, 0 NOT-MEASURED, 0 UNRUN".node scripts/check-sdui-manifest.mjs: exit 0.eslinton the changed source and the new test: exit 0.pnpm --dir ui --filter @object-ui/app-shell run type-check: exit 0.ObjectListViewInspector.tsx(REST scan of open PRs' files).claude/project-thread-t38h8d, named in the claim (6544990253).Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses on the changed files.main, one pull request.packages/spectouched: n/a.Generated by Claude Code
🤖 Generated with Claude Code
https://claude.ai/code/session_01L6bhgWQeuFyKF7Jtpi9YZs