Skip to content

fix(service-automation): a connector_action evaluates a CEL envelope in connectorConfig.input - #27980

Merged
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/project-thread-6gm2er
Oct 30, 2026
Merged

objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/project-thread-6gm2er

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

Fixes #27327

What changes

  • connector-nodes.ts: the connector_action executor resolves connectorConfig.input through resolveValueSlotMap (the one per-key value-slot resolver subflow/map input, script inputs, screen defaults and notify templateData use) before dispatch, and hands the handler the result. A top-level CEL envelope is evaluated in the run's scope; every other value is handed on as a copy of what was written. Resolved before the try, so an envelope that faults fails the step with input.<key> and its source, and the handler is never called.
  • value-slot-map.ts: the docblock lists the new slot.
  • engine.ts (comment only): the evaluateValueEnvelope docblock no longer says only ledger-declared slots reach it; it names connectorConfig.input as the one undeclared slot and points to automation: registration does not judge a connector_action node's connectorConfig.input value slot, because the spec expression ledger cannot address a sibling block of config #27968.
  • New connector-input-value-slot.test.ts; changeset (@objectstack/service-automation minor).

Why

Before, the input map reached the handler as authored, so an envelope reading a record field arrived as the object { dialect: 'cel', source: '…' } and a declarative connector put [object Object] into the request. Triage ruling 6487582764: enforce through the same value-slot map, one evaluator, constant payloads unchanged.

Acceptance notes

Verification

  • Measured first: the new test is red on main (handler receives the envelope objects); the constant-payload and no-input controls pass on both.
  • Ablation (scripts/ablation-replace.mjs, call site back to cfg.input ?? {}): 3 of 4 cells red (evaluated, copied, fault); restored.
  • service-automation: 221 files / 2830 tests green after merging main (including fix(service-automation): a connector credential written through the door reaches every replica #27941); tsc --noEmit clean.
  • dispatch-gates --ran: 62 derived families, 61 run green, 1 NOT MEASURED (check:dual-build-cjs-loads, exit 3, needs a whole-tree build); pnpm lint green.

Clause-②: no
Metadata-protocol: semantic

Human Minimum

  • 1. Schemas start as Zod; packages/spec holds no runtime logic.
  • 2. Every name I added uses the casing for its kind.
  • 3. No formatter ran; pnpm lint passes.
  • 4. One issue, one branch off an up-to-date main, one pull request.
  • 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
  • 6. packages/spec touched: its generated artifacts are regenerated and committed. (not touched)
  • 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
  • 8. Title, body and comments are in English.
  • The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_016WV4czwdEVkNtLnwVK4j6Z

…g.input as a value-slot map

A CEL envelope at a top-level key of connectorConfig.input is evaluated in
the run's scope through resolveValueSlotMap, the resolver every other value
map uses; a literal is handed to the action's handler as a copy of what was
written. Before, the map reached the handler as authored, so an envelope
reading a record field arrived as the object it spells.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WV4czwdEVkNtLnwVK4j6Z
…lared slot evaluateValueEnvelope reaches

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WV4czwdEVkNtLnwVK4j6Z
@github-actions github-actions Bot added size/m documentation Improvements or additions to documentation tests tooling labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/service-automation, touching 2 documentable anchor(s). ⚠️ 1 changed file(s) yielded no anchor (packages/services/service-automation/src/builtin/value-slot-map.ts), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

⛔ 3 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx (via AutomationEngine (symbol, a top-level class))
  • content/docs/releases/v17/17-0.mdx (via AutomationEngine (symbol, a top-level class))
  • content/docs/releases/v17/17-6.mdx (via AutomationEngine (symbol, a top-level class))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/services/service-automation/src/builtin/value-slot-map.ts) — pages documenting those are invisible to this run
  • the SDK route bridge reached 58 of 210 client-bound route-ledger rows — the other 152 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 152: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 97 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 8 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 5f6dc96c396104350cfe71556ed724df5412bf54 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 36d872f8acfa4eabd6d48605548563bf91f652cd — the merge of head 1fa1f6c2e16f13db5624fb3500bab90ce52385a9 into base 5f6dc96c396104350cfe71556ed724df5412bf54, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 36d872f8acfa4eabd6d48605548563bf91f652cd && git checkout 36d872f8acfa4eabd6d48605548563bf91f652cd
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 5f6dc96c396104350cfe71556ed724df5412bf54 1fa1f6c2e16f13db5624fb3500bab90ce52385a9 && git checkout -B drift-repro 5f6dc96c396104350cfe71556ed724df5412bf54 && git merge --no-ff 1fa1f6c2e16f13db5624fb3500bab90ce52385a9

node scripts/docs-audit/affected-docs.mjs --json 5f6dc96c396104350cfe71556ed724df5412bf54

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 5f6dc96c396104350cfe71556ed724df5412bf54 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:server#3 · os-elon-musk · session_016WV4czuTWNgKR22fKv7jia

Seat ACCEPT · PR #27980 · head 1fa1f6c2e16f13db5624fb3500bab90ce52385a9 · 2026-10-30T06:29Z

维护者速读

A connector_action node's connectorConfig.input is now a value slot. A top-level CEL envelope there is evaluated in the run's scope, and the connector's handler gets the computed value with its type kept. Before, the handler got the envelope object itself, so a declarative connector sent [object Object] and the run reported success. Literal values (a nested envelope-shaped object included) reach the handler as written, now as a copy. An envelope that faults fails the step with input.<key> and its source, and nothing is sent upstream. Registration-time checking of this slot is not in this PR: it needs the spec ledger and is split to #27968.

席位核对

ACCEPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tests tooling

Projects

None yet

2 participants