docs(adr-0025): the granted permission set is REGISTERED at load and enforces nothing — §3.7 said the opposite (#17147) - #17756
Draft
hotlong wants to merge 1 commit into
Draft
Conversation
…enforces nothing — §3.7 said the opposite (#17147) §3.7's Permissions bullet carried the parenthetical "(service/hook/file/network already enforced)". It was never true of the install-time GRANTED set, and two of the four classes have no enforcement surface at all. Measured on `9bd4344e4`: • persisted consent record + re-consent on a widening upgrade — LIVE, §3.8 as written; • artifact carriage and `AppPlugin.init()` → `PluginPermissionEnforcer.registerGrantedPermissions` — LIVE (#13457); • nothing queries the registry: `enforceServiceAccess` / `enforceHookTrigger` are reachable only through `SecurePluginContext`, which has zero production construction sites, and `enforceFileRead` / `enforceFileWrite` / `enforceNetworkRequest` are called by nothing at all. The bullet now states that split, and names §3.5 step 7's per-plugin context as the materialize seam maintainer ruling `5486840233` assigns to this ADR's own install-flow design work — tracked as #17147, not built. The Status line's 2026-07-16 audit is also stale in the other direction: it says install-time consent is unimplemented, and it has since landed for PACKAGE installs. Replaced with a 2026-09-12 audit that separates the two halves — what landed (consent, carriage, registration) from what did not (no `os plugin install`, no `.osplugin` loader, no runtime path that executes a distributed plugin's code; an artifact carries `manifest_json`, never the blob). ⛔ Governed surface (Prime Directive #14): this PR stays DRAFT for maintainer merge. Split out of #17753 for exactly that reason — its code, spec, test and generated-docs half is an ordinary PR and lands on its own. Refs #17147 · #11333 · #13457 · `5486840233` Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛔ Governed surface — stays DRAFT for maintainer merge
docs/adr/**is a governed surface (Prime Directive #14). This PR is not queued, not armed for auto-merge, and is not flipped out of draft. It is split out of #17753 precisely so that PR's code / spec / test / generated-docs half can land the ordinary way.⛔ #17147 stays OPEN — this PR is not its closer either. See #17753 for why the card stays open.
The two corrections
§3.7 Permissions carried the parenthetical "(service/hook/file/network already enforced)". Measured on
9bd4344e4:AppPlugin.init()→registerGrantedPermissionsenforceServiceAccess/enforceHookTriggerreachable only viaSecurePluginContext(zero production construction sites);enforceFileRead/enforceFileWrite/enforceNetworkRequestcalled by nothing at allThe bullet now states that split and names §3.5 step 7's per-plugin context as the materialize seam ruling
5486840233assigns to this ADR's own install-flow design work — tracked as #17147, deliberately not built here.The Status line is stale in the other direction: the 2026-07-16 audit says install-time consent is unimplemented, and it has since landed for package installs. Replaced with a 2026-09-12 audit that separates what landed (consent, carriage, registration) from what did not — no
os plugin install, no.ospluginloader, and no runtime path on which a distributed plugin's code executes; an environment artifact carriessys_package_version.manifest_jsonand never the blob.Related
granted-permissions-not-enforced.pin.test.ts, which pins the measurement and goes red the day the seam lands. That pin's failure message names this note; delete the §3.7 block in the same PR.Blocked-by: #17147.🤖 Generated with Claude Code