Skip to content

test(cli): drop the cardinality from allSixManifests() and its two stale comments #16967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-project-manager merged 1 commit into from
Sep 8, 2026
Merged

test(cli): drop the cardinality from allSixManifests() and its two stale comments #16967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/cli/test/scaffold-emission-policy.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*
* The control for that reading sits in the same file as the defect:
* `SCAFFOLD_PNPM_RANGE` and `renderPnpmWorkspaceYaml()` are IMPORTED by the
* other scaffolder rather than restated, and across the same five emissions,
* other scaffolder rather than restated, and across the same emissions,
* the same window and the same authors they did not drift at all.
*
* ## What is asserted, and why no expected value is written down here
Expand Down Expand Up @@ -356,8 +356,8 @@ describe('the on-ramp emits the same policy — measured by DRIVING it', () => {
if (sandbox) rmSync(sandbox, { recursive: true, force: true });
});

/** The on-ramp's emission, beside the five the two CLI commands render. */
function allSixManifests(): Array<{ id: string; manifest: Record<string, unknown> }> {
/** Every emission the two CLI commands render, plus the on-ramp's. */
function allScaffolderManifests(): Array<{ id: string; manifest: Record<string, unknown> }> {
return [...emittedManifests(), { id: 'npx create-objectstack', manifest: emitted! }];
}

Expand All @@ -376,7 +376,7 @@ describe('the on-ramp emits the same policy — measured by DRIVING it', () => {

it('declares exactly one range per third-party dependency, across ALL THREE scaffolders', () => {
const byName = new Map<string, Map<string, string[]>>();
for (const { id, manifest } of allSixManifests()) {
for (const { id, manifest } of allScaffolderManifests()) {
for (const [name, range] of [
...thirdPartyOnly(manifest.dependencies as Record<string, unknown>),
...thirdPartyOnly(manifest.devDependencies as Record<string, unknown>),
Expand All @@ -403,7 +403,7 @@ describe('the on-ramp emits the same policy — measured by DRIVING it', () => {

it('emits the exported TypeScript and pnpm constants, not a restatement of them', () => {
const typescriptRanges = new Set(
allSixManifests().map(
allScaffolderManifests().map(
({ manifest }) =>
(manifest.devDependencies as Record<string, string> | undefined)?.typescript
?? (manifest.dependencies as Record<string, string> | undefined)?.typescript,
Expand All @@ -414,7 +414,7 @@ describe('the on-ramp emits the same policy — measured by DRIVING it', () => {
]);

const pnpmRanges = new Set(
allSixManifests().map(({ manifest }) => (manifest.engines as Record<string, string> | undefined)?.pnpm),
allScaffolderManifests().map(({ manifest }) => (manifest.engines as Record<string, string> | undefined)?.pnpm),
);
expect([...pnpmRanges], 'every emission declares engines.pnpm, at one range').toEqual([
SCAFFOLD_PNPM_RANGE,
Expand Down
Loading