docs(platform-objects): correct the vitest config's trailing effect claim - #16911
Merged
os-musk merged 1 commit intoSep 8, 2026
Merged
Conversation
…laim The trailing comment opened "No `test` block" and closed "this file's only effect the alias above". Both were true as written (#7934/#8314): the file was this package's first vitest config and carried the alias and nothing else, as its own commit message records — "It carries the alias and nothing else: no `test` block". Both were falsified in place when the console-intercept disarm landed ABOVE them and left them standing (#10374/#13522). Measured on 44c849c: the file opens with a `test` block whose one key is `disableConsoleIntercept: true`, so there IS a test block and the alias is NOT the only effect. The load-bearing half of that sentence is kept intact and now stands on its own: discovery is still untouched (zero `include`/`exclude`/`dir` keys in the file), and narrowing `include` here would still silently drop cases while the gate this file answers went green. The retired wording is paraphrased rather than quoted, so a census grep for the old phrasing does not land back on this file. Config-only, publishes nothing: the file is absent from the package tarball and its text reaches zero dist files, while a control src JSDoc reaches six. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ADLdAs2pVcH17h9tZKWMBg
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 2 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
This was referenced Sep 8, 2026
os-musk
marked this pull request as ready for review
September 8, 2026 18:27
os-musk
enabled auto-merge
September 8, 2026 18:27
os-musk
deleted the
claude/issue-16189-platform-objects-vitest-config-comment
branch
September 8, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16189
Clause-②: no
One comment, at the end of
packages/platform-objects/vitest.config.ts. No code changes.The card asserts two sentences are false — each was judged separately
Read on the worktree at
44c849c7d6(=origin/maintip at fetch time). ⛔ Not accepted as a package.testblock"testblockdisableConsoleIntercept: true— a second effectinclude/exclude/dirkeys anywhere in the fileincludeargument (narrowing it would silently drop cases while the gate went green)vitest list --filesOnlydiscovers 37 files under this config, the affordance sweep among them⭐ The two surviving clauses are kept intact and now stand on their own. Flattening the paragraph would have destroyed the
includeconstraint, which is the half the card itself asked to preserve.The code the replacement sentence describes, quoted from the current tree:
That is the whole
testblock — one key, and not a discovery key.The fossil agrees with the card
The commit that introduced the sentence (#7934 / PR #8314) records why it said what it said:
So both halves were true as written. They were falsified in place by
d890f2fdeb(#10374 / PR #13522), which inserted thetestblock above them and left them standing — the diff touches only lines 4-15 and never the trailing paragraph.The triage round reported 0 hits for both quoted sentences and advised the claiming seat to verify and very likely just close the card. Re-measured, that instrument was reporting artifacts, not absences:
Line-based grep cannot see a phrase that wraps, and the backticks defeat the literal. The card's premise was live the whole time. Had it been closed on that reading, the stale sentence would have stayed.
Evidence — per-sentence absence check
Measured on the file's comment prose (
//stripped, whitespace collapsed, case-folded), so a line wrap cannot hide a phrase. Both sides in the same run, each with controls proving the instrument answers both ways:44c849c7d6(before)disableConsoleIntercept: true,in the raw sourceC1 and C3 answer ≥1 and C2 answers 0 in the same run, so the two zeros in column three are real absences.
⭐ Ablation: inapplicable. This diff adds no guard, so there is nothing to disarm. ⛔ No ablation was invented to fill the slot.
Changeset: route 2 (
skip-changesetlabel), measuredThe floor sentence, read on the worktree at⚠️ the line differs on other trees):
44c849c7d6,AGENTS.md:1036(Measured against that carve-out, rather than assumed — this package does carry comment text into published output, so the probe needed a firing control:
distnpm pack --dry-run— 69 tarball entriesvitest.config.tsABSENT; controldist/index.d.tspresent⇒ This diff publishes nothing from any released package. ⛔ Not an empty changeset.
Verification
Everything below ran on the final commit
46ad903292, on a settled tree. Heavy runs went throughscripts/pm/os-verify-lock.sh; verdicts are quoted from the lines the tools printed, ⛔ never a bare$?.pnpm --filter @objectstack/platform-objects testTest Files 37 passed (37)·Tests 545 passed (545)—VERDICT command-exit 0pnpm --filter @objectstack/platform-objects typecheckVERDICT command-exit 0;check:test-typecheck: OKvitest list --filesOnlysrc/managed-api-method-affordance-sweep.test.tspnpm buildTasks: 73 successful, 73 totalcheck:dual-build-cjs-loads— nowEXIT=0, "104 published require entry point(s) across 67 package(s) load"check:i18n— nowEXIT=0, "OK (9 package(s) — all bundles in sync)"Coverage reconciliation, verbatim (⚠️ this is COVERAGE, not verdicts — verdicts are the table above):
Repo-wide lint: a declared narrowing, with its three readings
pnpm lintis CI's whole-farm run. Narrowed here to the one touched file, and the narrowing is measured rather than asserted:eslint --print-configon the path resolves 6 active rules (comment-swallow/no-code-inside-block-comment,no-restricted-imports,no-restricted-syntax,query-options/no-any-erasure,slot-lookup/no-any-assignment,verify-stand-in/no-asserted-driver-argument). Not my guess.--format json— 1 file linted,errorCount 0 / warningCount 0.eslint.config.mjsrecords, in its own words, that this repo "runs oneeslint.config.mjs, which never enables type-aware linting (noparserOptions.project, no typed@typescript-eslintrules) for ANY file". With no type-aware linting andeslint.config.mjsuntouched, a one-file comment diff cannot move any untouched file's verdict.@objectstack/specroot import — and it reported1 error. The green is a measurement, not a silence.验收备注
packages/cloud-connection/vitest.config.tscarries the same paragraph with the same two dead claims, above the samedisableConsoleIntercept: trueblock (its lines 7-15 vs. the comment at 45-48). ⛔ Out of this card's scope and left untouched; it is in the report for the PM to route.packages/metadata-protocol/src/protocol.tsandpackages/spec/src/contracts/scoped-context.tsare untouched — the diff is one file.🤖 Generated with Claude Code
https://claude.ai/code/session_01ADLdAs2pVcH17h9tZKWMBg
Generated by Claude Code