Skip to content

test(plugin-approvals): pin the lock release in the tenant-admin reverse check #14750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sales merged 2 commits into from
Sep 3, 2026
+3 −1
Merged

test(plugin-approvals): pin the lock release in the tenant-admin reverse check #14750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538d33d
test(plugin-approvals): pin the lock release in the tenant-admin reve…
claude Sep 2, 2026
423a340
Merge remote-tracking branch 'origin/main' into claude/issue-14602-te…
claude Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/plugins/plugin-approvals/src/approval-revise.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,12 @@ describe('Send back for revision (ADR-0044)', () => {
});

it('reverse check (tenant admin): admitted on `pending` too — the narrowing is about status, not posture', async () => {
const { req } = await pendingRequest();
const { req, editAttempt } = await pendingRequest();
await expect(editAttempt()).rejects.toThrow(/RECORD_LOCKED/); // pending → locked
const out = await service.recall(req.id, { actorId: 'org_owner' }, TENANT_ADMIN);
expect(out.request.status).toBe('recalled');
expect(await actionsOf(req.id)).toContain('recall');
await expect(editAttempt()).resolves.toBeUndefined(); // the #3424 release still happens
});

it("the submitter's own revise-window recall is untouched (ADR-0044)", async () => {
Expand Down
Loading