Repository navigation
Console: a full-page record form opened on the app-name address saves, then leaves the document (#27454 holds only on the package-id address) #28036
Description
domain:ui#3 · os-bill · session_01Utp6CaJoinvGQSbHeDaWBe
Filing gate: ① a measured defect. The card thread for #27555 measured it on the live stack while pinning #27454 (report 6519817337, out_of_scope_findings; table in PR #28034's Acceptance notes).
Reach: any user who opens a record's full-page form by its app-name address (/apps/<app name>/<object>/record/<id>/edit or /apps/<app name>/<object>/new). That covers old bookmarks, shared links and every live spec's address. The save succeeds, but the page leaves the app and the toast is lost, as in #27454.
Reader who acts: domain:ui (console).
Duplicate search: search_issues "record form goBack direct URL app name alias save leaves app canonical pathname replace location.key" → #27454 (closed, the package-id case this extends), #25458 and #9468 (closed, other routes).
Observed
Measured on PR #28034's stack (one fresh page per row):
| Address | Mode | history.state.key after load |
URL after Save | Toasts |
|---|---|---|---|---|
showcase_app (name alias) |
edit | generated | about:blank |
0 |
showcase_app (name alias) |
new | generated | about:blank |
0 |
com.example.showcase (package id) |
edit | none | record detail, in app | 1 |
com.example.showcase (package id) |
new | none | object list, in app | 1 |
In a real tab, the alias rows land on whatever page the tab showed before.
Mechanism
AppContent's canonicalAppPathname effect (#26183) moves an alias URL to the package-id address with navigate(…, { replace: true }). That gives the entry a generated location.key. RecordFormPage's hasInAppHistory reads location.key !== 'default', so it reads true, and goBack runs navigate(-1) out of the document.
Wanted
Opened by direct URL on either address, Save stays in the app: edit lands on the record, new lands on the list, each with one toast. The likely fix is in RecordFormPage's in-app-history test, not the redirect: for example, mark entries the console itself pushed, rather than trusting any non-default key. ⛔ console/AppContent.tsx is in seat 4's open PR #27907, so leave the redirect alone while that PR is open. Pin it with an alias-address case in ui/e2e/live/record-form-direct-url.spec.ts (added by PR #28034), plus a jsdom test beside RecordFormPage.
Dedupe words: RecordFormPage goBack location.key, canonical app pathname replace history, direct URL alias save leaves app.
Related: #27454, #27555, PR #28034, #26183.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 30, 2026
domain:ui#3 · os-bill · session_01Utp6CaJoinvGQSbHeDaWBe
Claim: PM loop round 1
Session:
session_01Utp6CaJoinvGQSbHeDaWBeAccount:
os-billBranch:
claude/project-thread-c1be89(the card thread's designated push branch, the recorded platform exception toclaude/issue-<n>-<slug>)Worktree:
objectstack-issue-28036Domain:
domain:uiSeat:
domain:ui#3File surface:
ui/packages/app-shell/src/views/RecordFormPage.tsx, a test beside,ui/e2e/live/record-form-direct-url.spec.ts(alias case, after PR #28034), root changeset (stop on breach; explain in the report)Container & model:
S,mode:thread,model: TIER_DEFAULT(dispatch-gates --tieron178b5238: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility: ui code produces the defect | no platform path covers it | every Studio / console author reaches it today
Thread-read: none
Premise: holds
Serial constraints cleared: PR #28034 (live spec this extends) ACCEPTed, automerge on
Scope of this claim:
RecordFormPage's in-app-history test, so Save stays in the app on both the package-id and the app-name address.console/AppContent.tsx(seat 4's open PR #27907) is off limits.Dispatched 2026-10-30T10:05Z to a card thread of the seat's project; the order lives in the project. ⛔ The thread posts no claim and writes no assignee.
Generated by Claude Code
objectstack-fleet commentedon Oct 30, 2026
domain:ui#3 · os-bill · session_01Utp6CZxX4vFUoXs7HyvMsp
os-dev-report
Report of 2026-10-30T11:25Z.
{ "issue": 28036, "status": "done", "branch": "claude/project-thread-c1be89", "pr": "https://github.com/objectstack-ai/objectstack/pull/28066", "head": "71c89ea29acae22706effdacc5734bf406f1d492", "session": "session_01Utp6CZxX4vFUoXs7HyvMsp (card thread; seat session_01Utp6CaJoinvGQSbHeDaWBe)", "premise_still_valid": true, "summary": "Mechanism assumption measured true: AppContent's canonical replace mints a generated key on the load entry (live: app-name rows read key generated, idx 0). RecordFormPage goBack now reads react-router's own entry index, history.state.idx, at click time: Back only when it is a number above 0 (react-router writes 0 on the load entry, keeps it on replace, adds 1 per push); else record detail (edit) / object list (create) in app. Chosen over a console-written location.state flag because every push already writes the index and every replace keeps it, so no call site has to mark its navigations. useLocation dropped from the page. New jsdom test aliasAddressReturn-28036 (BrowserRouter on jsdom history, canonical replace replayed; 3 app-name cells + in-app push control); the #27454 test's harness moved from MemoryRouter to BrowserRouter with a real push, cells and assertions unchanged. Live spec record-form-direct-url now runs its edit case on both addresses. Changeset @object-ui/app-shell patch. AppContent.tsx untouched.", "tests": "From ui/: vitest run packages/app-shell/src/views/RecordFormPage -> 11 files, 65/65 passed on 71c89ea2. Ablation (ablation-replace, lock VERDICT 1, on 93e6b790 and again on 71c89ea2): anchor typeof entryIndex === 'number' && entryIndex > 0 -> old key test (history.state.key not 'default'), landed (anchor 1->0, blob 4cf71998 -> e207c822); direction written before: 3 app-name cells RED, in-app control + 5 #27454 cells GREEN; observed 3 failed / 6 passed of 9; restored blob == HEAD 4cf71998, git diff HEAD empty. pnpm --filter @object-ui/app-shell type-check exit 0 (both tsc programs) on 71c89ea2. Live, Live E2E UI job build (turbo filters + VITE_BASE_PATH=/ vite build) at 1de7cdda, start-backend.sh :4377, vite preview :5377, one fresh page per row: showcase_app edit -> record detail in app, 1 toast; showcase_app new -> list in app, 1 toast; com.example.showcase edit -> record detail, 1 toast; com.example.showcase new -> list, 1 toast; control (pushed from the list, idx 1) -> Back to the list, 1 toast. Before = card table (about:blank, 0 toasts on the app-name rows). pnpm run test:e2e:live:ci --retries 0: 16/16 passed (1.5 min, shared box). Later commit 71c89ea2 changes only the two jsdom test files.", "gates": "dispatch-gates --commands at 71c89ea2: 34 derived, all run with exit codes captured before any pipe, all exit 0; --ran: 34 derived, 34 run, 0 NOT-MEASURED (also 34/34 on 1de7cdda). Outside derivation, exit 0: pnpm --filter @object-ui/app-shell type-check, pnpm --dir ui run type-check:e2e, pnpm --dir ui check:new-line-citations (0 new), eslint on the 4 changed ui files (0 errors; 17 warnings on untouched RecordFormPage lines). CI on PR #28066 at report time: all gate-carrying checks in_progress (Lint, Type Check, Governed Surface Queue Guard, Check Changeset, PR-body guards); Test UI / Build & E2E UI / Live E2E UI not yet listed.", "line_budget": "5 files, +239 / -74 vs merge base at 71c89ea2 (313 changed lines; under 3000)", "files_changed": [ "ui/packages/app-shell/src/views/RecordFormPage.tsx", "ui/packages/app-shell/src/views/RecordFormPage.aliasAddressReturn-28036.test.tsx", "ui/packages/app-shell/src/views/RecordFormPage.directUrlReturn-27454.test.tsx", "ui/e2e/live/record-form-direct-url.spec.ts", ".changeset/28036-record-form-app-name-address.md" ], "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "mcp_calls": "0", "api_writes": "2 — POST /repos/objectstack-ai/objectstack/dispatches x1 (fleet-write pr_create #28066, draft, no assignees, no labels, no review request; read-back identical, 9321 bytes); this report comment via post-stamped. The harness's after-PR assign/review step was skipped per the dispatch order. git push is not a REST write.", "deviations": [ "The #27454 test file (RecordFormPage.directUrlReturn-27454.test.tsx) is outside the order's named file surface ('a jsdom test beside'): its harness had to move from MemoryRouter to BrowserRouter because the page now reads the browser history's entry index; its five cells and assertions are unchanged.", "PR body order: Fixes, Clause-②, Metadata-protocol directly after the attribution block, then ## 维护者速读 (os-dev.md: declaration lines first, then the six lines); the dispatch order listed 维护者速读 before Fixes. os-dev.md wins on conflict.", "PR #28034 merged before the live step, so the branch took origin/main by a merge commit (1de7cdda's parent 771b71a7), not a rebase: a rebase needs a force-push, which the order forbids.", "Live control row (in-app entry) wrote react-router's own push shape (pushState with idx + 1, then popstate) because no showcase object declares editMode 'page', so no in-app control opens the full-page form; the jsdom control drives a real react-router push.", "Gates and live readings straddle two heads: live at 1de7cdda, gates/unit/ablation re-run on 71c89ea2 (the later commit only touches the two jsdom test files)." ], "open_questions": [], "out_of_scope_findings": [ "carrier: none · ui/apps/console/src/components/FormPage.tsx handleCancel reads location.key !== 'default', the test this PR replaces; whether a canonical replace reaches FormPage's routes was not measured (read-only inference), outside the file surface; noted in Acceptance notes", "carrier: none · ui/packages/layout PageHeader back button reads window.history.length > 1 (the #27454 shape); not reproduced; noted in Acceptance notes" ] }objectstack-fleet commentedon Oct 30, 2026
domain:ui#3 · os-bill · session_01Utp6CaJoinvGQSbHeDaWBe
ACCEPT → PR #28066 comment 6521715864 · 2026-10-30T11:38Z
Generated by Claude Code