Skip to content

docs(adr): ADR-0015 §8 still teaches credentialsRef 'secret:warehouse/readonly', a form the shipped binder never resolves #27688

Closed

Description

@objectstack-fleet

domain:spec#3 · os-support-ai · session_01WGufzgbJhFoXYsLSe5WSPP

Filing gate: ② a governed text made stale by landed or in-flight work. Triage's contract review of PR #27656 (#27614), comment 6504200509, "Follow-up card, named not edited". Filed by domain:spec seat 3 · os-support-ai · session session_01WGufzgbJhFoXYsLSe5WSPP. ⛔ Not a claim. No grade: triage sets the lane and grade. Governed path: a maintainer approves the edit.

Business reason. ADR-0015, which the datasource schema cites, still shows credentialsRef: 'secret:warehouse/readonly' as its example (docs/adr/0015-external-datasource-federation.md:625). The shipped binder resolves only sys_secret: handles, so an author or agent who copies the ADR's example gets a credential that never resolves. #27614 retires that form from the schema guidance, the docs page and the showcase example; the ADR is the last place teaching it.

Wanted

Blocked-by

PR #27656 (it fixes the wording the ADR should match). Dispatch after it merges.

Dedupe

Open issues searched for "ADR-0015 credentialsRef secret:warehouse": none.

Activity

  1. objectstack-fleet commented on Oct 29, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: 写给 AI 的文档与 skills 说错一句,等于产品缺陷 | none | P①

    Triage: p2 · domain:skills · area:api · pm:blocked on PR #27656 · 2026-10-29T18:52Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    area:apiThe API a customer can call, and integrations — REST, connectors, webhooks, jobs
    documentationImprovements or additions to documentation
    and removed on Oct 29, 2026
  3. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    Unblocked: the blocker named by triage is on main: PR #27656 (bfdaba432, 2026-10-29T18:47Z). The unlock scan had not returned the card, so the seat moves pm:blocked → pm:queue with this note. Grade and lane stay as triage set them. ⛔ Not a claim.

  4. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    Claim: PM loop round 1 · 2026-10-30T02:56Z
    Session: session_016WV4cwBHtvCZyayQ8RFyUN (card thread; seat session_016WV4d1QkPVVzNz3FJqb2iS)
    Account: os-elon-musk
    Branch: claude/project-thread-ti9z26 (the card thread's platform-assigned branch — the recorded platform exception; amended by the seat when the thread reported it)
    Worktree: objectstack-issue-27688
    Domain: domain:skills
    Seat: domain:skills#2 (lane position 2 of the p2 rung: #27354 is position 1, seat 1's, and is held behind in-flight #27609 on skills/objectstack-ui/SKILL.md)
    File surface: docs/adr/0015-external-datasource-federation.md (the §8 example, ~:657, plus a dated amendment note and an Amended by header line; the note may say in one sentence that the rest of the §8 example is kept as written, and in one clause that §10's service-secrets is the service-datasource credential binder — §10 and the other keys are not edited) — stop on breach; explain in the report
    Container & model: S, mode:thread, model: opus — dispatch-gates --tier answers MANDATORY claude-fable-5-1 for docs/adr/**; exit taken: the proactive low-headroom downgrade (「fable 不多,后续尽量认领不需要契约复审的卡」), compensated by the CONTRACT_REVIEW_TIER review at fable; effort: xhigh (ADR effort floor)
    Clause-②: no
    Metadata-protocol: none
    Responsibility: ADR-0015, which the datasource schema cites, still shows credentialsRef: 'secret:warehouse/readonly', a form the shipped binder never resolves; an author or agent copying it gets a credential that never resolves.
    Thread-read: 6505597349
    Premise: holds (origin/main b13a1ed3a: docs/adr/0015-external-datasource-federation.md:657 reads credentialsRef: 'secret:warehouse/readonly'; PR #27656 merged bfdaba432)
    Serial constraints cleared: no open skills-lane PR touches docs/adr/0015-* at claim time; the in-flight ADR-0015 D7 work (PRs #27783, #27819, the domain:spec / domain:server lanes) was re-checked by the thread before the first edit at 04740b7c: PR #27783 merged, PR #27819 touches no docs/adr/** file — nothing to serialize. Governed docs/adr/**: Tier H, owes a CONTRACT_REVIEW_TIER contract review before the queue; the seat requests the governed approvers.

  5. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    ACCEPT → PR #27906 comment 6514209943 (register Tier H, docs/adr/**; contract review PASS 6514127387 on head faa40f0, no findings; CI green; approvers requested). Awaiting a GOVERNED_APPROVERS approval, then the seat lands it.

  6. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS

    Landed: PR #27906 merged (813fd9be2, 2026-10-30T03:53Z) after os-zhuang's approval, on contract review PASS 6514127387; pm:dispatched stripped with this note. ADR-0015 §8 now shows credentialsRef: 'sys_secret:9f2c…' with a dated amendment note quoting the original. Nothing further owed on this card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:apiThe API a customer can call, and integrations — REST, connectors, webhooks, jobsdocumentationImprovements or additions to documentationdomain:skillsfindingpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions