Repository navigation
[maintainer] refactor(objectql): split src/engine.ts (23,903 lines, +7,501 in 30 days) along its ObjectQL seams, one move-only slice per PR #25522
Description
Filing gate ③: a task the maintainer dispatched, quoted below. Filed by domain:services seat 1 (seat post #6021) · os-sales · session session_016g7nYP9wdNx1GDa5XDr7Uy, as the third engine-surface file of #24586's restart act. #25467 (protocol.ts) went first as the ruling orders, and its cut 1 landed in PR #25494. ⛔ Not a claim.
The maintainer's words, verbatim (#24586, recorded in 6270097840): 「24586 同意A，是否建议这波分拆等 v18 发布之后再处理。」 The restart act calls for "one [maintainer] card per file over 10,000 lines into its owning lane … Each card starts with a fresh seam measurement taken at that time, in #23050's shape". Triage read the restart condition as true in 6291735609.
Reader who acts: the domain:server lane, engine surface. One dispatch per slice. The first act is the seam table, sections by contiguous member ranges with their 30-day lines, measured fresh at claim.
Measured (on origin/main 842a0aef9d, 2026-10-23)
- Size and churn:
- 23,903 lines, up from 16,402 thirty days ago (
dabf8d795e), a gain of +7,501 (+45.7%). - 34 commits in 7 days and 125 in 30 days, which makes it the hottest of the three engine-surface files.
git blame --since=2026-09-23T15:00Zattributes 8,337 lines (34.9%) to the last 30 days.
- 23,903 lines, up from 16,402 thirty days ago (
- Structure:
- One
ObjectQLclass of 18,214 lines with 254 methods: 147 private or protected, 107 public. - 8 public methods have an inferred return type and stay under the series limit below unless a ruling says otherwise:
registerApp(178 lines),registerHook(75),registerDriver(44),init(40),triggerHooks(32),destroy(22),setDatasourceMapping(13) andgetStatus(8). - The rest is the module preamble and the helpers.
- One
- What reads it by path:
- the ADR anchor file
scripts/adr-anchors/packages__objectql__src__engine.ts.json; - 21 files under
scripts/; - 33 files under
docs/andcontent/, 18 of them ADRs.
- the ADR anchor file
- In flight: none of the 13 open PRs touch the file today. At 34 commits a week, that changes fast, so every slice re-measures it at claim.
The ask (from #24586's ruling and #23050's shape, as on #25467)
- Split along the existing seams, one area per PR. Each slice is move-only: no logic changes.
- Shared state stays explicit. Moved code reaches the class's shared members through one named host object, as in [maintainer] refactor(rest): split
packages/rest/src/rest-server.ts(13,701 lines, 70 commits in 30 days) along itsregister*Endpointsseams, one move-only slice per PR,/metaafter #22877 stage 2 #23050, [maintainer] refactor(service-automation): splitsrc/engine.ts(13,735 lines, +2,199 in 30 days) along itsAutomationEngineseams, one move-only slice per PR #25222, [maintainer] refactor(plugin-security): splitsrc/security-plugin.ts(10,746 lines, +2,803 in 30 days) along itsSecurityPluginseams, one move-only slice per PR #25223, [maintainer] refactor(plugin-auth): splitsrc/auth-manager.ts(10,338 lines, +1,867 in 30 days) along itsAuthManagerseams, one move-only slice per PR #25224 and [maintainer] refactor(metadata-protocol): splitsrc/protocol.ts(33,065 lines, +10,169 in 30 days) along itsObjectStackProtocolImplementationseams, one move-only slice per PR #25467.- ⛔ Not a second copy of a helper.
- ⛔ Not a re-derivation.
- Every slice proves it moved nothing:
- Every gate, baseline, ADR anchor and docs anchor that reads the file by path is migrated in the same PR and stays green.
- When an ADR anchor entry's paragraph describes a moved body, even half of it, the new module gets its own entry that carries that paragraph.
- The package's public
.d.tsstays identical under ruling6348891160item 1, with a positive control. - The decision-letter count of
check:adr-anchorsis reported at base and at head. - ⛔ A gate whose target moved must not go silently empty.
- Serial with the file's in-flight PRs. A slice waits for an open PR on the same region, or that PR merges
mainafter the slice. Every slice measures the file's open PRs again at claim. - ⛔ No new gate.
Series limits already measured (carry them forward)
- Inferred return types. A public method whose return type is inferred cannot move under the host pattern. The
.d.tswould then be inferred through the new module, and tsup drops property JSDoc and splices unrelated docblocks into it (measured on [maintainer] refactor(metadata-protocol): splitsrc/protocol.ts(33,065 lines, +10,169 in 30 days) along itsObjectStackProtocolImplementationseams, one move-only slice per PR #25467 cut 2,getDiscovery). Such a member stays. Annotating it is a signature edit, which needs a ruling. - The tenant-audit census.
UNTYPED_RECEIVERSis shrink-only. A body with athis.<field>.delete/insert/update(site becomes an untyped receiver in aPick-host module, so that body stays unless a ruling says otherwise ([maintainer] refactor(plugin-auth): splitsrc/auth-manager.ts(10,338 lines, +1,867 in 30 days) along itsAuthManagerseams, one move-only slice per PR #25224 cut 8, [maintainer] refactor(service-automation): splitsrc/engine.ts(13,735 lines, +2,199 in 30 days) along itsAutomationEngineseams, one move-only slice per PR #25222 slice 2). - Private statics stay in the class (entangled-shape rule, [maintainer] refactor(plugin-auth): split
src/auth-manager.ts(10,338 lines, +1,867 in 30 days) along itsAuthManagerseams, one move-only slice per PR #25224).
Order and pace
- Because of the churn, each slice should take the coldest section the seam table finds, as [maintainer] refactor(metadata-protocol): split
src/protocol.ts(33,065 lines, +10,169 in 30 days) along itsObjectStackProtocolImplementationseams, one move-only slice per PR #25467 did with batch and*Many. - A seat may hold this card behind
sql-driver.ts's first slices when the file's in-flight PRs make a move-only slice collide.
Not in this card
- Any behaviour change, and any design change to the shared members beyond giving them an explicit host.
driver-sql/src/sql-driver.ts, filed beside this one as its own card.
Dedupe
MCP search_issues on this repository, closed issues included: "split objectql engine.ts or sql-driver.ts move-only cut ruling 24586". There were 113 hits. None is a split card for objectql/src/engine.ts. The related ones are #24586 (the ruling), #25467 (protocol.ts), and #25222, #25223 and #25224 (the services files). New.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 24, 2026
Claim: PM loop round 1
Session:
session_01JVTd3PprStGa26aez5omLBAccount:
sunhaolin(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-25522-objectql-engine-cut-1Worktree:
objectstack-issue-25522Domain:
domain:serverSeat:
domain:server#2File surface:
packages/objectql/src/**(engine.tsand the new seam module of this slice),scripts/adr-anchors/**entries for moved bodies, the path readers ofengine.tsunderscripts/andcontent/that the slice must migrate, one changeset. ⛔ Nodocs/adr/**(governed) (stop on breach; explain in the report)Container & model:
M(one move-only slice plus the seam table),mode:subagent,model: TIER_DEFAULT(dispatch-gates --tierat8801f2bb3: "no path-derived mandate … the tier stays the PM's per-card judgment call"),effort: highClause-②: no
Metadata-protocol: none
Responsibility: n/a — not a defect card
Thread-read: none
Serial constraints cleared: none. No open PR touches
packages/objectql/src/engine.ts(13 open PRs read this fire); last touch onmainis77a77e4(#25396).Premise: re-read on
origin/main8801f2bb3:engine.tsis 23,903 lines, as the card measured; no split has started.Generated by Claude Code
refactor(objectql): move the validation-message i18n helpers out of e…
objectstack-fleet commentedon Oct 24, 2026
os-dev-report
{
"issue": 25522,
"status": "done",
"branch": "claude/issue-25522-objectql-engine-cut-1",
"pr": "#25615",
"session": "session_01JVTd3PprStGa26aez5omLB — the dispatching seat's session (mode:subagent), on the Claude-Session: trailer of commit 328b5b1",
"premise_still_valid": true,
"summary": "Seam table measured fresh at origin/main e649c2d (engine.ts 23,903 lines; 8,253 from the last 30 days; 124 commits in 30 days, 33 in 7; class ObjectQL 317 members, 255 methods, 147 private / 108 public; the same 8 inferred-return public methods the card lists). It is in the PR body as 41 contiguous sections, each with its 30-day lines. Cut 1 is the coldest area that meets every series limit and has no path reader outside objectql: the validation-message i18n block (122 lines, 0 from the last 30 days). The private bodies of ObjectQL#validationMessageContext, #negotiatedMessageLocale and #objectDisplayLabel moved unedited to packages/objectql/src/engine-validation-messages.ts through ValidationMessageHost: the i18nService getter plus a late-bound negotiatedMessageLocale closure; objectDisplayLabel reads no member and is called directly. setI18nService stays: it is a two-line field setter. The new module imports ObjectQL as a type only, so there is no runtime cycle. Two spec/system imports with no other reader in engine.ts (objectLabelKey, resolveBundleLocale) left engine.ts. All six published declaration files are byte-identical, the export lists are identical, and the draft PR is Part of #25522 with skip-changeset. Roll-up summaries (0 lines in 30 days) was set aside for cut 1: buildSummaryIndex is the liveness ledger's evidence by path (packages/spec/liveness/field.json, summaryOperations), and recomputeSummaries has a this.update( write and passes this to aggregateSummaryValue. Proposed cut 2: Datasource routing (isSystemLedgerObject, getDriver, resolveDatasourceBinding, resolveEffectiveDatasource, resolveMappedDatasource, resolveDatasourceFromMapping, matchPattern; 343 lines, 1 from the last 30 days; setDatasourceMapping and the two public statics stay; the new module gets its own anchor entry for the ADR-0057 routing sentence). Measure getDriver's spies and doubles before choosing it. Draft only, per the release terms: no ready flip, no auto-merge, no queue, no merge.",
"tests": "At head 328b5b1. (1) pnpm --filter @objectstack/objectql exec vitest run --project local --maxWorkers=2 under os-verify-lock: VERDICT command-exit 0; JSON report: 466 files, 1,899 suites, 8,700 tests, 8,700 passed, 0 failed, 0 skipped. That includes engine-validation-locale.test.ts, engine-validation-locale-negotiation.test.ts and engine-delete-restricted-locale.test.ts, which pin these helpers. (2) pnpm --filter @objectstack/objectql typecheck (tsc --noEmit plus check:test-typecheck) under the lock: VERDICT command-exit 0, 'check:test-typecheck: OK — ... 39 file(s) / 233 error(s) / 64 pinned signature(s) held in test-typecheck-debt.json'. (3) Move proof by AST token (recursive getChildren leaves): validationMessageContext 104, negotiatedMessageLocale 134, objectDisplayLabel 133 tokens, all SAME, every body line the base line less 2 leading spaces. Negative control: one changed token in negotiatedMessageLocale reports DIFFER. Class side: 317 members at base and head, the 314 that did not move byte-identical, the 3 stubs keep docblock and signature byte-identical. Top level: 232 of 233 statements byte-identical (the other is the spec/system import less two names) plus one new import. (4) .d.ts bar, ruling 6348891160: index.d.ts 9ca22071717e3f761198115fa54a143df4151a52950d826a10677420dcad16ae, index.d.mts 69dd1cfe3875024f434b2d7defce771ebc8c7e48a05be7c946fa6ecdbd912b40, core.d.ts d27b72bde2eec9a47c7dd3c104976321533cf397452ca9f84491a455ec28e73b, core.d.mts 5a0cca505296b678b31c742c285e028fe434f5467bb8d27e052e470ce0e09652, util-ByiLm3B6.d.ts = .d.mts 1742a9cb029654d1ca4e8e392e98001eec85963987f516b1b76f672ecd08e5a9. Each is raw = normalised and base = head, raw diff 0 lines, using the ruling's normaliser verbatim. Note: this package prints single-quoted literals (23 single-quoted literal unions, 0 double-quoted), so that normaliser is a no-op here. Positive control: line 7261 private objectDisplayLabel; made public gives raw = normalised 270f913f734273e380af6ab964e8b15206aa7c511892dea58cc8f6fd9adf5ef7, not equal to 1742a9cb. Export lists from the built bundles: '.' 182 ESM = 182 CJS, './core' 54 = 54, identical at base and head (sorted-list sha256 881616cc... and 393e8069...). (5) One-off mutation, not a kept test (move-only, so no ablation is owed): scripts/ablation-replace.mjs replaced the moved 'return resolveBundleLocale(offered, requested) ?? requested;' with 'return requested;' (anchor 1 -> 0, blob 5d9194fa75bb -> 88406d6408d5). engine-validation-locale-negotiation.test.ts went to 3 failed / 3 passed. Restore: blob == HEAD 5d9194fa75bb and git diff HEAD empty. vitest resolves the relative import from src/, so there is no dist/ leg. test:repo was not run locally (CI's Test Core runs it).",
"gates": "Local, on the real diff (2 files, +135/-39): node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 56 families at 328b5b1 (stderr first line names the repo and the commit). All 56 were run at head, each exit code captured before any pipe. 53 exit 0. Three are NOT MEASURED: node scripts/check-engine-split-ratio.mjs --days 90 exit 2 (CANNOT COMPUTE: the shallow clone's history starts 2026-09-15, inside the 90-day window); node scripts/check-plugin-teardown-shape.mjs --self-test exit 3 (cannot read pinned positive-control commit 621a487 in this shallow clone); pnpm check:dual-build-cjs-loads exit 3 (PREREQUISITE NOT MET: no dist/ for 70 packages; the export lists in tests (4) answer its question for objectql). Reconciliation: dispatch-gates --ran with ':: exit N' lines prints '56 derived famil(ies) accounted for — 54 run, 2 NOT-MEASURED (2 DERIVED from a recorded exit 3)'. It counts the exit-2 refusal as run; by that script's own header it is CANNOT COMPUTE, so this report counts it NOT MEASURED. Outside the derivation, all exit 0: eslint --no-inline-config packages/objectql; eslint on both files; node scripts/check-adr-anchors.mjs (base and head: 84 anchored files, 1,883 decision-letter citations, 52,465 citations across 6,583 files, the same at both ends); node scripts/check-adr-symbol-anchors.mjs (2,384 anchors resolve); node scripts/check-nul-bytes.mjs; node scripts/check-platform-checklist.mjs --changed-from origin/main ('1 anchored file(s) in the change set, 14 anchor(s) judged, 0 lost'). CI on PR #25615 head 328b5b1 at report time: Check Changeset success; No other open PR may claim the same issue success; Type Check (workspace, debt ledger, source gates, consumer gates), the Lint lanes (PM dispatch-gates, CI release & engine gates, ESLint, repo & tooling gates, docs & code guards, the scoped lanes), Governed Surface Queue Guard, Part-of PR must not also close its card, Check PR Size and the rest: in_progress. Opt-in lanes skipped. Not waited on, per the contract.",
"dogfood_battery": "n/a — no
!in the PR title and no (narrowing) arm (Clause-②: no)","mcp_calls": "0 — no GitHub MCP tool called",
"api_writes": "2 relay strokes, both through scripts/pm/fleet-write/dispatch.mjs as POST /repos/objectstack-ai/objectstack/dispatches, executed by the relay as objectstack-fleet[bot]. (1) pr_create: POST /repos/objectstack-ai/objectstack/pulls (draft) + POST /issues/25615/assignees [sunhaolin] + POST /issues/25615/labels [skip-changeset]; run 40082586078 success; read-back 18,999 bytes sent = stored, identical; assignee and label listed. (2) This report: POST /repos//issues/25522/comments via scripts/pm/post-stamped.mjs. Not REST: git push to the branch, twice (the empty-branch probe, then commit 328b5b1).",
"open_questions": [
{
"question": "Later cuts of this file: @objectstack/objectql's .d.ts prints string literals in SINGLE quotes, so ruling 6348891160's verbatim normaliser (double quotes only) cannot absorb a union-member-order swap here. This cut is raw byte-identical, so nothing depended on it. A later cut that moves a body the DTS program checks before the rest of engine.ts could reorder a union. That shows as a raw diff the normaliser leaves in place, which under the ruling's item 1 is a stop. Does the ruling seat want to decide this before cut 2 is dispatched?",
"options": [
"A — The ruling seat states that item 1(b)'s normalisation covers single-quoted literal unions too: the same single class (member order within one literal union), spelled with the quote this printer uses, nothing else normalised. Real business need: the maintainer's split order for a file with 124 commits in 30 days. Long-term: the bar stays on the contract (declarations, visibility, exports), not on printer quote style. AI-error prevention: unchanged, because 1(a), 1(d) and the positive control still catch every change of kind. No sprawl: a ruling sentence, no script, no gate. Effort: one ruling comment.",
"B — Keep the normaliser verbatim. Any later cut whose raw diff carries a union-order swap stops and returns needs_decision, and the ruling seat decides then. Real business need: the same. Long-term: an equivalent outcome, one round later. AI-error prevention: the same. No sprawl: none added. Cost: one stopped cut and a ruling lap mid-series, at a cut whose timing nobody chooses."
],
"recommendation": "A, decided by the ruling seat, not by a dev: it is the class ruling A already judged meaningless to every consumer (the quote character is a printer setting), and deciding it before cut 2 costs one sentence instead of a stopped cut. ⛔ Not acted on here: this dev did not widen the normaliser and adds no script (ruling item 3, card ask 5)."
}
],
"out_of_scope_findings": [
"carrier: the ruling seat, through open_questions[0] above · the single-quote blind spot of the ruling's normaliser on @objectstack/objectql · noted, not filed (not a defect, contract violation or authoring trap)",
"carrier: none (承接者:无) · cut-2 pricing note: Roll-up summaries is cold (0 lines in 30 days), but buildSummaryIndex is the liveness evidence pointer for field.summaryOperations (packages/spec/liveness/field.json: evidence packages/objectql/src/engine.ts, key-mention), so that cut owes a packages/spec ledger edit, and recomputeSummaries stays (a this.update( write, and this passed to aggregateSummaryValue) · noted in the PR body, not filed"
],
"line_budget": "174 changed lines (+135 / -39) over 2 files, under the 3,000 human-merge line; engine.ts 23,903 -> 23,881; engine-validation-messages.ts 118",
"files_changed": [
"packages/objectql/src/engine-validation-messages.ts (added)",
"packages/objectql/src/engine.ts (modified)"
],
"deviations": [
"Commit trailers: the model-free pair (Claude-Session + Co-authored-by: Claude) per AGENTS.md and os-dev.md, in place of the harness reminder's model-named Co-Authored-By line (the pre-push hook refuses a model identifier). PR body footer: AGENTS.md's session-URL form, in place of the harness's line.",
"A2: no scripts/adr-anchors entry added for the new module. The engine.ts entry's one paragraph is the transaction seam and describes no moved body, and the moved bodies cite no ADR (the ADR-0053 Phase 2 cite is in a docblock that stays on the stub). Card ask 3 owes an entry only when a paragraph describes a moved body.",
"A3, narrowed and declared: no direct dependant was type-checked locally. Every moved member is private (reachable from no dependant), and all six published declaration files are byte-identical, so the dependants' input bytes are unchanged. CI's TypeScript Type Check lanes cover them.",
"No baseline objectql test run (head only). The base-vs-head per-test comparison PR #25494 carried is not repeated; the head suite is 8,700/8,700.",
"History: a sibling agent's git fetch --shallow-since=2026-09-15 held .git/shallow.lock, so this run waited on that PID (tail --pid) and read 30-day blame from the deepened history. It did not remove the lock or deepen further, so the 90-day split-ratio gate stays NOT MEASURED.",
"Created a fetch ref refs/issue-25522/main in the shared ref namespace to re-read main without moving origin/main; deleted at cleanup."
]
}
Generated by Claude Code
objectstack-fleet commentedon Oct 24, 2026
ACCEPT → PR #25615 comment 6382672482 (cut 1, head
328b5b194e; lands once CI is green on that head) ·domain:serverseat 2 ·session_01JVTd3PprStGa26aez5omLBGenerated by Claude Code
objectstack-fleet commentedon Oct 24, 2026
Release:
domain:serverseat 2 ·sunhaolin· sessionsession_01JVTd3PprStGa26aez5omLB· 2026-10-24T10:42Z · cause: cut 1 landed (Part of #25522) · destination:pm:queue, unassigned, for cut 2Landed: PR #25615 →
481ac6211(#25522 cut 1)merged: true, merge commit481ac6211641ccb7292508ed423f02e432322e4a, merged 2026-10-24T10:42:01Z through the merge queueorigin/main481ac6211is an ancestor oforigin/main(481ac62116), single parent (squash)gh-readonly-queue/main/*head for PR 25615 remainsvalidationMessageContext,negotiatedMessageLocale,objectDisplayLabel) lives inpackages/objectql/src/engine-validation-messages.ts.engine.tsis 23,881 lines.getDriver's spies and doubles first; the new module owes its own anchor entry for the ADR-0057 routing sentence). Roll-up summaries waits:buildSummaryIndexis the liveness evidence path inpackages/spec/liveness/field.json, so that cut is spec-lane-coupled.pm:dispatched→pm:queue, assignee cleared, in this act. The series card stays open. This seat re-claims cut 2 when a dispatch slot frees.Generated by Claude Code
119 remaining items
objectstack-fleet commentedon Oct 29, 2026
domain:server#1 · os-sales · session_01L6bhgXcN9HaZYSEUdJWEjw
Claim: PM loop round 1 · card thread · cut 19 (delete cascade and reference walking) · 2026-10-29T04:10Z
Session:
session_01L6bhgXcN9HaZYSEUdJWEjw(the seat); the card thread issession_01L6bhgXPvYEKGGY6sms31q2Account:
os-sales(the seat's linked user; the card's assignee)Branch:
claude/project-thread-f9p63p(the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)Worktree: the card thread's own container checkout
Domain:
domain:serverSeat:
domain:server#1Ruling-ref: #24586 ruling A (
6270097840); card body (move-only, one area per PR, one named host); .d.ts bar6348891160+6441032442letter B; host setter6430872749; shared helper6432376812File surface:
packages/objectql/src/engine.ts(the delete-cascade section,planCascadeAtomicity…organizationOwnedRowCounts, minus its stays), one newpackages/objectql/src/engine-*.ts, its path readers and tests,scripts/adr-anchors/**entries for moved ADR paragraphs. ⛔ Nopackages/spec/**, ⛔ nodocs/adr/**(stop on breach; explain in the report)Container & model:
M,mode:thread,model: default tier(dispatch-gates.mjs --tier: "no path-derived mandate"),effort: highClause-②: no
Metadata-protocol: none
Responsibility: n/a — not a defect card
Thread-read: 6468285951
Premise: corrected (read-only premise reading at
origin/mainc4c515ad3: landing6455397586excluded the delete section while #26930 was open; #26930 and #27073 have merged, so the section is free; its −248 price is stale and is re-priced at claim;engine.tsis 22,110 lines)Serial constraints cleared: draft #27339 (
os-bill, #27186) touchesengine.tsimports,insert,updateandaggregate, not this section; #27277 (marchtian,pm:epic) declarespackages/objectql/src/**with no PR yet, so the dev reads branchclaude/project-thread-mlrxgxat start; #27165 (queued) editsfind/findOne, disjoint. Lane card threads at claim: 2 of the maintainer's 5.Generated by Claude Code
objectstack-fleet commentedon Oct 29, 2026
domain:server#1 · os-sales · session_01L6bhgXPvYEKGGY6sms31q2
os-dev-report
{ "issue": 25522, "status": "done", "branch": "claude/project-thread-f9p63p", "pr": "https://github.com/objectstack-ai/objectstack/pull/27391", "session": "session_01L6bhgXPvYEKGGY6sms31q2", "premise_still_valid": true, "summary": "Cut 19 of the engine.ts split: five bodies of the Delete cascade and reference walking section (collectCascadeDeleteSet, refuseRestrictsInsideOwnCascade, deleteRestrictedError, referenceProbeFilter, recordReferenceCheckElevation) move unedited into packages/objectql/src/engine-delete-cascade.ts behind DeleteCascadeHost, stubs left in the class; cascadeReachOf (read only by refuseRestrictsInsideOwnCascade) moves with it; cascadeMemberKey, cascadeSetAdd, cascadeSetHas, declaredMultiValued and CascadeDeleteSet are exported in place and imported back, no copy. engine.ts 22,110 -> 21,874 (net -236, +42/-278), module 429 lines, PR 753 changed lines over 4 files. The order hypothesis (~18 bodies, ~1,069 lines) is falsified by the series limit on private statics: 10 methods of the section read a private static (planCascadeAtomicity, cascadeDeleteRelations, dependentCountIsDisclosable, probeReferencingRows, probeReferencingRowsOfSet, walkReferencingRelations 318 lines, countReferencingRowsOutside, refuseOrganizationDeleteWhileOwned, organizationOwnedRowCounts) and the 7 statics stay; cascadeRelationBehavior stays because federated-injected-column-readers.test.ts checks the organizationOwnedRowCounts via row by reading the helper in the SAME file; 6 small bodies pay 3 lines or less and stay. Readers re-keyed: system-context.mdx register row 29 (recordReferenceCheckElevation) and one platform-checklist citation (records-forms.json engine.ts#required). One PR, no split needed.", "tests": "Under os-verify-lock: full turbo build 115/115 exit 0; objectql typecheck (tsc + check:test-typecheck) and core typecheck exit 0; objectql vitest --project local Test Files 479 passed (479), Tests 8942 passed (8942); runtime real-driver cascade integration tests 3 files 15 passed 1 skipped, plugin-security delete-reference-cleanup-system-identity 18 passed; eslint --no-inline-config packages/objectql exit 0. test:repo not run locally (surface byte-identical), CI Test Core. Move proof: AST leaf-token compare 5/5 SAME (97/107/582/810/323 tokens), negative control DIFF; class 330/330 members, 325 byte-identical + 5 stubs; top level 229/238 identical, rest = 2 import-list edits, 5 in-place exports, cascadeReachOf moved byte-identical, class. .d.ts: all 6 files raw byte-identical base c4c515ad3c vs head (util-6U6fCMd3 both); positive control via ablation-replace (drop private on the deleteRestrictedError stub) renames chunk to util-Dd_AzMXV and changes every hash, restore blob == HEAD, rebuild equal on 6 d.ts + 4 bundles. dtsnorm.mjs was not available in this container (other project files); with 0 raw-diff lines nothing needed normalising. Export lists 182/54 ESM=CJS, name+fn.name hash equal base/head. Bundle regions +1 only (engine-delete-cascade.ts), external first-load order equal; +1 import statement (module own renderOperationMessage from spec/system). Late-binding probe zz-probe-cut19.mjs: 16 lines identical base/head (5 timestamped construction lines set aside), stderr empty. No tested behaviour changed, so no ablation.", "gates": "dispatch-gates --commands on head b3a0abd0f6 (merge base c4c515ad3): 80 families, each run with exit captured before any pipe, 80/80 exit 0; --ran with exit annotations: 80 derived, 80 run, 0 NOT-MEASURED, 0 UNRUN (a DERIVED zero). Prereqs: full build, git fetch --shallow-since=2026-07-22, fetch 621a4876. Hand gates exit 0: check-adr-anchors (decision letters base 1,900 / head 1,900; citations 60,466 across 8,527 / 8,528 files), check-system-context-census (154 sites), check-tenant-audit-census (245), check-adr-symbol-anchors (2,798), check-platform-checklist --changed-from origin/main and full, check-commit-card-trailers, check-nul-bytes, durability --list base==head masked (165 lines). main 7e200b4a68 merged before pr_create (ui/Studio only, none of this diff paths; change set unchanged). CI check-runs on #27391: in_progress at report time, for the seat to read.", "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "mcp_calls": "8 — reads only: issue_read x4 (get x1, get_comments x3), pull_request_read x2 (get #26932, get #27391 read-back), list_pull_requests x2; no write tool", "api_writes": "6 — git push x4 (branch create, cut commit, checklist commit, main merge; not REST writes); relay pr_create x1 via scripts/pm/fleet-write/dispatch.mjs (run 40820376505: POST pulls draft + assignees os-sales + labels skip-changeset; body 23133 bytes read back identical); relay pr_request_reviewers x1 (run 40820426781, reviewers os-sales); this os-dev-report via scripts/pm/post-stamped.mjs (POST issues/25522/comments)", "open_questions": [], "out_of_scope_findings": [ "carrier: seat 1 · noted, not filed — PR body inconsistency to fix by relay if wanted: the 维护者速读 line says 区内 24 个成员 while the English table counts 27 (26 methods and REFERENCE_PROBE_BATCH); 27 is right; the dev does not PATCH bodies", "carrier: next cut · noted, not filed — the rest of this section (walkReferencingRelations 318, probeReferencingRows 100, planCascadeAtomicity 81, dependentCountIsDisclosable 49, cascadeDeleteRelations 45 ...) is locked by the private-static series limit; only a ruling on passing statics through the host would free it. cascadeRelationBehavior (60) is locked by the reader test same-file via rule", "carrier: seat 1 · noted, not filed — the order named branch claude/project-thread-mlrxgx (#27277) to read; it does not exist on the remote (git ls-remote 0 refs)" ] }objectstack-fleet commentedon Oct 29, 2026
domain:server#1 · os-sales · session_01L6bhgXcN9HaZYSEUdJWEjw
Release: cut 19 delivered · back to
pm:queue·domain:server#1· 2026-10-29T05:43Z⛔ Not a claim. This card is
Part ofa series; the seat's claim on cut 19 ends with its merge.5c0e4fd0c6). Five bodies of the "Delete cascade and reference walking" section moved intopackages/objectql/src/engine-delete-cascade.ts:collectCascadeDeleteSet,refuseRestrictsInsideOwnCascade,deleteRestrictedError,referenceProbeFilterandrecordReferenceCheckElevation.cascadeReachOfmoved with them.engine.tswent from 22,110 to 21,874 lines. The seat record is the ACCEPT 6488660939.walkReferencingRelations(318 body lines).cascadeRelationBehavioris kept by the reader test's same-fileviarule. None of them can move under the current series limits, so the section is spent until a limit changes.origin/mainbefore quoting a size. No branch carries unmerged work for this card (Resume-from: none).Generated by Claude Code
objectstack-fleet commentedon Oct 30, 2026
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
Claim: PM loop round 5 · cut 20 (series; this claim ends with the cut's merge)
Session:
session_01L6bhgUCizoYWQVJWjhdR6FAccount:
os-salesBranch: the card thread's platform-assigned
claude/project-thread-*(amendment follows naming it)Worktree: the card thread's
Domain:
domain:serverSeat:
domain:server#2File surface:
packages/objectql/src/engine.tsand ONE new sibling module for the section the cut moves, plus the moved bodies' tests, the d.ts/api-surface artefacts the series bar names,.changeset/*(stop on breach; explain in the report)Container & model:
M,mode:cloudcard thread,model: default (dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility:
objectql engine.ts split series (this lane) | move-only, the series' d.ts bar and limits | every reader of engine.tsThread-read: 6489017397
Premise: to be re-priced on fresh
origin/mainby the cut's first step, as the cut-19 release note directs (the delete-cascade section is spent; the next section is chosen by measured size under the current series limits)Serial constraints cleared: re-checked by the thread with
git merge-treeagainst every open PR onengine.tsbeforepr_create.objectstack-fleet commentedon Oct 30, 2026
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
Claim amendment to
6512318712· 2026-10-30T01:04Z · Branch namedBranch:
claude/project-thread-n9w3bf(the card thread's platform-assigned branch, baseorigin/mainfec60e00)Worktree: the card thread's
Everything else in the claim is unchanged.
objectstack-fleet commentedon Oct 30, 2026
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
os-dev-report
{ "issue": 25522, "status": "done", "branch": "claude/project-thread-n9w3bf", "pr": "https://github.com/objectstack-ai/objectstack/pull/27851", "session": "session_01L6bhgWZYhVkTy8Yp9oDD11", "premise_still_valid": true, "summary": "Cut 20, move-only. Re-priced all 268 ObjectQL members on fresh main (engine.ts 22,170 lines, blob 543fe0beb94c): the only free contiguous area paying more than -30 is query lowering, so resolveWhereTokens, lowerRelationConditions and resolveSearchQueryableFields move unedited into packages/objectql/src/engine-query-lowering.ts behind QueryLoweringHost (Shape B: stubs + ThisParameterType host literals, getters over late-bound closures, generic called as (fn<W>).call). resolveThenLowerWhere and relationSitesOf gain export in place (cut-14 ruling 6432376812); engine.ts 22,170 -> 22,131, net -39 (+28/-67), module 178 lines. New shape to review: resolveSearchQueryableFields reads SECURITY_SERVICE_SOURCE_SLOT, so the host carries a symbol-keyed getter typed unknown. Runners-up: write support ~-35 (scattered), dispatchUnscopedMultiWriteHooks -30; the large bodies are all locked (statics, inferred public returns, engine.ts#X pointers, erasure sites, census write sites).", "tests": "No test added or edited. d.ts on base 0a4b0fb223 vs merged head 0014e7332: core/util x2 raw byte-identical; index.d.ts/.d.mts 180 raw-diff lines each (top-level reorder caused by the two in-place exports, measured per variant) -> ruling 6441032442 letter B: statements 137/137 (0 only-base, 0 only-head), normalised sha EQUAL (8369d957 / aa35d3ef), declared surface 5ad12aeac594 (118) EQUAL, import 26 / export 300 specifier sets EQUAL; no chunk rename (util-BMx8ShtN). Positive control: ablation-replace dropped private on the lowerRelationConditions stub -> chunk util-ljRTZG5W, normalised 4ca41d40 != 17b34879, surface 21b34ba6d9a8 != 38c72db70306; restore blob == HEAD fd1d10a8237a, rebuild equal. Export lists index 194 / core 54 ESM=CJS, name+.name digest c5c2f41286d9 equal. Bundle regions add only // src/engine-query-lowering.ts; external imports 158/140 identical in order. AST compare 3/3 SAME (173/282/135 tokens), class 333/333 members (330 byte-identical + 3 stubs), top level 237/242 identical; negative controls DIFF/FAIL. Late-binding probe 27 lines identical base/head. turbo build 116/116; typecheck objectql+core exit 0; objectql vitest --project local: 491 files, 9252 passed; 2-minute set 3 files / 38 passed.", "gates": "dispatch-gates --commands on 0014e7332: 48/48 exit 0; --ran: 48 derived, 48 run, 0 NOT-MEASURED, 0 UNRUN (a DERIVED zero). Hand gates 16/16 exit 0: check:authz-resolver, check:error-code-casing, check:filter-alias-parity, check:engine-double-contract, check:tenant-chokepoint, spec check:api-surface, spec check:generated, spec check:liveness, check:adr-anchors (1,921 letters base = head), check:query-options-erasure, check-tenant-audit-census (JSON equal), check-adr-symbol-anchors, check-platform-checklist --changed-from origin/main, check-commit-card-trailers, check-system-context-census, check-nul-bytes; durability --list identical masked (167). eslint --no-inline-config packages/objectql exit 0. merge-tree clean with origin/main 637cfc6736 (range touches registry.ts, 2 ADRs, liveness/datasource only); 13 open PRs fetched, none touches packages/objectql/src/engine*. CI check-runs on #27851 not yet read (just opened).", "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm", "mcp_calls": "0 — all reads via gh api REST", "api_writes": "3 — git push (claude/project-thread-n9w3bf); fleet-write relay pr_create -> #27851 (run 40989704350, read-back identical, assignees none, no review request); this os-dev-report comment via post-stamped (issues/25522/comments)", "open_questions": [], "out_of_scope_findings": [ "PR body deviations for the seat to patch (os-dev writes the body once): (1) the attribution link and footer use this card thread (cmsg_..Uu8wcXvRGcPJrpUWMNhpGy6c) and session_01L6bhgWZYhVkTy8Yp9oDD11 instead of order-common item 6's seat-2 thread and seat session, and the footer order is the harness's; (2) the `Skills-docs:` line order-common item 5 asks for is missing (value: none); (3) no seat signature first line.", "dtsnorm-cut20.mjs is a re-implementation of ruling 6441032442 item 1(b) from its text (the original dtsnorm.mjs is in another project's files); sha256 2dd168976943dd62df853a20dd2e06fc41afea76aef34cb2d4e7fb54af8fa5c0, positive control shows it sees a surface change.", "Series outlook: after this cut no free contiguous area in engine.ts pays more than -30 under the current limits; ScopedContext + ObjectRepository (~717 lines) are outside the Shape B host model. carrier: this report · noted, not filed" ] }objectstack-fleet commentedon Oct 30, 2026
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
Release: cut 20 delivered · back to
pm:queue·domain:server#2· 2026-10-30T03:08Z⛔ Not a claim. This card is
Part ofa series; the seat's claim on cut 20 (6512318712, amendment6512348857) ends with its merge.packages/objectql/src/engine-query-lowering.ts:resolveWhereTokens,lowerRelationConditionsandresolveSearchQueryableFields. The two shared top-level helpersresolveThenLowerWhereandrelationSitesOfare exported in place fromengine.ts(not from the package entry).engine.tswent from 22,170 to 22,131 lines. The seat record is the ACCEPT6513587982.SECURITY_SERVICE_SOURCE_SLOTthat reads the engine's slot at each use, so the moved body keeps the "read at use, never cached" property.mainand found this section the only one movable at ≥ −30 lines under the current series limits. Re-price on freshorigin/mainbefore quoting a size; expect the series to be near spent until a limit changes. No branch carries unmerged work for this card (Resume-from: none).