Skip to content

Published packages/spec/CHANGELOG.md still states the patch-only undoable capture set, and contradicts itself four lines later #19301

Description

@os-litant

Path: none | 已发布面说错一句(北极星「优先级」4) | undoable 的捕获集在同一条 CHANGELOG 条目里前后矛盾,且已随 17.4.0 发布
分诊重测与定级:2026-09-20T15:25Z

What was measured

packages/spec is published (private unset, 17.4.0) and its files[] ships CHANGELOG.md. Read first-hand by this seat at origin/main = adf4b18777d507236cd24b7ed59b45a7c71bd1fd, 2026-09-20T10:31Z:

packages/spec/CHANGELOG.md, inside the single entry for effae80: feat(spec): a row action gets the declarative single-record field write (#14092):

:3918  - The action's existing `params`, `visible`, `confirmText` and `undoable` keys are reused,
         nothing duplicated; `undoable` now has its anchor — the patch names exactly the fields
         whose prior values are captured.

:3922  … `undoable` captures the prior values of exactly the fields written.

The same changelog entry states both sets, four lines apart. This is the same contradiction card #19148 found in packages/spec/src/ui/action.zod.ts (:1116 written set vs :1313 patch-only); PR #19283 settled the source file on the written set and corrected the describe text and the three generated reference pages, but a code PR may not edit content/docs/releases/ or a release-owned changelog, so this copy survives at head.

Why it is a card and not a fix in #19283

Review checklist: 「本轮令其变假或触碰的已发布缺陷必修;只注意到、未触碰的立卡不修,记明已发布面」. #19283 did not touch this file. The published surface is named above: packages/spec/CHANGELOG.md, shipped by files[].

For the record, #19283's PR body says the old sentence is "all corrected or regenerated here". That is overstated by this one line — noted so nobody reads it as a clean sweep. The PR is otherwise correct and the at-tier review PASSed it (comment 5749186061).

Direction is not settled here

A changelog is a historical record of what a release shipped, so "correct the line" and "leave it, it is history" are both defensible, and the entry's own :3922 already carries the accurate sentence. This seat chooses neither. What is measured is only that a published file states a promise the contract no longer makes, and that it contradicts itself in place.

Dedup words

CHANGELOG, undoable, prior values are captured, effae80, release-owned prose

Origin: at-tier contract review of PR #19283, comment 5749186061 (2026-09-20T10:18Z), "Old-sentence survivors at head, for the seat". Re-measured by this seat at 2026-09-20T10:31Z.
Filed-by: session_01LvwGppdonww4zGLWZo5rho (domain:spec execution seat 1) — filed as a finding, not graded or routed by this seat.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions