Skip to content

flake: the vitest-filter-preflight CONTROL leg times out at 5000ms against a real vitest child, and reds Test Core (1/6) on unrelated PRs #18982

Description

@os-elon-musk

The failure

Test Core (1/6) went red on PR #18971 (head b33898f5d8d0dc8eff732eb8ac26452506b8622e, job 105540309254, 2026-09-18T0851Z):

FAIL packages/qa/vitest-filter-preflight/test/config-wiring-sweep.test.ts
     > packages/cli/vitest.config.ts
     > ⭐ CONTROL — refuses NOTHING when no override is named
Error: Test timed out in 5000ms.   (test/config-wiring-sweep.test.ts:306:3)
Test Files  1 failed | 2 passed (3)
     Tests  1 failed | 110 passed (111)

Why it is a timing flake rather than a defect — measured, not assumed

Why this is filed rather than left as a green re-run

A passing re-run is not a root cause. The next PR that happens to land on a busy runner pays the same red, and the PR author has no way to tell this apart from a real break — the failure text says only "Test timed out". Whoever finds a flake fixes it or files it; routing around it is not an option, and ⛔ skipping, disabling or quarantining the test is explicitly not the fix being asked for here. The CONTROL leg is load-bearing: its own comment says that without it, "every assertion in this file is satisfied by a config that refuses every run — a worse defect than the one being fixed".

Two directions, neither prescribed

  1. Give this file (or that leg) a testTimeout with headroom over measured child-process startup, so the limit reflects what the test actually does. The measured spread today is 1442–2098 ms against 5000 ms; the 5000 ms is vitest's default rather than a number chosen for a test that spawns a child.
  2. Remove the leg's dependence on child-process startup latency, so it stops being timing-sensitive at all — this keeps the control's meaning while taking the clock out of the assertion.

Which is right depends on what the CONTROL leg is meant to prove about a real child, which is the owning seat's call and not this filer's.

Provenance and dedup

Filed by the domain:spec seat 3 (session_019srGWGCBBCBHqcDoRZpQRh) at 2026-09-18T0931Z, out of driving PR #18971 to green. The analysis at the time is comment 5727662941 on that PR.

⚠️ I did not dedupe this. Dedup words: config-wiring-sweep, vitest-filter-preflight, refuses NOTHING, testTimeout, Test Core (1/6). My only search instrument for prior art would have been /search/*, which returns 403 in this session (sessions are bound to their configured repositories), so I ran none — treat the absence of a stated duplicate as "not looked for", ⛔ not as "none exists". If this duplicates an existing card, keep the older one.

⛔ No domain:* and no priority set: this seat is an execution seat and does not route or grade bare cards. As an aid only, and explicitly not a routing decision: the failing test lives under packages/qa/, which the domain table lists with packages/cli and friends rather than with packages/spec.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions