Bump OpenSSL 1.1.1 -> 3.6.3 - #387
Conversation
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
a21ca84 to
71df076
Compare
nick-l-o3de
left a comment
There was a problem hiding this comment.
Looks fine by me! Note that last I checked, it was used by Python, and Qt and a few other libraries, notably
- AWSGameLift stuff - and other AWS stuff - we don't maintain this anymore, so its not relevant. We should, in fact, consider eliminating any related folders. They'll be there in history, but we can close it up for now.
- Qt - note how the Qt build config.json refers to OpenSSL-1.1.1t-rev1-linux and windows. We may have to rebuild Qt to ensure they're all on the same platform here.
- Python - Python has crypto built into it because it is everything AND the kitchen sink. We may have to ship a new python, and thus a new Qt For Python (pyside6) lib too.
- O3DE uses it as far as I know in the networking platform.
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
71df076 to
ce2af37
Compare
|
Thank you for review and the comment about the usage. Now most of the tests are fixed. The only one left is Android build - the compiler fails to build a package due to the build parameters, that are incorrect: 32-bit ARMv7 does not support 128-bit integer. The parameters are set based on |
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
|
The Android build is fully fixed. |
|
On the "we may have to rebuild Qt" point, I went digging through the Qt package scripts and I think it's only Windows that actually needs it. Windows really does link it: Linux looks vestigial though. That matches what I see in the binaries downstream: the Qt6 we ship in the Fedora packages has no TLS backend plugin at all (libQt6Network has all the QTlsBackend machinery and the "Current TLS plugin does not support..." strings, but no backend .so ever gets built or installed), and the engine itself has zero So unless Windows is the blocker, I don't think Linux or Mac need a Qt rebuild for this. Might also be worth dropping the now-unused Nice work on this by the way, getting off 1.1.1 is a big one. |
The Linux script has a dead code related to Unfortunately we statically embed OpenSSL and export unhidden in |
Bump OpenSSL to 3.6.3 across all platforms
Unifies the O3DE OpenSSL 3rdParty package to 3.6.3, replacing the 1.1.1.
Changes
openssl-3.6.3.set_openssl_port_to_1_1_1_x.patch,enable-stdio-on-iOS.patch); updated package metadata (OpenSSL changed toApache-2.0).qemupackage no longer exists on modern Ubuntu, and the aarch64 binfmt check now also recognizes kernel-levelbinfmt_miscregistrationTesting