Skip to content

ci: support windows-arm64 again - #1346

Closed
Taoister39 wants to merge 1 commit into
nvm-windows:masterfrom
Taoister39:master
Closed

ci: support windows-arm64 again#1346
Taoister39 wants to merge 1 commit into
nvm-windows:masterfrom
Taoister39:master

Conversation

@Taoister39

Copy link
Copy Markdown

Summary

Re-enables Windows ARM64 support in the CI release pipeline and installer.

Changes

.github/workflows/release.yml

  • Switch the build step to PowerShell (shell: pwsh)
  • Build three separate executables in sequence:
    • nvm-64.exe — compiled for GOARCH=amd64
    • nvm-arm64.exe — compiled for GOARCH=arm64
    • nvm.exe — compiled for GOARCH=386 (fallback)
  • Apply the NVM icon to all three executables (was previously only applied to nvm.exe)

nvm.iss

  • Add arm64 to ArchitecturesInstallIn64BitMode so the installer runs in 64-bit mode on ARM64 machines
  • Ship all three binaries; use Inno Setup Check: functions to install the correct one as nvm.exe based on processor architecture:
    • InstallARM64 — installs nvm-arm64.exe on ARM64 systems
    • InstallX64 — installs nvm-64.exe on x64 systems
    • InstallOtherArch — installs the 32-bit nvm.exe as fallback

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Jun 1, 2026
@coreybutler

Copy link
Copy Markdown
Collaborator

I appreciate the contribution.

We will not be releasing anything further on the 1.x.x line. Version 2 is a complete rewrite and this PR is no longer relevant to the new code base.

Native ARM64 support is available in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants