feat(promises): Switch to coroutine based Promise#1131
Open
kristijanhusak wants to merge 1 commit intomasterfrom
Open
feat(promises): Switch to coroutine based Promise#1131kristijanhusak wants to merge 1 commit intomasterfrom
kristijanhusak wants to merge 1 commit intomasterfrom
Conversation
556d082 to
ce77a38
Compare
Member
Author
|
@seflue @chipsenkbeil just a heads up about this change. It should not affect org-roam, but I'd appreaciate if you can confirm that nothing is broken. |
9fc58cd to
8fff1a8
Compare
Contributor
|
@kristijanhusak I'll try to take a look this weekend. Finishing up some work on neovim core. Btw, just got some early portion of |
Member
Author
|
Sounds good. I'm following the progress on that :) Currently we use Snacks for images, but I'm definitely looking forward to using the built in api once it's ready. |
8fff1a8 to
277189d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Promise class to use coroutines. This change will allow writing more readable async code by providing async wrapper where necessary (new
Promise.async()method), removing the need for multiplenext()chains.Changes should be fully backward compatible, with removal of the few unused methods, like
Promise.any,Promise.raceandPromise.all_settled.Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.