Add layered project configuration for standalone Modules - #226
Draft
wyli wants to merge 5 commits into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
wyli
force-pushed
the
feat/standalone-module-project-configuration
branch
from
August 19, 2026 19:18
d15959b to
52ca946
Compare
wyli
force-pushed
the
feat/create-standalone-modules
branch
from
August 20, 2026 08:33
34479e8 to
434d4da
Compare
wyli
force-pushed
the
feat/standalone-module-project-configuration
branch
from
August 20, 2026 08:35
52ca946 to
754665a
Compare
Add strict typed project and SDK settings for standalone Modules, including project identity, metadata paths, build type, CTest, CUDA, base images, and SDK discovery. Resolve explicit machine-local overrides ahead of committed defaults and expose the selected profile through version diagnostics. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Allow standalone Modules to commit additive Docker build options, Docker run options, and selected forwarded environment names. Validate the typed arrays and make their resolved values visible through project diagnostics. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Resolve scalar and additive settings consistently for build, run, container, install, package, setup, and test. Keep CLI Docker additions repeatable, add atomic vector replacement and inherited-layer suppression, reject reserved raw build arguments, and report effective configuration without exposing option values. Document the beginner-facing configuration model and preserve existing local-source build context behavior. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
feat/standalone-module-project-configuration
branch
from
August 20, 2026 08:38
754665a to
691e19a
Compare
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[tool.holoscan]and[tool.holoscan.sdk]project configurationStack
This PR is intentionally based on #225 and should be reviewed after it. Once #225 merges, this PR can be retargeted to
main.The Xvfb, CTest-driver, and installed-artifact release hardening remain deferred to the final follow-up PR.
Validation
python -m pytest -q -o addopts="" tests/unit— 596 passed, 1 skippedpython -m ruff check src/holoscan_cli tests/unitpython -m black --check src/holoscan_cli tests/unitAI-assisted: Created with Codex/GPT at the user's request.