Skip to content

V2 of LiveText: pumped generator follow-up - #20649

Merged
seanbudd merged 16 commits into
nvaccess:masterfrom
codeofdusk:live-text-skip-beep
Aug 13, 2026
Merged

V2 of LiveText: pumped generator follow-up#20649
seanbudd merged 16 commits into
nvaccess:masterfrom
codeofdusk:live-text-skip-beep

Conversation

@codeofdusk

@codeofdusk codeofdusk commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

#20177, supersedes #20216.

Summary of the issue:

After #20177:

  • It is impossible to tell whether lines have been skipped during large text floods;
  • Copyright and attributions were outdated or missing.

Description of how this pull request fixes the issue:

This PR:

  • Updates copyright and attribution;
  • Adds a "beep for skipped lines" option to terminal programs settings.

Testing strategy:

Verified that the beep works as expected. Alpha testing.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI lite review requested due to automatic review settings August 12, 2026 02:08
@codeofdusk
codeofdusk requested review from a team as code owners August 12, 2026 02:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to the LiveText “pumped generator” work, adding user feedback for cases where large terminal floods cause line truncation, and updating attribution/changelog text accordingly.

Changes:

  • Add a new Advanced Settings option to beep when terminal live-text bursts are truncated (skipped lines).
  • Implement a variable-duration beep when LiveText.MAX_LINES truncation occurs.
  • Update user documentation and changelog attribution for the related LiveText work.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
user_docs/en/userGuide.md Documents the new “Beep for skipped lines” advanced setting.
user_docs/en/changes.md Updates the changelog entry metadata/attribution for the LiveText work.
source/NVDAObjects/behaviors.py Adds beep logic and duration calculation when lines are truncated by MAX_LINES.
source/gui/settingsDialogs.py Adds the new checkbox to Advanced Settings and wires it into save/default handling.
source/config/configSpec.py Adds the new terminals.beepForSkippedLines config setting (default enabled).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread source/gui/settingsDialogs.py
Comment thread source/NVDAObjects/behaviors.py Outdated
Comment thread source/NVDAObjects/behaviors.py Outdated

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Userguide reads well

Comment thread user_docs/en/changes.md Outdated
Comment thread user_docs/en/changes.md Outdated
Comment thread user_docs/en/changes.md Outdated
@codeofdusk

Copy link
Copy Markdown
Contributor Author

@seanbudd I'm trying to make this a subitem but the automatic lint is fighting me here.

@seanbudd
seanbudd merged commit 3230d29 into nvaccess:master Aug 13, 2026
46 checks passed
@github-actions github-actions Bot added this to the 2026.3 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants