V2 of LiveText: pumped generator follow-up - #20649
Merged
Merged
Conversation
… the new LiveText speech generator
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to the LiveText “pumped generator” work, adding user feedback for cases where large terminal floods cause line truncation, and updating attribution/changelog text accordingly.
Changes:
- Add a new Advanced Settings option to beep when terminal live-text bursts are truncated (skipped lines).
- Implement a variable-duration beep when
LiveText.MAX_LINEStruncation occurs. - Update user documentation and changelog attribution for the related LiveText work.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Documents the new “Beep for skipped lines” advanced setting. |
| user_docs/en/changes.md | Updates the changelog entry metadata/attribution for the LiveText work. |
| source/NVDAObjects/behaviors.py | Adds beep logic and duration calculation when lines are truncated by MAX_LINES. |
| source/gui/settingsDialogs.py | Adds the new checkbox to Advanced Settings and wires it into save/default handling. |
| source/config/configSpec.py | Adds the new terminals.beepForSkippedLines config setting (default enabled). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
seanbudd
reviewed
Aug 13, 2026
seanbudd
reviewed
Aug 13, 2026
seanbudd
reviewed
Aug 13, 2026
seanbudd
reviewed
Aug 13, 2026
seanbudd
reviewed
Aug 13, 2026
seanbudd
approved these changes
Aug 13, 2026
Contributor
Author
|
@seanbudd I'm trying to make this a subitem but the automatic lint is fighting me here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#20177, supersedes #20216.
Summary of the issue:
After #20177:
Description of how this pull request fixes the issue:
This PR:
Testing strategy:
Verified that the beep works as expected. Alpha testing.
Known issues with pull request:
None known
Code Review Checklist: