Skip to content

Add pgettext labels to options in "Say all reads by" - #20645

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
wmhn1872265132:try-pgettext
Aug 13, 2026
Merged

Add pgettext labels to options in "Say all reads by"#20645
seanbudd merged 2 commits into
nvaccess:masterfrom
wmhn1872265132:try-pgettext

Conversation

@wmhn1872265132

Copy link
Copy Markdown
Contributor

Link to issue number:

Follow-up to #20467

Summary of the issue:

#20467 added three options, but the "line" option has a completely different meaning in source\NVDAObjects\window\_msOfficeChart.py than it does here.

Description of user facing changes:

None

Description of developer facing changes:

None

Description of development approach:

Add pgettext labels to the options in "Say all reads by" to distinguish them from existing strings with the same text.

Testing strategy:

  • Translation string check passed
  • Tested that the translation of the "line" option is correct

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@wmhn1872265132
wmhn1872265132 requested a review from a team as a code owner August 11, 2026 02:08
Comment thread source/config/featureFlagEnums.py Outdated
@seanbudd
seanbudd merged commit 4094bb8 into nvaccess:master Aug 13, 2026
23 of 25 checks passed
@github-actions github-actions Bot added this to the 2026.3 milestone Aug 13, 2026
@wmhn1872265132
wmhn1872265132 deleted the try-pgettext branch August 13, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants