fix(evals): prevent filter menus from overflowing on mobile#2313
fix(evals): prevent filter menus from overflowing on mobile#2313itsmelouis wants to merge 1 commit into
Conversation
|
@itsmelouis is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies the evals page filter bar layout in app/pages/evals.vue. The wrapper div switches from a single-row flex layout to a responsive column-to-row layout with updated alignment and spacing. The Categories and Agents USelectMenu components receive updated class values enabling flexible sizing on small screens while preserving existing visual styling. Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
N/A
❓ Type of change
📚 Description
I noticed this bug while browsing the evals page after seeing this tweet. :)
On mobile, the category and agent filter select menus overflow horizontally, causing a horizontal scroll on the whole page. This is because the header row forces the heading and two fixed-width (
w-52) selects on a single line.This PR stacks the heading above the filters below the
smbreakpoint and lets the two selects share the available width (flex-1) on mobile, while keeping the exact same layout on desktop (sm:w-52).