Rename Helm chart to helm-nuts-admin - #331
Merged
Merged
Conversation
Every other chart this org publishes to ghcr.io/nuts-foundation (helm-nuts-knooppunt, helm-pep, helm-fhir, helm-mock-vc-issuer) uses a helm- prefix; nuts-admin-chart was the only one that didn't. nuts-node-chart was the exception this borrowed the -chart suffix from, but it's published to GitHub Pages, a separate distribution channel with its own older naming. Assisted by AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the chart published in #330 from
nuts-admin-charttohelm-nuts-admin.Every other chart this org publishes to
ghcr.io/nuts-foundationuses ahelm-prefix:helm-nuts-knooppunt,helm-pep,helm-fhir,helm-mock-vc-issuer.nuts-admin-chartwas the only one that didn't — it borrowed the-chartsuffix fromnuts-node-chart, which is a different case: that one publishes to GitHub Pages, a separate distribution channel with its own older naming, notghcr.io.Updates:
charts/nuts-admin/Chart.yaml:name: nuts-admin-chart→name: helm-nuts-admin.github/workflows/helm-chart-release.yaml: existence check and push step reference the new namecharts/nuts-admin/README.md: install command updatedThe chart version stays
0.1.0— this is effectively the first publish under the correct name. The oldghcr.io/nuts-foundation/nuts-admin-chart:0.1.0package will be orphaned; someone withpackagesscope should delete it (myghtoken doesn't haveread:packages/write:packages, so I can't do it from here).Test plan
helm lint charts/nuts-adminhelm templaterenders (source showshelm-nuts-admin/templates/...)helm packageproduceshelm-nuts-admin-0.1.0.tgz, matching the workflow's expected filenameRelease Chartworkflow publisheshelm-nuts-admintoghcr.ioafter mergeAssisted by AI