Let an administrator create this month's invoices for a group - #48
Merged
Abdulmajidkhan007 merged 1 commit intoSep 9, 2026
Merged
Abdulmajidkhan007 merged 1 commit into
Abdulmajidkhan007 merged 1 commit into
Conversation
Invoices are normally generated after the month's lessons finish. When
that does not happen there was no way to recover from the UI, so the
payments screen gets a group picker and a button behind the new
`POST /invoice/{groupId}`.
A second press returns 409, which is not really an error — it means the
invoices are already there. That case gets its own message rather than
the server's English text; every other failure still shows what the
server said, since those are the ones an administrator cannot guess
(a level with no monthly fee, a group with no students).
Refunds are now sent as a negative amount. The backend adds whatever it
receives to the balance without looking at the transaction type — it
negates the monthly fee itself when it writes one — so a positive refund
would have grown the debt instead of shrinking it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B7ST2QLMxbKy7uj1gTp85n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoices are normally generated after the month's lessons finish. When that does not happen there was no way to recover from the UI, so the payments screen gets a group picker and a button behind the new
POST /invoice/{groupId}.A second press returns 409, which is not really an error — it means the invoices are already there. That case gets its own message rather than the server's English text; every other failure still shows what the server said, since those are the ones an administrator cannot guess (a level with no monthly fee, a group with no students).
Refunds are now sent as a negative amount. The backend adds whatever it receives to the balance without looking at the transaction type — it negates the monthly fee itself when it writes one — so a positive refund would have grown the debt instead of shrinking it.
Claude-Session: https://claude.ai/code/session_01B7ST2QLMxbKy7uj1gTp85n