Skip to content

[18.0][OU-FIX] account: fill company_id and journal_id for all existing payments #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][OU-FIX] account: fill company_id and journal_id for all existing payments #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions openupgrade_scripts/scripts/account/18.0.1.3/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
("account.payment", "memo", "char"),
("account.payment", "state", "selection"),
("account.payment", "is_sent", "boolean"),
("account.payment", "company_id", "many2one"),
("account.move", "made_sequence_gap", "boolean", True),
]

Expand Down Expand Up @@ -171,10 +172,10 @@ def fill_account_payment(env):
ELSE 'Draft Payment' END,
date = am.date,
journal_id = CASE WHEN ap.journal_id IS NULL
AND aj.type in ('bank', 'cash', 'credit')
THEN am.journal_id ELSE ap.journal_id END
THEN am.journal_id ELSE ap.journal_id END,
company_id = CASE WHEN ap.company_id IS NULL
THEN am.company_id ELSE ap.company_id END
FROM account_move am
LEFT JOIN account_journal aj ON am.journal_id = aj.id
WHERE ap.move_id = am.id""",
)

Expand Down
Loading