Skip to content

fix: use-after-free on bbolt mmap-backed cache slice #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianmcgee merged 1 commit into from
May 11, 2026
+4 −1
Merged

fix: use-after-free on bbolt mmap-backed cache slice #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion walk/cached.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package walk

import (
"bytes"
"context"
"errors"
"fmt"
Expand Down Expand Up @@ -102,7 +103,9 @@ func (c *CachedReader) Read(ctx context.Context, files []*File) (n int, err erro
for i := range n {
file := files[i]

file.CachedFormatSignature = bucket.Get([]byte(file.RelPath))
// Avoid use-after-free as bucket.Get returns a slice that is only valid for
// the lifetime of this transaction.
file.CachedFormatSignature = bytes.Clone(bucket.Get([]byte(file.RelPath)))

// set a release function which inserts this file into the update channel
file.AddReleaseFunc(func(ctx context.Context) error {
Expand Down