Skip to content

test: apply QA sweep fixes across host and sdk tests - #58

Open
mfw78 wants to merge 5 commits into
test/split-platform-suitesfrom
qa/hardened-boundaries-sweep
Open

test: apply QA sweep fixes across host and sdk tests#58
mfw78 wants to merge 5 commits into
test/split-platform-suitesfrom
qa/hardened-boundaries-sweep

Conversation

@mfw78

@mfw78 mfw78 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What

Sweep fixes applied:

  • Env flags read by value, not presence: VIDERE_SKIP_MISSING_WASMS/CI now treat empty/0/false as unset via flag_enabled + env_flag in crates/videre-host/tests/common/mod.rs, value semantics pinned by a new wasm_helper.rs test (commit d621858).
  • Cross-copy whitespace-predicate pin: exhaustive test padded_agrees_with_str_trim_over_every_code_point in crates/videre-sdk/src/client.rs walks all 1,112,064 code points at both ends against the str::trim oracle, ~0.85s under nextest (commit 3f89e6a).
  • zero_leak.rs dedup: reuses common::make_wasmtime_engine() and common::block(1), drops the byte-identical inline wasmtime config and Block literal plus the now-unused nexum bindings import (commit 7381f18).
  • Banner-hook exemption tightened (3 lens dupes consolidated): .claude/hooks/content-lint.sh now exempts only a true markdown table separator row (pipes/dashes/colons/spaces after the comment marker); pipe-free runs, =/*/_ runs, and dash runs beside other text count as banners again; probe-tested 7 banner shapes match and 7 table/clean shapes exempt, hook smoke-tested end-to-end (blocks banner, passes table row), zero hits repo-wide with the new pattern (commit 34e27fd).
  • Venue-brand neutralization: the bounded-fetch spy transport fixture in crates/videre-sdk/src/transport.rs never dials, so its request URL was decoration; swapped the one remaining real venue-brand string (api.cow.fi) for the reserved api.venue.example (commit 9a579e7).

Why

Part of #27.

Testing

All run inside nix develop (rustc 1.94.0, nextest 0.9.127) with RUSTFLAGS=-D warnings on the final tree:

  • cargo fmt --all --check PASS (after folding a rustfmt let-else expansion into the sdk test commit; first run failed on exactly that)
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings PASS
  • cargo test --doc --workspace --all-features --locked PASS
  • RUSTDOCFLAGS=-D warnings cargo doc --no-deps --workspace --locked PASS
  • just build-modules PASS, then cargo nextest run --workspace --all-features --no-fail-fast --locked PASS: 219/219 passed, 1 skipped (the pre-existing #[ignore]d videre-test regenerate_reference_fixtures, which passes when run with --run-ignored)
  • Both new tests confirmed executed and passing
  • Venue-brand rg (cowswap|cow.fi|cow protocol|cowprotocol|gpv2|composable|uniswap|1inch|balancer|sushiswap, case-insensitive) over videre-sdk/videre-host/videre-macros: zero hits (the repo's neutral placeholder id cow and std::borrow::Cow are baseline convention, not brand strings)
  • Banner-pattern rg over added lines of origin/refactor/host-wall-clock-seam..HEAD (.rs/.md): zero hits
  • Commit-message sweep of that same range for co-authored-by: clean

Stacked: merge bottom-up; full CI runs after retarget.

AI Assistance: Claude Code (Sonnet) implemented and tested these sweep fixes.

mfw78 added 5 commits August 7, 2026 01:09
VIDERE_SKIP_MISSING_WASMS=0 skipped anyway and an empty exported CI=
forced the hard fail; empty, 0, and false now read as unset, matching
the =1 spelling AGENTS.md documents, with the value semantics pinned in
wasm_helper.

AI Assistance: Claude Code applied this QA sweep finding and its test.
The sdk copy of the whitespace predicate hand-decodes UTF-8 while the
host and macros copies spell it with trim; nothing asserted the copies
agree. Walk every code point at both ends against the trim oracle so a
decoder slip cannot land silently.

AI Assistance: Claude Code applied this QA sweep finding and its test.
…_leak

The suite already includes tests/common but hand-built the wasmtime
config and the dispatch block byte-identical to make_wasmtime_engine
and block(1); use the fixtures and drop the duplicate literals.

AI Assistance: Claude Code applied this QA sweep finding.
…lint

The markdown-table fix exempted any comment line with a pipe after the
marker, wider than its stated intent: a pipe-bearing banner escaped
entirely. Only a separator-row shape (pipes, dashes, colons, spaces) is
exempt now; =/*/_ runs and dash runs beside other text count again.

AI Assistance: Claude Code tightened the pattern and probe-tested both sides.
The bounded-fetch spy never dials, so the request URL is decoration;
api.cow.fi was the one real venue-brand string left in the platform
crates, and the reserved venue.example keeps the fixture brand-neutral.

AI Assistance: Claude Code found the string in the sweep brand scan and swapped it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant