test: apply QA sweep fixes across host and sdk tests - #58
Open
mfw78 wants to merge 5 commits into
Open
Conversation
VIDERE_SKIP_MISSING_WASMS=0 skipped anyway and an empty exported CI= forced the hard fail; empty, 0, and false now read as unset, matching the =1 spelling AGENTS.md documents, with the value semantics pinned in wasm_helper. AI Assistance: Claude Code applied this QA sweep finding and its test.
The sdk copy of the whitespace predicate hand-decodes UTF-8 while the host and macros copies spell it with trim; nothing asserted the copies agree. Walk every code point at both ends against the trim oracle so a decoder slip cannot land silently. AI Assistance: Claude Code applied this QA sweep finding and its test.
…_leak The suite already includes tests/common but hand-built the wasmtime config and the dispatch block byte-identical to make_wasmtime_engine and block(1); use the fixtures and drop the duplicate literals. AI Assistance: Claude Code applied this QA sweep finding.
…lint The markdown-table fix exempted any comment line with a pipe after the marker, wider than its stated intent: a pipe-bearing banner escaped entirely. Only a separator-row shape (pipes, dashes, colons, spaces) is exempt now; =/*/_ runs and dash runs beside other text count again. AI Assistance: Claude Code tightened the pattern and probe-tested both sides.
The bounded-fetch spy never dials, so the request URL is decoration; api.cow.fi was the one real venue-brand string left in the platform crates, and the reserved venue.example keeps the fixture brand-neutral. AI Assistance: Claude Code found the string in the sweep brand scan and swapped it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sweep fixes applied:
VIDERE_SKIP_MISSING_WASMS/CInow treat empty/0/false as unset viaflag_enabled+env_flagincrates/videre-host/tests/common/mod.rs, value semantics pinned by a newwasm_helper.rstest (commit d621858).padded_agrees_with_str_trim_over_every_code_pointincrates/videre-sdk/src/client.rswalks all 1,112,064 code points at both ends against thestr::trimoracle, ~0.85s under nextest (commit 3f89e6a).zero_leak.rsdedup: reusescommon::make_wasmtime_engine()andcommon::block(1), drops the byte-identical inline wasmtime config andBlockliteral plus the now-unused nexum bindings import (commit 7381f18)..claude/hooks/content-lint.shnow exempts only a true markdown table separator row (pipes/dashes/colons/spaces after the comment marker); pipe-free runs,=/*/_runs, and dash runs beside other text count as banners again; probe-tested 7 banner shapes match and 7 table/clean shapes exempt, hook smoke-tested end-to-end (blocks banner, passes table row), zero hits repo-wide with the new pattern (commit 34e27fd).crates/videre-sdk/src/transport.rsnever dials, so its request URL was decoration; swapped the one remaining real venue-brand string (api.cow.fi) for the reservedapi.venue.example(commit 9a579e7).Why
Part of #27.
Testing
All run inside
nix develop(rustc 1.94.0, nextest 0.9.127) withRUSTFLAGS=-D warningson the final tree:cargo fmt --all --checkPASS (after folding a rustfmt let-else expansion into the sdk test commit; first run failed on exactly that)cargo clippy --workspace --all-targets --all-features --locked -- -D warningsPASScargo test --doc --workspace --all-features --lockedPASSRUSTDOCFLAGS=-D warnings cargo doc --no-deps --workspace --lockedPASSjust build-modulesPASS, thencargo nextest run --workspace --all-features --no-fail-fast --lockedPASS: 219/219 passed, 1 skipped (the pre-existing#[ignore]dvidere-testregenerate_reference_fixtures, which passes when run with--run-ignored)rg(cowswap|cow.fi|cow protocol|cowprotocol|gpv2|composable|uniswap|1inch|balancer|sushiswap, case-insensitive) overvidere-sdk/videre-host/videre-macros: zero hits (the repo's neutral placeholder idcowandstd::borrow::Coware baseline convention, not brand strings)rgover added lines oforigin/refactor/host-wall-clock-seam..HEAD(.rs/.md): zero hitsStacked: merge bottom-up; full CI runs after retarget.
AI Assistance: Claude Code (Sonnet) implemented and tested these sweep fixes.