chore: delete banner-divider comments - #56
Open
mfw78 wants to merge 2 commits into
Open
Conversation
Delete the seven banner-divider comments in platform.rs and registry.rs. Add the AGENTS.md house rule and extend content-lint.sh to block a newly added banner line in a .rs or .md file. AI Assistance: Claude Code deleted the banners, wrote the rule, and extended the hook.
Exclude a pipe on either side of the ASCII divider run, so a markdown table separator in a doc comment is not read as a banner, and add the block-comment prefix so a `/* ----- */` divider is caught. Note the banner check in the AGENTS.md hook summary, which still described content-lint.sh as an em-dash check only. AI Assistance: Claude Code found the false positive and wrote the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes all seven banner-divider comments the repo carries on the stack tip: six in
crates/videre-host/tests/platform.rs(fixtures + assembly, world contract, intent-status subscription E2E, echo round trip, venue-adapter trap recovery, service-missing unknown-venue) and one incrates/videre-host/src/registry.rs(status watch + polling). Each deletion collapses to a single blank line, no code moved and no behaviour change. Adds an AGENTS.md house rule (two lines after the em-dash rule): do not use a banner or section-divider line comment, a section is a module boundary, split the file or add nothing. Extends.claude/hooks/content-lint.shwith a secondcheckcall reusing the existing net-increase-vs-HEAD semantics, matching a box-drawing run or an ASCII comment divider in.rs/.mdfiles while excluding a markdown table separator.Why
Part of #27. Implements #44, which called for removing banner comments across the codebase in line with the house rule that a section boundary should be a module split, not a divider comment. The base branch carried six banners in
platform.rsplus one inregistry.rs, not the eight the issue text claimed, so that count was stale; this PR removes every banner actually present and adds hook enforcement plus a written house rule so none return.Testing
Independent gate run on a fresh clone of
nullislabs/videre-nexum-module, detached atorigin/chore/delete-banners, toolchain rustc/cargo 1.94.0, withRUSTFLAGS="-D warnings"and--lockedto mirror.github/workflows/ci.yml. The diff under review touches 4 files (+6/-15):.claude/hooks/content-lint.sh,AGENTS.md,crates/videre-host/src/registry.rs,crates/videre-host/tests/platform.rs, withvidere-hostthe only touched crate.cargo clippy -p videre-host --all-targets --all-features --locked -- -D warningsclean, exit 0.cargo test --doc -p videre-host --all-features --lockedexit 0: 0 passed, 0 failed, 0 ignored (crate declares no doctests)..rs/.md, for box-drawing runs and ASCII comment dividers, confirming zero remaining after the change.AI Assistance
claude-fable-5 implemented, claude-opus-5 red-teamed, claude-sonnet-5 wrote this PR.