chore: bump nexum-runtime pins to db39b6c1 - #51
Open
mfw78 wants to merge 3 commits into
Open
Conversation
Move every nexum-runtime and nexum-tasks rev from d78a368a to db39b6c1 and refresh Cargo.lock. Drop the all-zero component digest placeholder from the four module manifests (rejected at manifest parse since rt#79) and repin wit/deps.toml (WIT is unchanged between the revs). Absorb the API fallout from the runtime PRs in between: the ModuleId newtype at run.module (rt#91), the ModuleEntry/BootEnv boot_single shape (rt#98), the mandatory ProviderManifest component_digest (rt#79), FakeNode replacing MockChainProvider, subscription_plan() replacing extension_subscription_kinds(), and the chain-subscription boot gate (rt#75), which now requires [chains] entries in the test configs. Adapter liveness assertions move to the new VenueRegistry::alive_venue_count, since the supervisor no longer exposes adapter_alive_count. The blank-name refusal now fires at manifest parse (rt#96), one layer before the venue-id boundary.
The test gated on an `example.wasm` that no crate in this repo produces, so it has skipped since the carve and its assertions never ran. Boot it from the echo-client wasm and the existing echo-client status manifest, dropping the orphaned fixture and renaming the helper that named the absent module. Derive the boot env through `BootEnv::from_config` over one test engine config rather than assembling the struct field by field, so the test tracks the production derivation instead of shadowing it.
`venue_count` counts dead entries too, so its "routable" claim belonged to `alive_venue_count`. The venue-id note described a runtime fallback namespace that rt#96 removed when it started refusing a blank `[module].name` at manifest parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps every
nexum-runtime/nexum-tasksgit rev fromd78a368atodb39b6c1(10 dependency lines across 6Cargo.tomlfiles, pluswit/deps.tomlwhose WIT payload is unchanged between the revs), refreshesCargo.lock, and deletes the all-zero component digest placeholder from all four module manifests (echo-client,echo-keeper,echo-venue,flaky-venue) since the runtime now rejects it at parse. Absorbs the compile fallout from the intervening runtime PRs:run.moduleis now aModuleIdnewtype (.as_str()at three call sites),boot_singletakesModuleEntry+BootEnv(newtest_boot_env/boot_onehelpers inplatform.rs),ProviderManifestgained a mandatorycomponent_digest(the handshake test helper now fabricates one),MockChainProviderbecametest_utils::rpc::FakeNode,extension_subscription_kinds()becamesubscription_plan().extension_kinds, and the chain-subscription boot gate now requires[chains]in the e2eEngineConfigs(test_chain_configs()) as well.Why
Keeps this module building against current
nexum-runtimeandnexum-tasks, and removes a placeholder digest that the runtime now hard-rejects at manifest parse time. Closes #50Testing
All commands run in the repo's pinned
nix developshell (rustc 1.94.0, matching the CI toolchain pin), on a fresh clone detached at the branch tip, with--lockedthroughout.cargo clippy --locked --workspace --all-targets --all-features -- -D warnings: clean, no warnings (RUSTFLAGS=-D warnings)RUSTDOCFLAGS='-D warnings' cargo doc --locked --workspace --no-deps: clean, docs generated for all 10 cratesjust build-modules: all four guest wasms built forwasm32-wasip2 --release: echo-venue, echo-client, echo-keeper, flaky-venueCI=1 cargo nextest run --locked --workspace --all-features --no-fail-fast: 180 tests run: 180 passed, 1 skipped (the skip isvidere-test reference::tests::regenerate_reference_fixtures, a pre-existing#[ignore]d fixture regenerator, not a gate)Red-teamed against nexum-runtime at both revs (cloned upstream and read the 24 commits in
d78a368a..db39b6c1rather than trusting the report). The bump itself is sound; two follow-up commits fix one vacuous test and three doc/simplification defects, gate green after the fixes.AI Assistance
Implemented with claude-fable-5, red-teamed with claude-opus-5, PR authored with claude-sonnet-5.