Skip to content

chore(videre): terse rustdoc and dedup QA sweep - #41

Open
mfw78 wants to merge 4 commits into
feat/venue-logging-capabilityfrom
chore/qa-sweep-terse-dedup
Open

chore(videre): terse rustdoc and dedup QA sweep#41
mfw78 wants to merge 4 commits into
feat/venue-logging-capabilityfrom
chore/qa-sweep-terse-dedup

Conversation

@mfw78

@mfw78 mfw78 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What

Rebases the three QA-sweep commits (docs/refactor/test) onto the reworked feat/venue-logging-capability base, dropping the hunks the base already supersedes.

  • videre-host/src/registry.rs: renames window_ms to saturating_ms and has SystemClock::now_ms reuse it, drops derive_more::Into from VenueId (keeping AsRef/Display), tersens the rustdoc on VenueId, QUOTE_HORIZON_MS, the quotes field, record_quote, and check_quote_freshness, converts several matches! assertions to assert_eq!, and adds two registry tests: a_re_quote_refreshes_and_re_arms (re-quoting the same bytes refreshes the ledger entry, the refreshed valid-until-ms governs staleness, and a fresh quote after a refusal re-arms the body) and an over-cap unchecked-submit case appended to the existing ledger-cap test.
  • videre-sdk/src/client.rs and videre-sdk/src/keeper.rs: Venue::classify_denied's default now delegates to keeper::DROP_DENIED (now pub(crate)) instead of restating the drop rule inline, tersens the surrounding rustdoc, and replaces sweep_and_free_fn_agree with a_softened_denial_keeps_the_watch_then_drops_on_the_repeat, dropping the free-fn-vs-sweep-default assertions that the rework's retry_action changes made redundant.
  • videre-host/src/client.rs and videre-sdk/tests/adapter.rs: converts assert!(matches!(...)) error-path assertions to assert_eq! against the unwrapped error, and tersens one doc comment.
  • videre-macros/src/lib.rs and videre-macros/src/world.rs: tersens two rustdoc comments and adds a one-line test comment noting the adapter-ident pass-through is a deliberate pin, not merely logging-specific.
  • modules/fixtures/logging-venue/src/lib.rs: drops two now-redundant doc comments (Test-only. and A zero native amount.).

The Clock trait's #[auto_impl(&, Arc)] and the auto_impl dependency in videre-host/Cargo.toml/Cargo.lock are left untouched; that cleanup belongs to #43.

Why

The prior sweep commits were cut against an earlier version of the venue-logging-capability base and no longer applied cleanly once that base was reworked (saturating_ms/window_ms rename, the QUOTE_GRACE_MS invariant, the body: &[u8] record_quote signature). This PR re-derives the sweep against the current base: the terseness and matches!-to-assert_eq! conversions still stand on their own merits, and the two new registry tests close gaps the base's re-quote and over-cap-unchecked-submit paths left uncovered. Part of #27.

Testing

  • cargo clippy -p videre-host -p videre-sdk -p videre-macros --all-targets --all-features -- -D warnings - exit 0, no warnings.
  • cargo test --doc -p videre-host -p videre-sdk -p videre-macros --all-features - exit 0.
  • RUSTDOCFLAGS='-D warnings' cargo doc --no-deps -p videre-host -p videre-sdk -p videre-macros - exit 0.
  • cargo nextest run -p videre-host -p videre-sdk -p videre-macros --all-features - all tests pass, including the new a_re_quote_refreshes_and_re_arms and the appended over-cap unchecked-submit case.

AI Assistance

Implemented with claude-fable-5, red-teamed with claude-opus-5, PR description written by claude-sonnet-5.

@mfw78

mfw78 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Deferred sweep finding filed: #42 (unify the quote-ledger Clock with the runtime's wall-clock seam; judged too large for this sweep). The upstream tracing-sink macro consolidation is noted in the glue comment and tracked via nullislabs/nexum-runtime#76.

@mfw78
mfw78 force-pushed the feat/venue-logging-capability branch from b50f7b8 to d6074fd Compare August 4, 2026 23:26
@mfw78
mfw78 force-pushed the chore/qa-sweep-terse-dedup branch from 6fc7b7e to 6d1e8f8 Compare August 4, 2026 23:26
@mfw78
mfw78 force-pushed the feat/venue-logging-capability branch from d6074fd to 9e64639 Compare August 6, 2026 16:11
mfw78 added 3 commits August 6, 2026 17:03
State the real reuse constraint on the venue tracing glue (the upstream
per-cap bindgen arm is doc(hidden) internal API with a WitBindgenHost
coupling), drop the self-restating clause on install_tracing, mark the
deliberate adapter-ident pass-through pin in the world test, and cut the
fixture doc lines that repeat their surroundings.

AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
Fold the QA sweep dedup findings into single statements:

- Venue::classify_denied default delegates to the one DROP_DENIED
  statement, so the trait default and Keeper::new cannot drift.
- Rename window_ms to saturating_ms so SystemClock reuses it instead of
  respelling the saturating conversion.
- Drop the unused derive_more::Into on the host VenueId; nothing
  consumed it.
- Trim rustdoc that restated the stale-quote contract, the quote-ledger
  bounds, the reconcile disposition seam, and the for_venue invariant at
  sibling sites; each contract keeps one canonical statement.
- Registry tests: pin the re-quote refresh and re-arm path (Occupied
  update, stale refusal, clean re-armed submit) and the over-cap submit
  degrading to unchecked; keeper tests drop phases restated verbatim by
  neighbouring tests.

AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
Swap assert!(matches!(..)) for assert_eq! at the UnknownVenue sites so a
failure diagnoses with the actual value, and trim the host client test
doc to its non-restated sentence.

AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
@mfw78
mfw78 force-pushed the chore/qa-sweep-terse-dedup branch from 6d1e8f8 to 74ba5ba Compare August 6, 2026 17:13
…y hold

Red-team follow-ups on the dedup car:

- The over-cap probe in the_quote_ledger_is_capped ran at the quoting
  instant, where a recorded over-cap entry is still fresh, so it passed
  whether or not the cap held. Move it past the clock advance, beside the
  live entry's refusal, and derive its body from the overflow count
  instead of a literal: it now fails on its own line when the cap guard
  goes.
- record_quote's trimmed doc claimed the cap leaves every quote
  unrecorded; the Occupied arm refreshes at the cap, which is the path
  the new re-quote test pins. Say "a digest not already recorded".
- VenueId's doc kept the invariant but dropped the mechanism that carries
  it, in the same pass that deleted the sibling statement in the client
  test. State the private field once, at the type.
- sweep_and_free_fn_agree no longer asserted on the free fn, so name it
  for the DropOnRepeat grace it does hold, and drop the see-also comments
  that this rename would have rotted.
- Carry the typed-equality rule to the remaining UnknownVenue and
  InvalidReceipt sites in the same two files.

AI Assistance: Claude Code (Opus 5) used for the red-team review and these fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant