chore(videre): terse rustdoc and dedup QA sweep - #41
Open
mfw78 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Deferred sweep finding filed: #42 (unify the quote-ledger Clock with the runtime's wall-clock seam; judged too large for this sweep). The upstream tracing-sink macro consolidation is noted in the glue comment and tracked via nullislabs/nexum-runtime#76. |
mfw78
force-pushed
the
feat/venue-logging-capability
branch
from
August 4, 2026 23:26
b50f7b8 to
d6074fd
Compare
mfw78
force-pushed
the
chore/qa-sweep-terse-dedup
branch
from
August 4, 2026 23:26
6fc7b7e to
6d1e8f8
Compare
mfw78
force-pushed
the
feat/venue-logging-capability
branch
from
August 6, 2026 16:11
d6074fd to
9e64639
Compare
State the real reuse constraint on the venue tracing glue (the upstream per-cap bindgen arm is doc(hidden) internal API with a WitBindgenHost coupling), drop the self-restating clause on install_tracing, mark the deliberate adapter-ident pass-through pin in the world test, and cut the fixture doc lines that repeat their surroundings. AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
Fold the QA sweep dedup findings into single statements: - Venue::classify_denied default delegates to the one DROP_DENIED statement, so the trait default and Keeper::new cannot drift. - Rename window_ms to saturating_ms so SystemClock reuses it instead of respelling the saturating conversion. - Drop the unused derive_more::Into on the host VenueId; nothing consumed it. - Trim rustdoc that restated the stale-quote contract, the quote-ledger bounds, the reconcile disposition seam, and the for_venue invariant at sibling sites; each contract keeps one canonical statement. - Registry tests: pin the re-quote refresh and re-arm path (Occupied update, stale refusal, clean re-armed submit) and the over-cap submit degrading to unchecked; keeper tests drop phases restated verbatim by neighbouring tests. AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
Swap assert!(matches!(..)) for assert_eq! at the UnknownVenue sites so a failure diagnoses with the actual value, and trim the host client test doc to its non-restated sentence. AI Assistance: Claude Code (Fable 5) used for the QA sweep consolidation and fixes
mfw78
force-pushed
the
chore/qa-sweep-terse-dedup
branch
from
August 6, 2026 17:13
6d1e8f8 to
74ba5ba
Compare
…y hold Red-team follow-ups on the dedup car: - The over-cap probe in the_quote_ledger_is_capped ran at the quoting instant, where a recorded over-cap entry is still fresh, so it passed whether or not the cap held. Move it past the clock advance, beside the live entry's refusal, and derive its body from the overflow count instead of a literal: it now fails on its own line when the cap guard goes. - record_quote's trimmed doc claimed the cap leaves every quote unrecorded; the Occupied arm refreshes at the cap, which is the path the new re-quote test pins. Say "a digest not already recorded". - VenueId's doc kept the invariant but dropped the mechanism that carries it, in the same pass that deleted the sibling statement in the client test. State the private field once, at the type. - sweep_and_free_fn_agree no longer asserted on the free fn, so name it for the DropOnRepeat grace it does hold, and drop the see-also comments that this rename would have rotted. - Carry the typed-equality rule to the remaining UnknownVenue and InvalidReceipt sites in the same two files. AI Assistance: Claude Code (Opus 5) used for the red-team review and these fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rebases the three QA-sweep commits (docs/refactor/test) onto the reworked
feat/venue-logging-capabilitybase, dropping the hunks the base already supersedes.videre-host/src/registry.rs: renameswindow_mstosaturating_msand hasSystemClock::now_msreuse it, dropsderive_more::IntofromVenueId(keepingAsRef/Display), tersens the rustdoc onVenueId,QUOTE_HORIZON_MS, thequotesfield,record_quote, andcheck_quote_freshness, converts severalmatches!assertions toassert_eq!, and adds two registry tests:a_re_quote_refreshes_and_re_arms(re-quoting the same bytes refreshes the ledger entry, the refreshedvalid-until-msgoverns staleness, and a fresh quote after a refusal re-arms the body) and an over-cap unchecked-submit case appended to the existing ledger-cap test.videre-sdk/src/client.rsandvidere-sdk/src/keeper.rs:Venue::classify_denied's default now delegates tokeeper::DROP_DENIED(nowpub(crate)) instead of restating the drop rule inline, tersens the surrounding rustdoc, and replacessweep_and_free_fn_agreewitha_softened_denial_keeps_the_watch_then_drops_on_the_repeat, dropping the free-fn-vs-sweep-default assertions that the rework'sretry_actionchanges made redundant.videre-host/src/client.rsandvidere-sdk/tests/adapter.rs: convertsassert!(matches!(...))error-path assertions toassert_eq!against the unwrapped error, and tersens one doc comment.videre-macros/src/lib.rsandvidere-macros/src/world.rs: tersens two rustdoc comments and adds a one-line test comment noting the adapter-ident pass-through is a deliberate pin, not merelylogging-specific.modules/fixtures/logging-venue/src/lib.rs: drops two now-redundant doc comments (Test-only.andA zero native amount.).The
Clocktrait's#[auto_impl(&, Arc)]and theauto_impldependency invidere-host/Cargo.toml/Cargo.lockare left untouched; that cleanup belongs to #43.Why
The prior sweep commits were cut against an earlier version of the venue-logging-capability base and no longer applied cleanly once that base was reworked (
saturating_ms/window_msrename, theQUOTE_GRACE_MSinvariant, thebody: &[u8]record_quotesignature). This PR re-derives the sweep against the current base: the terseness andmatches!-to-assert_eq!conversions still stand on their own merits, and the two new registry tests close gaps the base's re-quote and over-cap-unchecked-submit paths left uncovered. Part of #27.Testing
cargo clippy -p videre-host -p videre-sdk -p videre-macros --all-targets --all-features -- -D warnings- exit 0, no warnings.cargo test --doc -p videre-host -p videre-sdk -p videre-macros --all-features- exit 0.RUSTDOCFLAGS='-D warnings' cargo doc --no-deps -p videre-host -p videre-sdk -p videre-macros- exit 0.cargo nextest run -p videre-host -p videre-sdk -p videre-macros --all-features- all tests pass, including the newa_re_quote_refreshes_and_re_armsand the appended over-cap unchecked-submit case.AI Assistance
Implemented with claude-fable-5, red-teamed with claude-opus-5, PR description written by claude-sonnet-5.