refactor(runtime): bundle boot inputs into BootEnv - #98
Merged
Conversation
mfw78
force-pushed
the
seam/c2-builder-tail
branch
from
August 6, 2026 07:35
c29999b to
b1c30ad
Compare
…ensions AI Assistance: Claude (Fable 5) used for implementation and test updates
Mutation runs on the BootEnv car showed the load-bearing with_provider_kinds=false in boot_single and the env.configured_chains wiring were covered by no test: flipping either left the suite green. Add a serviceless-kind fixture pinning both sides of the flag (boot refuses, boot_single proceeds to the manifest gate) and a single-boot chain-gate refusal pinning the configured-chains wiring. AI Assistance: Claude Fable used for the retroactive review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bundles the loose
boot_singleboot inputs (limits, configured chains, digestrequirement) into a single
BootEnvstruct built viaBootEnv::from_config.wire_extensionsgains awith_provider_kindsflag soboot_singlecan shareit with
Supervisor::bootinstead of duplicating theSharedconstructioninline.
Why
boot_singlehad grown to six positional arguments derived from the sameEngineConfig, which made call sites easy to get wrong and hard to extend.Bundling them into
BootEnvremoves the#[allow(clippy::too_many_arguments)]escape hatch and gives future boot inputs one place to land.
Part of #94
Testing
cargo test -p nexum-runtime supervisor: 90 passed, 0 failedcargo test -p nexum-runtime: 419 passed, 0 failed, plus 1 passing doctestAI Assistance
Implementation by claude-fable-5, red-team review by claude-opus-5, PR by claude-sonnet-5.